Rewrite generalized_box_iou and box_iou to share code #3382
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3382 +/- ##
==========================================
- Coverage 74.80% 74.79% -0.01%
==========================================
Files 105 105
Lines 9716 9714 -2
Branches 1561 1561
==========================================
- Hits 7268 7266 -2
Misses 1961 1961
Partials 487 487
Continue to review full report at Codecov.
|
fmassa
approved these changes
Feb 11, 2021
There was a problem hiding this comment.
Looks great, thanks!
This is btw what I had done in DETR in https://github.com/facebookresearch/detr/blob/a54b77800eb8e64e3ad0d8237789fcbf2f8350c5/util/box_ops.py#L24-L61, thanks for doing this!
facebook-github-bot
pushed a commit
that referenced
this pull request
Feb 12, 2021
Reviewed By: mthrok Differential Revision: D26422440 fbshipit-source-id: bef833fa6a3dfd546897b1d81da3f2abaa54e0eb
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While investigating a numeric overflow at #3371, I noticed that the implementations of
generalized_box_iou()andbox_iou()duplicate code. A potential fix for the aforementioned issue would require patching the code in multiple places. It would be easier if instead we rewrite it to remove duplicate code.I'm filing this PR separately in case we choose an alternative fix for the overflow. I think the refactoring is worth it on its own merit.