Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.circleci: Add Python 3.9, CUDA 11.2 to CI #3341

Merged
merged 2 commits into from
Feb 12, 2021

Conversation

seemethere
Copy link
Member

(cherry picked from commit 2f40a48)
Signed-off-by: Eli Uriegas [email protected]

@seemethere seemethere force-pushed the add_python39_master branch 4 times, most recently from 38dd7df to 0641b14 Compare February 9, 2021 18:33
@seemethere seemethere changed the title .circleci: Add Python 3.9 to CI .circleci: Add Python 3.9, CUDA 11.2 to CI Feb 9, 2021
@seemethere seemethere marked this pull request as draft February 9, 2021 18:34
@seemethere seemethere force-pushed the add_python39_master branch 2 times, most recently from 51b0cda to 2cdff60 Compare February 9, 2021 18:42
- jpeg
- ffmpeg=4.2
- jpeg <= 9b
- ffmpeg >=4.2
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @andfoy, ffmpeg =4.2 wasn't actually working with python 3.9+ we may need to rebuild the packages for pytorch/builder.

Until then I'm allowing the packages to use the ffmpeg from conda-forge

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the notice! I'll rebuild the packages accordingly

@seemethere seemethere force-pushed the add_python39_master branch 5 times, most recently from d7b01ef to 526a7d4 Compare February 9, 2021 23:38
@seemethere seemethere marked this pull request as ready for review February 10, 2021 05:40
@seemethere seemethere requested review from fmassa and andfoy February 10, 2021 05:40
@codecov
Copy link

codecov bot commented Feb 10, 2021

Codecov Report

Merging #3341 (78b3c49) into master (5a31545) will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3341      +/-   ##
==========================================
+ Coverage   74.79%   74.80%   +0.01%     
==========================================
  Files         105      105              
  Lines        9714     9714              
  Branches     1561     1561              
==========================================
+ Hits         7266     7267       +1     
+ Misses       1961     1960       -1     
  Partials      487      487              
Impacted Files Coverage Δ
torchvision/datasets/utils.py 70.96% <0.00%> (+0.53%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5a31545...78b3c49. Read the comment docs.

@seemethere seemethere requested a review from a team February 10, 2021 18:05
(cherry picked from commit 2f40a48)
Signed-off-by: Eli Uriegas <[email protected]>
Copy link
Contributor

@andfoy andfoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! A new FFmpeg rebuild is required here, but since the tests are passing, there should not be any problem

Copy link
Contributor

@datumbox datumbox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, can we merge?

@@ -9,23 +9,27 @@ requirements:
build:
- {{ compiler('c') }} # [win]
- libpng
- jpeg
- ffmpeg =4.2 # [not win]
- jpeg <=9b
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this related to the problem we had on the past with the size_t type? If this is causing you massive headaches we can investigate how we could use the latest.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The jpeg pinning is required to ensure that it is installed from the Anaconda defaults channel, as opposed to conda-forge, since it could cause conflicts with libjpeg-turbo. #2818 should fix this

@seemethere
Copy link
Member Author

Just rebased, will merge after green again

@seemethere seemethere merged commit 2857536 into pytorch:master Feb 12, 2021
@seemethere seemethere deleted the add_python39_master branch February 12, 2021 01:09
facebook-github-bot pushed a commit that referenced this pull request Feb 12, 2021
Summary:
(cherry picked from commit 2f40a48)
Signed-off-by: Eli Uriegas <[email protected]>

Reviewed By: mthrok

Differential Revision: D26422437

fbshipit-source-id: 78cb00d643787ead2b1c0dcbea40eb7856660cf0
@fmassa fmassa mentioned this pull request May 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants