-
Notifications
You must be signed in to change notification settings - Fork 7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
.circleci: Add Python 3.9, CUDA 11.2 to CI #3341
Conversation
38dd7df
to
0641b14
Compare
51b0cda
to
2cdff60
Compare
- jpeg | ||
- ffmpeg=4.2 | ||
- jpeg <= 9b | ||
- ffmpeg >=4.2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cc @andfoy, ffmpeg =4.2
wasn't actually working with python 3.9+
we may need to rebuild the packages for pytorch/builder
.
Until then I'm allowing the packages to use the ffmpeg
from conda-forge
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the notice! I'll rebuild the packages accordingly
d7b01ef
to
526a7d4
Compare
cca2db8
to
4609896
Compare
Codecov Report
@@ Coverage Diff @@
## master #3341 +/- ##
==========================================
+ Coverage 74.79% 74.80% +0.01%
==========================================
Files 105 105
Lines 9714 9714
Branches 1561 1561
==========================================
+ Hits 7266 7267 +1
+ Misses 1961 1960 -1
Partials 487 487
Continue to review full report at Codecov.
|
09c54e0
to
e8e50c1
Compare
(cherry picked from commit 2f40a48) Signed-off-by: Eli Uriegas <[email protected]>
e8e50c1
to
5afde0e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! A new FFmpeg rebuild is required here, but since the tests are passing, there should not be any problem
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, can we merge?
@@ -9,23 +9,27 @@ requirements: | |||
build: | |||
- {{ compiler('c') }} # [win] | |||
- libpng | |||
- jpeg | |||
- ffmpeg =4.2 # [not win] | |||
- jpeg <=9b |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this related to the problem we had on the past with the size_t type? If this is causing you massive headaches we can investigate how we could use the latest.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The jpeg pinning is required to ensure that it is installed from the Anaconda defaults channel, as opposed to conda-forge, since it could cause conflicts with libjpeg-turbo. #2818 should fix this
Just rebased, will merge after green again |
Summary: (cherry picked from commit 2f40a48) Signed-off-by: Eli Uriegas <[email protected]> Reviewed By: mthrok Differential Revision: D26422437 fbshipit-source-id: 78cb00d643787ead2b1c0dcbea40eb7856660cf0
(cherry picked from commit 2f40a48)
Signed-off-by: Eli Uriegas [email protected]