Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unneeded ifdef in nms_kernel.cu #3326

Merged
merged 3 commits into from
Jan 29, 2021
Merged

Remove unneeded ifdef in nms_kernel.cu #3326

merged 3 commits into from
Jan 29, 2021

Conversation

fmassa
Copy link
Member

@fmassa fmassa commented Jan 29, 2021

They are reminiscent from a previous implementation and not needed anymore, as we now have everything under cuda/ folder to only be compiled if WITH_CUDA is enabled.

@fmassa fmassa requested a review from datumbox January 29, 2021 13:23
datumbox
datumbox approved these changes Jan 29, 2021
View reviewed changes
Copy link
Contributor

@datumbox datumbox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@codecov
Copy link

codecov bot commented Jan 29, 2021 •
edited
Loading

Codecov Report

Merging #3326 (84b6b9d) into master (3673716) will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3326   +/-   ##
=======================================
  Coverage   73.96%   73.97%           
=======================================
  Files         104      104           
  Lines        9607     9606    -1     
  Branches     1537     1537           
=======================================
  Hits         7106     7106           
+ Misses       2024     2023    -1     
  Partials      477      477
Impacted Files Coverage Δ
torchvision/models/segmentation/segmentation.py 75.00% <0.00%> (+0.92%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3673716...1bf6e61. Read the comment docs.

@datumbox datumbox merged commit 09ce675 into pytorch:master Jan 29, 2021
@fmassa fmassa deleted the cleanup-nms-kernel branch January 29, 2021 15:31
facebook-github-bot pushed a commit that referenced this pull request Feb 4, 2021
@NicolasHug @facebook-github-bot
Remove unneded ifdef in nms_kernel.cu (#3326)
2f08df3 
Summary: Co-authored-by: Vasilis Vryniotis <[email protected]>

Reviewed By: datumbox

Differential Revision: D26226608

fbshipit-source-id: 5e41f6a6dc08515079a33f7107898ec3dca12e18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@datumbox datumbox datumbox approved these changes

Assignees
No one assigned
Labels
cla signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fmassa @datumbox @facebook-github-bot