Static analysis improvements python #3263
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhiqwang
reviewed
Jan 19, 2021
fmassa
reviewed
Jan 20, 2021
| num_blocks = 0 | ||
| for m in self.inner_blocks: | ||
| num_blocks += 1 | ||
| num_blocks = len(self.inner_blocks) |
There was a problem hiding this comment.
Oh, great to see that this is already supported by torchscript :-)
facebook-github-bot
pushed a commit
that referenced
this pull request
Jan 21, 2021
Summary: * Simplify code and remove used vars. * Simplify expressions and remove used parenthesis. * Jit fixes. * Making check more readable. * fixing styles Reviewed By: datumbox Differential Revision: D25954566 fbshipit-source-id: 7ae7966e3c9b91e1f93b42e1c1a8f93cfef19643
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My IDE gets all the credit. :D