Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update required cmake version #3212

Merged
merged 1 commit into from
Jan 4, 2021
Merged

Update required cmake version #3212

merged 1 commit into from
Jan 4, 2021

Conversation

ppwwyyxx
Copy link
Contributor

find_package(Python3 COMPONENTS Development) is used in this CMakeLists.txt. This feature is supported only after cmake 3.12:

`find_package(Python3 COMPONENTS Development)` is used in this `CMakeLists.txt`. This feature is supported only after cmake 3.12:

* 3.12: https://cmake.org/cmake/help/v3.12/module/FindPython3.html?highlight=python3
* 3.11: https://cmake.org/cmake/help/v3.11/search.html?q=python3
Copy link
Contributor

@datumbox datumbox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@datumbox datumbox merged commit 8d3c507 into master Jan 4, 2021
@fmassa fmassa deleted the ppwwyyxx-patch-1 branch January 4, 2021 18:36
facebook-github-bot pushed a commit that referenced this pull request Jan 21, 2021
Summary: `find_package(Python3 COMPONENTS Development)` is used in this `CMakeLists.txt`. This feature is supported only after cmake 3.12.

Reviewed By: datumbox

Differential Revision: D25954552

fbshipit-source-id: e043f222f7cc887313ff2e3d5128b9e308950995
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants