Cleanup functional_tensor.py (#3159)

[avijit9]

Fixes #3159

[facebook-github-bot]

Hi @avijit9!

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file.

In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

[datumbox]

@avijit9 Thanks a lot for the PR and for your investigation on the original proposal!

I left a few comments, please let me know what you think.

[codecov]

Codecov Report

Merging #3171 (5ec23a9) into master (90645cc) will increase coverage by 0.39%.
The diff coverage is 78.78%.

@@            Coverage Diff             @@
##           master    #3171      +/-   ##
==========================================
+ Coverage   73.09%   73.48%   +0.39%     
==========================================
  Files          99       99              
  Lines        9241     9230      -11     
  Branches     1493     1476      -17     
==========================================
+ Hits         6755     6783      +28     
+ Misses       2015     1991      -24     
+ Partials      471      456      -15     

Impacted Files	Coverage Δ
torchvision/transforms/functional_tensor.py	79.34% <78.78%> (+6.87%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 90645cc...5ec23a9. Read the comment docs.

[datumbox]

@avijit9 Thanks for the changes. Your PR looks great!

Note that we just merged a PR that adds a 6 more functional transforms. Would you mind making your changes to those as well?

vision/torchvision/transforms/functional_tensor.py

Lines 1187 to 1188 in 83171d6

	if not _is_tensor_a_torch_image(img):
	raise TypeError('tensor is not a torch image.')

vision/torchvision/transforms/functional_tensor.py

Lines 1200 to 1201 in 83171d6

	if not _is_tensor_a_torch_image(img):
	raise TypeError('tensor is not a torch image.')

vision/torchvision/transforms/functional_tensor.py

Lines 1214 to 1215 in 83171d6

	if not _is_tensor_a_torch_image(img):
	raise TypeError('tensor is not a torch image.')

vision/torchvision/transforms/functional_tensor.py

Lines 1248 to 1249 in 83171d6

	if not _is_tensor_a_torch_image(img):
	raise TypeError('tensor is not a torch image.')

vision/torchvision/transforms/functional_tensor.py

Lines 1260 to 1261 in 83171d6

	if not _is_tensor_a_torch_image(img):
	raise TypeError('tensor is not a torch image.')

vision/torchvision/transforms/functional_tensor.py

Lines 1300 to 1301 in 83171d6

	if not _is_tensor_a_torch_image(img):
	raise TypeError('tensor is not a torch image.')

If you are busy let me know and I'll do it. Just make sure I got write access to your branch and I'll push it there so that you get credit for the changes.

[avijit9]

@datumbox No problem. I have made the changes and pushing them now. Thanks for being awesome :)

[datumbox]

@avijit9 Looks great! I added one comment which I think it's due to wrong copy-paste. Let me know if you agree. :)