Exposing LevelMapper params in MultiScaleRoIAlign (pytorch#3129) #3151
Conversation
Ability to set the `canonical_scale` and `canonical_level` of LevelMapper from the init method of MultiScaleRoIAlign. Not sure if this is the right place to expose those parameters. Also, additional tests should be written. Discussion in issue pytorch#3129
|
Hi @baldassarreFe! Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. If you have received this in error or have any questions, please contact us at [email protected]. Thanks! |
Codecov Report
@@ Coverage Diff @@
## master #3151 +/- ##
==========================================
- Coverage 73.14% 72.76% -0.38%
==========================================
Files 99 99
Lines 9256 8981 -275
Branches 1493 1431 -62
==========================================
- Hits 6770 6535 -235
+ Misses 2015 1999 -16
+ Partials 471 447 -24
Continue to review full report at Codecov.
|
Summary: * Exposing LevelMapper params in MultiScaleRoIAlign Ability to set the `canonical_scale` and `canonical_level` of LevelMapper from the init method of MultiScaleRoIAlign. Not sure if this is the right place to expose those parameters. Also, additional tests should be written. Discussion in issue #3129 * MultiScaleRoIAlign keyword-only parameters + docs (#3129) * Linter fix (trailing whitespace) Reviewed By: datumbox Differential Revision: D25954558 fbshipit-source-id: 4c54b17925fed520e38b35d8b76f8148499ea943 Co-authored-by: Francisco Massa <[email protected]>
Ability to set the canonical_scale and canonical_level of LevelMapper from the init method of MultiScaleRoIAlign.
Discussion in: #3129
Before merging: