Remove torchvision.io from test_utils.py #3092
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For now this simplifies a few things for fbcode integration. We can add this back in the future
datumbox
reviewed
Dec 2, 2020
| @@ -90,9 +90,10 @@ def test_draw_boxes(self): | |||
|
|
|||
| path = os.path.join(os.path.dirname(os.path.abspath(__file__)), "assets", "fakedata", "draw_boxes_util.png") | |||
| if not os.path.exists(path): | |||
| write_png(result, path) | |||
| res = Image.fromarray(result.permute(1, 2, 0).contiguous().numpy()) | |||
| res.save(path) | |||
There was a problem hiding this comment.
This was recently changed based on your comment. What's the issue using the io.image here?
There was a problem hiding this comment.
Right, my bad sorry about that.
Internal fb tests were failing because this test now imposes that the image part of torchvision is compiled, and we would need to adapt some TARGETS file for that. In order to move forward with fbcode integration, it's easier to first change to using PIL, then update the TARGETS file in fbcode and then add back the dependency to torchvision.io.
vfdev-5
pushed a commit
to Quansight/vision
that referenced
this pull request
Dec 4, 2020
For now this simplifies a few things for fbcode integration. We can add this back in the future
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For now this simplifies a few things for fbcode integration. We can add this back in the future