Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove noexcept from cuda_version #3091

Merged
merged 1 commit into from
Dec 2, 2020
Merged

Conversation

fmassa
Copy link
Member

@fmassa fmassa commented Dec 2, 2020

Operator registration of functions with noexcept doesn't work on some compilers, see pytorch/pytorch#48667

cc @bmanga FYI

Operator registration of functions with noexcept doesn't work on some compilers, see pytorch/pytorch#48667
@fmassa fmassa requested a review from datumbox December 2, 2020 09:50
@fmassa fmassa merged commit ac288ea into pytorch:master Dec 2, 2020
@fmassa fmassa deleted the remove_noexcept branch December 2, 2020 10:58
@bmanga
Copy link
Contributor

bmanga commented Dec 2, 2020

Ouch, sorry about that 😅

vfdev-5 pushed a commit to Quansight/vision that referenced this pull request Dec 4, 2020
Operator registration of functions with noexcept doesn't work on some compilers, see pytorch/pytorch#48667
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants