Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update resnet18 test value to fix tests #2978

Merged
merged 1 commit into from
Nov 9, 2020

Conversation

datumbox
Copy link
Contributor

@datumbox datumbox commented Nov 9, 2020

Change the SUM_OF_PRETRAINED_RESNET18_PARAMS decimal values to resolve broken tests on Travis:

@codecov
Copy link

codecov bot commented Nov 9, 2020

Codecov Report

Merging #2978 (07d0748) into master (3852b41) will increase coverage by 0.32%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2978      +/-   ##
==========================================
+ Coverage   73.41%   73.73%   +0.32%     
==========================================
  Files          99       99              
  Lines        8812     8945     +133     
  Branches     1389     1419      +30     
==========================================
+ Hits         6469     6596     +127     
- Misses       1917     1923       +6     
  Partials      426      426              
Impacted Files Coverage Δ
torchvision/models/detection/mask_rcnn.py 90.76% <0.00%> (+0.14%) ⬆️
torchvision/models/detection/keypoint_rcnn.py 89.04% <0.00%> (+0.15%) ⬆️
torchvision/models/detection/faster_rcnn.py 82.02% <0.00%> (+0.20%) ⬆️
torchvision/models/detection/backbone_utils.py 94.91% <0.00%> (+0.62%) ⬆️
torchvision/ops/deform_conv.py 72.44% <0.00%> (+1.48%) ⬆️
torchvision/models/inception.py 86.85% <0.00%> (+2.21%) ⬆️
torchvision/models/shufflenetv2.py 89.05% <0.00%> (+3.00%) ⬆️
torchvision/ops/feature_pyramid_network.py 94.50% <0.00%> (+3.29%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3852b41...07d0748. Read the comment docs.

Copy link
Member

@fmassa fmassa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@fmassa fmassa merged commit 1f4e3a4 into pytorch:master Nov 9, 2020
@datumbox datumbox deleted the tests/fixing_resnet18_value branch November 9, 2020 16:52
datumbox added a commit that referenced this pull request Nov 11, 2020
… to resolve broken tests. (#2978)"

This reverts commit 1f4e3a4.
datumbox added a commit that referenced this pull request Nov 12, 2020
… to resolve broken tests. (#2978)" (#2990)

This reverts commit 1f4e3a4.
bryant1410 pushed a commit to bryant1410/vision-1 that referenced this pull request Nov 22, 2020
bryant1410 pushed a commit to bryant1410/vision-1 that referenced this pull request Nov 22, 2020
vfdev-5 pushed a commit to Quansight/vision that referenced this pull request Dec 4, 2020
vfdev-5 pushed a commit to Quansight/vision that referenced this pull request Dec 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants