Static Analysis corrections on c++ model classes #2893
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Convert unnecessary value parameter to constant reference. - Use move to avoid unnecessary copies. - Eliminate unused include.
fmassa
reviewed
Oct 26, 2020
There was a problem hiding this comment.
Changes look good to me overall, but I have a question wrt explicit constructors.
Also, FYI I believe we have disabled C++ model tests in torchvision CI
Line 169 in d8ccbe7
Thanks for letting me know. I re-enabled locally the C++ tests on |
bryant1410
pushed a commit
to bryant1410/vision-1
that referenced
this pull request
Nov 22, 2020
* Minor refactoring based on static analysis on the code of models: - Convert unnecessary value parameter to constant reference. - Use move to avoid unnecessary copies. - Eliminate unused include. * Replace moves with const references. * Fixing formatting. * Remove explicit declaration on constructors.
vfdev-5
pushed a commit
to Quansight/vision
that referenced
this pull request
Dec 4, 2020
* Minor refactoring based on static analysis on the code of models: - Convert unnecessary value parameter to constant reference. - Use move to avoid unnecessary copies. - Eliminate unused include. * Replace moves with const references. * Fixing formatting. * Remove explicit declaration on constructors.
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minor refactoring based on static analysis and manual review of the code of models:
Post discussion with @fmassa, we might not want these changes to keep the C++ API easy to understand. Let me know if there is any thing we want to cherrypick from here else feel free to close the PR.