-
Notifications
You must be signed in to change notification settings - Fork 7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed the docstring of RandomResizedCrop #2851
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR @frgfm
I left few comments
Codecov Report
@@ Coverage Diff @@
## master #2851 +/- ##
==========================================
+ Coverage 73.35% 73.36% +0.01%
==========================================
Files 99 99
Lines 8785 8787 +2
Branches 1387 1387
==========================================
+ Hits 6444 6447 +3
Misses 1916 1916
+ Partials 425 424 -1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks @frgfm !
* docs: Fixed docstring of RandomResizedCrop * docs: Updated docstring Co-authored-by: vfdev <[email protected]>
* docs: Fixed docstring of RandomResizedCrop * docs: Updated docstring Co-authored-by: vfdev <[email protected]>
Hello there 👋
As I was myself a bit confused about the meaning of
RandomResizedCrop
arguments, I made a small edit suggestion to close #2357.Any feedback is welcome!