Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed the docstring of RandomResizedCrop #2851

Merged
merged 4 commits into from
Oct 21, 2020

Conversation

frgfm
Copy link
Contributor

@frgfm frgfm commented Oct 21, 2020

Hello there 👋

As I was myself a bit confused about the meaning of RandomResizedCrop arguments, I made a small edit suggestion to close #2357.

Any feedback is welcome!

Copy link
Collaborator

@vfdev-5 vfdev-5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @frgfm
I left few comments

torchvision/transforms/transforms.py Outdated Show resolved Hide resolved
torchvision/transforms/transforms.py Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Oct 21, 2020

Codecov Report

Merging #2851 into master will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2851      +/-   ##
==========================================
+ Coverage   73.35%   73.36%   +0.01%     
==========================================
  Files          99       99              
  Lines        8785     8787       +2     
  Branches     1387     1387              
==========================================
+ Hits         6444     6447       +3     
  Misses       1916     1916              
+ Partials      425      424       -1     
Impacted Files Coverage Δ
torchvision/transforms/transforms.py 81.04% <ø> (ø)
torchvision/ops/poolers.py 98.07% <100.00%> (+1.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 005355b...836bc91. Read the comment docs.

@frgfm frgfm requested a review from vfdev-5 October 21, 2020 12:02
Copy link
Collaborator

@vfdev-5 vfdev-5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @frgfm !

@vfdev-5 vfdev-5 merged commit 57b653c into pytorch:master Oct 21, 2020
@frgfm frgfm deleted the randomresized-doc branch October 21, 2020 15:23
bryant1410 pushed a commit to bryant1410/vision-1 that referenced this pull request Nov 22, 2020
* docs: Fixed docstring of RandomResizedCrop

* docs: Updated docstring

Co-authored-by: vfdev <[email protected]>
vfdev-5 added a commit to Quansight/vision that referenced this pull request Dec 4, 2020
* docs: Fixed docstring of RandomResizedCrop

* docs: Updated docstring

Co-authored-by: vfdev <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RandomResizedCrop aspect_ratio is wrong
3 participants