-
Notifications
You must be signed in to change notification settings - Fork 7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[videoAPI] minor example and documentation changes #2821
Conversation
@bjuncek on Colab running the notebook on
What do you think to add a message about to install manually ffmpeg and build torchvision from tag to have the feature ?
import matplotlib.pylab as plt
%matplotlib inline
plt.figure(figsize=(12, 12))
for i in range(16):
plt.subplot(4, 4, i + 1)
plt.imshow(b["video"][11, i, ...].permute(1, 2, 0))
plt.axis("off") |
Hi @vfdev-5
Since there is a warning there already, might as well. Added in subsequent commit.
Isn't it documented in the
done :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM ! Thanks @bjuncek
Failing Travis CI is unrelated.
Codecov Report
@@ Coverage Diff @@
## master #2821 +/- ##
==========================================
- Coverage 73.35% 72.27% -1.09%
==========================================
Files 99 99
Lines 8785 8785
Branches 1387 1387
==========================================
- Hits 6444 6349 -95
- Misses 1916 1998 +82
- Partials 425 438 +13
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR!
I have one blocking comment (the doc is now broken), otherwise the other comments are minor.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
* Modified the example to conform with the new DICT return. * adding better stream documentation to examples * Clearing up some documentation as a result of a feedback * Formatting mostly * Addressing Victor's comments. * addressing fmassas comments * remove unnecessary tab Co-authored-by: Bruno Korbar <[email protected]> Co-authored-by: vfdev <[email protected]>
* Modified the example to conform with the new DICT return. * adding better stream documentation to examples * Clearing up some documentation as a result of a feedback * Formatting mostly * Addressing Victor's comments. * addressing fmassas comments * remove unnecessary tab Co-authored-by: Bruno Korbar <[email protected]> Co-authored-by: vfdev <[email protected]>
There were still a few points where documentation should have been clarified, and
example notebook needed to change the return type. Should be cleared up now.