-
Notifications
You must be signed in to change notification settings - Fork 7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
install onnxruntime tests on linux wheel for circle_ci #1950
install onnxruntime tests on linux wheel for circle_ci #1950
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This generally looks good to me, thanks a lot @r-zenine!
I have one general comment: we currently don't run tests for wheels on CI, only on conda, so this PR wouldn't be enough to enable CI to use onnxruntime.
The current situation with testing in torchvision is a bit weird: we share the same scripts for building the binaries and for CI, but we only run a subset of those scripts in CI (namely, we only run conda tests for now).
This is something that I think should be improved / clarified (but is outside of the scope of this PR).
I'm ccing @seemethere for thoughts on how to best address this.
Hi @fmassa, I spent some time trying to use |
Subsumed by #3144 |
Hi,
This PR enable's
onnx
related tests forcircleci
for thelinux_wheel
pipelines. It is a first step at addressing this issue #1326Thanks