Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

install onnxruntime tests on linux wheel for circle_ci #1950

Closed

Conversation

r-zenine
Copy link
Contributor

@r-zenine r-zenine commented Mar 8, 2020

Hi,

This PR enable's onnx related tests for circleci for the linux_wheel pipelines. It is a first step at addressing this issue #1326

Thanks

Copy link
Member

@fmassa fmassa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This generally looks good to me, thanks a lot @r-zenine!

I have one general comment: we currently don't run tests for wheels on CI, only on conda, so this PR wouldn't be enough to enable CI to use onnxruntime.

The current situation with testing in torchvision is a bit weird: we share the same scripts for building the binaries and for CI, but we only run a subset of those scripts in CI (namely, we only run conda tests for now).

This is something that I think should be improved / clarified (but is outside of the scope of this PR).

I'm ccing @seemethere for thoughts on how to best address this.

packaging/pkg_helpers.bash Outdated Show resolved Hide resolved
@r-zenine
Copy link
Contributor Author

Hi @fmassa,

I spent some time trying to use pip inside the conda pipeline to install onnxruntime. I was hopping to find an elegant fix. But It does not look good so far.
We would need to run the test on wheel pipelines to have that.
What's preventing us from running tests on wheel pipelines ?

@fmassa
Copy link
Member

fmassa commented Feb 8, 2021

Subsumed by #3144

@fmassa fmassa closed this Feb 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants