Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move fakedata generation to separate module #1014

Merged
merged 1 commit into from
Jun 13, 2019

Conversation

pmeier
Copy link
Collaborator

@pmeier pmeier commented Jun 13, 2019

This moves the fakedata generation to aseparate module as discussed in #1010. I furthermore renamed get_mnist_data to mnist_root to match the style of CIFAR and ImageNet.

@codecov-io
Copy link

codecov-io commented Jun 13, 2019

Codecov Report

Merging #1014 into master will decrease coverage by 0.07%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1014      +/-   ##
==========================================
- Coverage   63.24%   63.17%   -0.08%     
==========================================
  Files          65       65              
  Lines        5148     5148              
  Branches      772      772              
==========================================
- Hits         3256     3252       -4     
- Misses       1669     1672       +3     
- Partials      223      224       +1
Impacted Files Coverage Δ
torchvision/transforms/functional.py 69.9% <0%> (-1.22%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 53d04ac...3b0abbe. Read the comment docs.

Copy link
Member

@fmassa fmassa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks a lot!

@fmassa fmassa merged commit f9348a0 into pytorch:master Jun 13, 2019
@pmeier pmeier deleted the refactor_dataset_test branch June 13, 2019 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants