-
Notifications
You must be signed in to change notification settings - Fork 7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pillow 5.1 is broken on OS X #516
Comments
@Robin-des-Bois if I understand correctly the problem is with Pillow on OSX, I mean that if you install another version with pip before installing torchvision it should work ? pip install Pillow!=5.1.0
pip install torchvision |
Exactly. As long as the current version of |
I see, maybe if maintainers are OK with what you propose as a change in setup.py and if it is working correctly you could send a PR : install_requires=['Pillow != 5.1.0 ; platform_system = "Darwin"'] however taking a look at the current setup.py:
you would need to adapt the condition with the current state |
Fix for pytorch#516
@Robin-des-Bois I think the issue with MacOSX is also related to the OSX version. I just tested on OSX 10.13.2 the following :
So, I can not reproduce the issue. Following the discussion from Pillow, they are almost done with 5.1.1 release I'm not very sure that we need to change the master now to temporary fix the problem with (let's say old) OSX version and then after their release remove it. What do you think ? |
sounds reasonable. especially since the fix as a user is so simple... |
I'm not sure there is any action that needs to be taken here from our end. |
@vfdev-5 I can reproduce with the exact same commands you posted. Is there a suggestion on how to fix it? Happy to provide more debugging info if needed as well.
|
@dharmeshkakadia That's a duplicate of #1712:
|
When installing
torch
andtorchvision
in a clean virtualenv withpython3.6
and the correspondingpip
onOS X
leads to
This is a known bug see Pillow Issue 3068
As a pytorch user it can be fixed by specifying the Pillow version in your
requirements.txt
The
setup.py
should get updated with something like:The text was updated successfully, but these errors were encountered: