Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Audio preprocessing tutorial. #572

Merged
merged 11 commits into from
Aug 8, 2019
Merged

Conversation

vincentqb
Copy link
Contributor

@vincentqb vincentqb commented Jul 23, 2019

Initial tutorial with an overview of dataset loading and transformers. Created using the following notebook and converted using this script.

TODO

  • Update as soon as the transformers have been standardized, see PR. For instance, we expect LC2CL to no longer be needed.
  • Confirm location to put tutorial
  • Confirm images are generated on the web

In a later iteration, we should demo a neural network implementation, maybe inspired by a prior version (which no longer appears in the left hand side menu but is still searchable).

The initial pull request was done in torchaudio.

@vincentqb vincentqb changed the title Audio preprocessing tutorial. [WIP] Audio preprocessing tutorial. Jul 23, 2019
@netlify
Copy link

netlify bot commented Jul 23, 2019

Deploy preview for pytorch-tutorials-preview ready!

Built with commit 3cb9b30

https://deploy-preview-572--pytorch-tutorials-preview.netlify.com

@vincentqb
Copy link
Contributor Author

vincentqb commented Jul 24, 2019

Discussion with @brianjo

@vincentqb
Copy link
Contributor Author

While testing with the mini-website, I'm running into failing nightlies from PyTorch.

@jamarshon -- do you know one that's compatible with torchaudio that works?

@brianjo
Copy link
Contributor

brianjo commented Jul 24, 2019

Just FYI, seeing similar issues with Torchvision against master. We're working on this branch #575. Once I get tv fixed, I'll enable audio. Cheers.

@jamarshon
Copy link

try 1.2.0.dev20190722 or a few days back. torchaudio CI passed on those ones

@vincentqb
Copy link
Contributor Author

vincentqb commented Jul 25, 2019

Test build of branch with tutorial in #578. Thanks @brianjo!

@vincentqb
Copy link
Contributor Author

I was able to successfully generate the page using the mini-website with the latest path using 1.2.0.dev20190725+cpu, sox from conda, and the current version of torchaudio.

@vincentqb
Copy link
Contributor Author

@brianjo -- do you know where the style sheet controlling the size of the images generated in the document? thanks!

@vincentqb vincentqb mentioned this pull request Jul 30, 2019
index.rst Outdated
.. .. raw:: html
.. customgalleryitem::
:figure: /_static/img/audio_preprocessing_tutorial_waveform.png
:tooltip: Preprocessing with Torchaudio Tutorial

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

torchaudio

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bump

@vincentqb
Copy link
Contributor Author

Thanks for the feedback! Updated to torchaudio, AmplitudeToDB, and Decoding.

print("Sample rate of waveform: {}".format(sample_rate))

plt.figure()
plt.plot(waveform.transpose(0,1).numpy())

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.t() seems cleaner than transpose(0,1)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed. I updated it in other places too.

@brianjo brianjo merged commit 65ce8a1 into pytorch:master Aug 8, 2019
@vincentqb vincentqb mentioned this pull request Dec 20, 2019
10 tasks
rodrigo-techera pushed a commit to Experience-Monks/tutorials that referenced this pull request Nov 29, 2021
[WIP] Audio preprocessing tutorial. Yay!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants