Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

torchvision tutorial: update deprecated pretrained=True #1998

Merged
merged 1 commit into from
Aug 10, 2022
Merged

torchvision tutorial: update deprecated pretrained=True #1998

merged 1 commit into from
Aug 10, 2022

Conversation

YoniChechik
Copy link
Contributor

@YoniChechik YoniChechik commented Aug 10, 2022

update deprecated pretrained=True to weights="DEFAULT"

@facebook-github-bot
Copy link
Contributor

Hi @YoniChechik!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

@YoniChechik YoniChechik changed the title torchvision tutorial: update deprecated pretrained=True to `weights… torchvision tutorial: update deprecated pretrained=True Aug 10, 2022
@netlify
Copy link

netlify bot commented Aug 10, 2022

Deploy Preview for pytorch-tutorials-preview ready!

Name Link
🔨 Latest commit 57cc84c
🔍 Latest deploy log https://app.netlify.com/sites/pytorch-tutorials-preview/deploys/62f39b33379092000860c170
😎 Deploy Preview https://deploy-preview-1998--pytorch-tutorials-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@svekars
Copy link
Contributor

svekars commented Aug 10, 2022

@datumbox can you please take a look.

@datumbox
Copy link
Contributor

datumbox commented Aug 10, 2022

The changes look great. On a follow up PR, it's worth fetching the inference transforms from the weights. See this example.

@svekars svekars self-requested a review August 10, 2022 17:10
@svekars svekars merged commit 770665f into pytorch:master Aug 10, 2022
@YoniChechik YoniChechik deleted the patch-1 branch August 11, 2022 05:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants