Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dist.accelerate component #838

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

dist.accelerate component #838

wants to merge 1 commit into from

Conversation

d4l3k
Copy link
Member

@d4l3k d4l3k commented Mar 1, 2024

This is a component that uses HuggingFace's accelerate in a similar manner to torchrun. I haven't tested with a accelerate config.

Fixes #834

Test plan:

pytest torchx/components/test/dist_test.py
scripts/component_integration_tests.py --scheduler local_cwd
torchx run -s local_cwd dist.accelerate -j2x2 --script torchx/examples/apps/compute_world_size/main.py

@d4l3k d4l3k requested a review from kiukchung March 1, 2024 00:52
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Mar 1, 2024
@d4l3k d4l3k marked this pull request as ready for review March 1, 2024 00:52
@d4l3k d4l3k requested a review from manav-a March 1, 2024 00:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kiukchung kiukchung Awaiting requested review from kiukchung

@manav-a manav-a Awaiting requested review from manav-a

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

HuggingFace accelerate component
2 participants
@d4l3k @facebook-github-bot