-
Notifications
You must be signed in to change notification settings - Fork 440
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Custom recipes use slash path #1760
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/torchtune/1760
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit a059a29 with merge base a8a64ec (): This comment was automatically generated by Dr. CI and updates every 15 minutes. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1760 +/- ##
==========================================
- Coverage 69.33% 67.33% -2.00%
==========================================
Files 305 305
Lines 15892 15964 +72
==========================================
- Hits 11018 10750 -268
- Misses 4874 5214 +340 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks Rafi for the fix. Does this also work with customized configs inside torchtune repo?
can't run any custom recipes from instead the recipes directory because of |
Wait, so will it still work if the user adds their recipe to the registry? |
Context
What is the purpose of this PR? Is it to
Custom imports/recipes were fixed by running as modules, but this required users to specify custom recipes as dotpaths, i.e.,
tune run path.to.my.recipe
which isn't consistent (as discussed in #1759). We do the conversion under the hood for them here so they can still specify standard file paths with slashes.Test plan
both of these now run, and they rely on custom dataset builders located outside of torchtune repo:
tune run --nproc_per_node 8 recipe/sft --config config/sft_llama3_2_1B.yaml
tune run --nproc_per_node 8 recipe/sft.py --config config/sft_llama3_2_1B.yaml