Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove duplicate code in generate + fix generate.py prompt for llama2 #590

Merged
merged 3 commits into from
May 1, 2024

Conversation

metascroy
Copy link
Contributor

See #574

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Meta Open Source bot. label Apr 30, 2024
Copy link
Contributor

@swolchok swolchok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please format

Copy link
Contributor

@JacobSzwejbka JacobSzwejbka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please make sure chat and generate are working as expected

@metascroy metascroy changed the title remove duplicate code in generate remove duplicate code in generate + fix generate.py prompt for llama2 Apr 30, 2024
@metascroy metascroy merged commit 6a2b983 into main May 1, 2024
32 checks passed
malfet pushed a commit that referenced this pull request Jul 17, 2024
…#590)

* remove duplicate code in generate

* fix indent

* add fixes
malfet pushed a commit that referenced this pull request Jul 17, 2024
…#590)

* remove duplicate code in generate

* fix indent

* add fixes
malfet pushed a commit that referenced this pull request Jul 17, 2024
…#590)

* remove duplicate code in generate

* fix indent

* add fixes
malfet pushed a commit that referenced this pull request Jul 17, 2024
…#590)

* remove duplicate code in generate

* fix indent

* add fixes
malfet pushed a commit that referenced this pull request Jul 17, 2024
…#590)

* remove duplicate code in generate

* fix indent

* add fixes
malfet pushed a commit that referenced this pull request Jul 17, 2024
…#590)

* remove duplicate code in generate

* fix indent

* add fixes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Meta Open Source bot.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants