Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update cli.py with inline comments #228

Merged
merged 1 commit into from
Apr 16, 2024
Merged

Update cli.py with inline comments #228

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions cli.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,18 +41,24 @@ def check_args(args, command_name: str):


def add_arguments_for_generate(parser):
# Only generate specific options should be here
_add_arguments_common(parser)


def add_arguments_for_eval(parser):
# Only eval specific options should be here
_add_arguments_common(parser)


def add_arguments_for_export(parser):
# Only export specific options should be here
_add_arguments_common(parser)


def _add_arguments_common(parser):
# TODO: Refactor this so that only common options are here
# and subcommand-specific options are inside individual
# add_arguments_for_generate, add_arguments_for_export etc.
parser.add_argument(
"--seed",
type=int,
Expand Down
Loading