Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump PT pin to 20241028 #1419

Merged
merged 2 commits into from
Dec 12, 2024
Merged

Bump PT pin to 20241028 #1419

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
aee32cd
Bump PT pin to 20241014
Jack-Khuu Dec 11, 2024
63aeb5e
Push bump to 1028 and add migration to export_for_training
Jack-Khuu Dec 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions install/install_requirements.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,10 +62,10 @@ echo "Using pip executable: $PIP_EXECUTABLE"
# NOTE: If a newly-fetched version of the executorch repo changes the value of
# PYTORCH_NIGHTLY_VERSION, you should re-run this script to install the necessary
# package versions.
PYTORCH_NIGHTLY_VERSION=dev20241013
PYTORCH_NIGHTLY_VERSION=dev20241028

# Nightly version for torchvision
VISION_NIGHTLY_VERSION=dev20241013
VISION_NIGHTLY_VERSION=dev20241028

# Nightly version for torchtune
TUNE_NIGHTLY_VERSION=dev20241013
Expand Down
4 changes: 2 additions & 2 deletions torchchat/export.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,7 +122,7 @@ def export_for_server(
from executorch.exir.tracer import Value

from torch._export import capture_pre_autograd_graph
from torch.export import export, ExportedProgram
from torch.export import export, export_for_training, ExportedProgram

from torchchat.model import apply_rotary_emb, Attention
from torchchat.utils.build_utils import get_precision
Expand Down Expand Up @@ -238,7 +238,7 @@ def _to_core_aten(
raise ValueError(
f"Expected passed in model to be an instance of fx.GraphModule, got {type(model)}"
)
core_aten_ep = export(model, example_inputs, dynamic_shapes=dynamic_shapes)
core_aten_ep = export_for_training(model, example_inputs, dynamic_shapes=dynamic_shapes)
if verbose:
logging.info(f"Core ATen graph:\n{core_aten_ep.graph}")
return core_aten_ep
Expand Down
Loading