-
Notifications
You must be signed in to change notification settings - Fork 226
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove last references to use_distributed argument #1353
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/torchchat/1353
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 52b57ed with merge base 2fcc37c (): This comment was automatically generated by Dr. CI and updates every 15 minutes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Thanks for cleaning this up!
Test failure seems unrelated: |
Yes, current main is also failing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@Jack-Khuu any thoughts on the test failure as its not PR related? Or can you by-pass it to merge? I think @byjlw did that for #1354 which failed with the same error but was merged. |
I'll take a look this weekend, seems like there's an upstream GH CI bug. PR lgtm though |
This PR removes the last references to the use_distributed argument which got replaced by --distributed