Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error: characters can not be displayed normally in chinese #1342

Merged
merged 2 commits into from
Nov 7, 2024

Conversation

wjunLu
Copy link
Contributor

@wjunLu wjunLu commented Nov 5, 2024

Some Chinese characters require more than two or three tokens to decode, tokens will be decoded immediately, rather than wait for two or three tokens.

Current output:
image

Fixed output:
image

Copy link

pytorch-bot bot commented Nov 5, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/torchchat/1342

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 3b52e0e with merge base 4a7dab8 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot
Copy link

Hi @wjunLu!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

@Jack-Khuu Jack-Khuu requested review from vmpuri and Jack-Khuu and removed request for vmpuri November 5, 2024 21:17
@Jack-Khuu Jack-Khuu added bug Something isn't working Browser Issue Related to UI components and behavior labels Nov 5, 2024
@Jack-Khuu
Copy link
Contributor

Thanks for the fix @wjunLu, just kicked off the CI

@Jack-Khuu
Copy link
Contributor

@wjunLu PR lgtm, can you take a look at setting up your CLA? (Allows you to contribute to Facebook/Meta repos)

@wjunLu
Copy link
Contributor Author

wjunLu commented Nov 7, 2024

@wjunLu PR lgtm, can you take a look at setting up your CLA? (Allows you to contribute to Facebook/Meta repos)

I have signed CLA, how to re-check CLA?

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Meta Open Source bot. label Nov 7, 2024
@Jack-Khuu
Copy link
Contributor

Jack-Khuu commented Nov 7, 2024

Just kicked off the CI again, once its good I'll merge

Thanks again!

@Jack-Khuu Jack-Khuu merged commit 743e6f3 into pytorch:main Nov 7, 2024
52 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Browser Issue Related to UI components and behavior bug Something isn't working CLA Signed This label is managed by the Meta Open Source bot.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants