-
Notifications
You must be signed in to change notification settings - Fork 226
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix error: characters can not be displayed normally in chinese #1342
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/torchchat/1342
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 3b52e0e with merge base 4a7dab8 (): This comment was automatically generated by Dr. CI and updates every 15 minutes. |
Hi @wjunLu! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at [email protected]. Thanks! |
Thanks for the fix @wjunLu, just kicked off the CI |
@wjunLu PR lgtm, can you take a look at setting up your CLA? (Allows you to contribute to Facebook/Meta repos) |
I have signed CLA, how to re-check CLA? |
Just kicked off the CI again, once its good I'll merge Thanks again! |
Some Chinese characters require more than two or three tokens to decode, tokens will be decoded immediately, rather than wait for two or three tokens.
Current output:
Fixed output: