[CF] Convert lf_rollover_health query to clickhouse #5819
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
facebook-github-bot
added
the
CLA Signed
| WHERE 1=1 | ||
| AND j.labels is not NULL | ||
| AND j._event_time > CURRENT_DATETIME() - DAYS(:days_ago) | ||
| workflow_job as j |
There was a problem hiding this comment.
Based on offline conversation, if you are willing to eat the cost of not using final (maybe some incorrect rows, dup rows, esp for recent data), then you don't need final. A comment about not needing it would be nice tho
There was a problem hiding this comment.
As discussed offline, we'll leave this query without FINAL. Added comments to the query explaining the logic
| granularity={"day"} | ||
| timeFieldName={"bucket"} | ||
| yAxisLabel="increase ratio" | ||
| yAxisFieldName={"success_duration_increase_ratio"} | ||
| yAxisRenderer={(value) => value} | ||
| groupByFieldName={"job_name"} | ||
| useClickHouse={useClickHouse} |
There was a problem hiding this comment.
I just realized these 3 panels use the same values, is it worth it to query once initially and reuse the values? Or maybe the caching is good enough to handle it
There was a problem hiding this comment.
There's some smarts that are already there under the hood, perhaps automated by React. If you look at the network requests only one request is actually made to the query, and it populates all three charts simultaneously
Converts the lf_rollover_health query to use clickhouse.
It also:
Validation: