[CH] Migrate failure annotation page #5803
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@huydhn is attempting to deploy a commit to the Meta Open Source Team on Vercel. A member of the Team first needs to authorize it. |
facebook-github-bot
added
the
CLA Signed
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
clee2000
approved these changes
Oct 23, 2024
Yeah, that's that I'm thinking too. But let merge this, then reap the page later. Maybe we can do a BE task to prune other unused pages too.
Good catch, I need to remove that part. I was debugging why there are duplications on the page, so I try to group them by sha to make sure they are unique. But that bug has been fixed, so that grouping is not needed anymore. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is more like a refactoring, not a migration, but it's needed to make the query works.
failed_workflow_jobsruns OOM on ClickHouse trying to load all failed jobs from commits that are having more than N failures. I rewrite the logic to get rid of N because we only set it to 0 anyway. The simplified logic can be then be runtorchci/components/JobAnnotationToggle.tsxthat took me way too long to figure out.Testing
https://torchci-git-fork-huydhn-ch-migrate-job-anno-45acb4-fbopensource.vercel.app/failedjobs/pytorch/pytorch/main