-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable non-org autoscaler to read scale-config from any repo #5767
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
terraform-aws-github-runner/modules/runners/lambdas/runners/src/scale-runners/scale-up.ts
Outdated
Show resolved
Hide resolved
terraform-aws-github-runner/modules/runners/lambdas/runners/src/scale-runners/scale-up.ts
Outdated
Show resolved
Hide resolved
Overall I do like the approach :) |
I like that this will make things cleaner. For LF Canary though, maybe I missed it but we'll still need a duplicate scale-config though right? Since scale-config for canary adds a |
Okay I just saw the related ci-infra PR and confirmed that yes we do still have a separate canary config. |
Removing just the LF canary scale config for now to test the changes in pytorch/test-infra#5767 Those changes have been deployed to prod and appear to be working, but this will be the final proof that it is in fact reading the test-config version of scale-config and not the pytorch/pytorch copy. Note: This will break the Scale config validation workflow on test-infra, but it's worth it since this test will be very short lived and that workflow only runs when someone modifies scale config Pull Request resolved: #138361 Approved by: https://github.com/wdvr
Part of the workflow to move the LF scale-config.yml files from pytorch/pytorch to test-infra (details in #5767) This updates the validation script to no longer expect to update the pytorch/pytorch version of these scale configs. It resulted in many other aspects of that file becoming simpler as well.
Final step of moving scale config files to test-infra repo. Details in pytorch/test-infra#5767 Scale configs are now read from test-infra. This PR is just cleaning up stale files Pull Request resolved: #138511 Approved by: https://github.com/clee2000
Final step of moving scale config files to test-infra repo. Details in pytorch/test-infra#5767 Scale configs are now read from test-infra. This PR is just cleaning up stale files Pull Request resolved: #138511 Approved by: https://github.com/clee2000
Enable putting scale-config in test-infra, even for non-organization runners. Before, only scale-configs for organization-scoped runners could be put in arbitrary repos
Significant change:
scale_config_repo
no longer defaults to test-infra. You now have to specify a value if you're using org runners. Non-org runners will default to the job's repo. pytorch-gha-infra and ci-infra will need to be updated accordingly.Testing: Deployed these changes to LF canary, terminated all lf-c instances, and verified that creating a new pull request there would still result in instances getting provisioned