Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BugFix] Fix ellipsis check #604

Merged
merged 1 commit into from
Jan 3, 2024
Merged

[BugFix] Fix ellipsis check #604

merged 1 commit into from
Jan 3, 2024

Conversation

vmoens
Copy link
Contributor

@vmoens vmoens commented Jan 3, 2024

No description provided.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jan 3, 2024
@vmoens vmoens added bug Something isn't working and removed CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. labels Jan 3, 2024
@vmoens vmoens merged commit 1b6b30c into main Jan 3, 2024
11 of 19 checks passed
@vmoens vmoens deleted the fix-ellipsis-check branch January 3, 2024 09:49
Copy link

github-actions bot commented Jan 3, 2024

$\color{#D29922}\textsf{\Large⚠\kern{0.2cm}\normalsize Warning}$ Result of CPU Benchmark Tests

Total Benchmarks: 120. Improved: $\large\color{#35bf28}5$. Worsened: $\large\color{#d91a1a}12$.

Expand to view detailed results
Name Max Mean Ops Ops on Repo HEAD Change
test_plain_set_nested 0.1568ms 17.9076μs 55.8422 KOps/s 59.9351 KOps/s $\textbf{\color{#d91a1a}-6.83\%}$
test_plain_set_stack_nested 0.2626ms 0.1437ms 6.9583 KOps/s 7.0827 KOps/s $\color{#d91a1a}-1.76\%$
test_plain_set_nested_inplace 57.2670μs 19.5709μs 51.0962 KOps/s 53.4553 KOps/s $\color{#d91a1a}-4.41\%$
test_plain_set_stack_nested_inplace 0.2475ms 0.1764ms 5.6682 KOps/s 5.6978 KOps/s $\color{#d91a1a}-0.52\%$
test_items 19.4160μs 2.3985μs 416.9349 KOps/s 414.4261 KOps/s $\color{#35bf28}+0.61\%$
test_items_nested 0.3180ms 0.2692ms 3.7149 KOps/s 3.7819 KOps/s $\color{#d91a1a}-1.77\%$
test_items_nested_locked 0.9170ms 0.2748ms 3.6388 KOps/s 3.7597 KOps/s $\color{#d91a1a}-3.21\%$
test_items_nested_leaf 0.3206ms 0.1657ms 6.0352 KOps/s 6.1021 KOps/s $\color{#d91a1a}-1.10\%$
test_items_stack_nested 2.9882ms 1.5475ms 646.1985 Ops/s 652.8365 Ops/s $\color{#d91a1a}-1.02\%$
test_items_stack_nested_leaf 2.1525ms 1.3934ms 717.6555 Ops/s 716.5949 Ops/s $\color{#35bf28}+0.15\%$
test_items_stack_nested_locked 0.8671ms 0.7570ms 1.3210 KOps/s 1.2890 KOps/s $\color{#35bf28}+2.48\%$
test_keys 22.3520μs 3.8748μs 258.0791 KOps/s 258.6460 KOps/s $\color{#d91a1a}-0.22\%$
test_keys_nested 50.4404ms 0.1564ms 6.3957 KOps/s 6.7812 KOps/s $\textbf{\color{#d91a1a}-5.69\%}$
test_keys_nested_locked 0.2596ms 0.1484ms 6.7397 KOps/s 6.8602 KOps/s $\color{#d91a1a}-1.76\%$
test_keys_nested_leaf 0.2472ms 0.1302ms 7.6819 KOps/s 7.7616 KOps/s $\color{#d91a1a}-1.03\%$
test_keys_stack_nested 2.2071ms 1.5104ms 662.0788 Ops/s 669.1335 Ops/s $\color{#d91a1a}-1.05\%$
test_keys_stack_nested_leaf 2.2609ms 1.4973ms 667.8876 Ops/s 668.3500 Ops/s $\color{#d91a1a}-0.07\%$
test_keys_stack_nested_locked 0.7804ms 0.6922ms 1.4447 KOps/s 1.4373 KOps/s $\color{#35bf28}+0.52\%$
test_values 8.9518μs 1.1467μs 872.0939 KOps/s 867.2403 KOps/s $\color{#35bf28}+0.56\%$
test_values_nested 88.3150μs 51.4663μs 19.4302 KOps/s 19.4320 KOps/s $-0.01\%$
test_values_nested_locked 86.3810μs 51.6722μs 19.3528 KOps/s 19.2327 KOps/s $\color{#35bf28}+0.62\%$
test_values_nested_leaf 96.3800μs 46.0051μs 21.7367 KOps/s 21.7423 KOps/s $\color{#d91a1a}-0.03\%$
test_values_stack_nested 1.3566ms 1.2608ms 793.1715 Ops/s 796.3598 Ops/s $\color{#d91a1a}-0.40\%$
test_values_stack_nested_leaf 1.9409ms 1.2489ms 800.7357 Ops/s 807.8596 Ops/s $\color{#d91a1a}-0.88\%$
test_values_stack_nested_locked 0.7682ms 0.5058ms 1.9772 KOps/s 1.9437 KOps/s $\color{#35bf28}+1.73\%$
test_membership 61.7660μs 1.5162μs 659.5506 KOps/s 745.2345 KOps/s $\textbf{\color{#d91a1a}-11.50\%}$
test_membership_nested 23.1830μs 2.8896μs 346.0683 KOps/s 347.8642 KOps/s $\color{#d91a1a}-0.52\%$
test_membership_nested_leaf 26.8200μs 2.9097μs 343.6752 KOps/s 334.3342 KOps/s $\color{#35bf28}+2.79\%$
test_membership_stacked_nested 35.3960μs 11.7269μs 85.2741 KOps/s 85.9038 KOps/s $\color{#d91a1a}-0.73\%$
test_membership_stacked_nested_leaf 29.2650μs 11.7409μs 85.1724 KOps/s 84.3940 KOps/s $\color{#35bf28}+0.92\%$
test_membership_nested_last 29.2340μs 5.9483μs 168.1156 KOps/s 167.1140 KOps/s $\color{#35bf28}+0.60\%$
test_membership_nested_leaf_last 28.7440μs 5.9303μs 168.6265 KOps/s 166.6164 KOps/s $\color{#35bf28}+1.21\%$
test_membership_stacked_nested_last 0.2370ms 0.1650ms 6.0610 KOps/s 5.9739 KOps/s $\color{#35bf28}+1.46\%$
test_membership_stacked_nested_leaf_last 60.8740μs 13.8740μs 72.0774 KOps/s 72.1374 KOps/s $\color{#d91a1a}-0.08\%$
test_nested_getleaf 31.5290μs 10.5552μs 94.7399 KOps/s 93.3953 KOps/s $\color{#35bf28}+1.44\%$
test_nested_get 49.0110μs 9.9309μs 100.6963 KOps/s 98.5655 KOps/s $\color{#35bf28}+2.16\%$
test_stacked_getleaf 0.8262ms 0.6740ms 1.4837 KOps/s 1.4151 KOps/s $\color{#35bf28}+4.85\%$
test_stacked_get 0.7218ms 0.6402ms 1.5621 KOps/s 1.5457 KOps/s $\color{#35bf28}+1.06\%$
test_nested_getitemleaf 37.8210μs 10.6310μs 94.0645 KOps/s 92.3725 KOps/s $\color{#35bf28}+1.83\%$
test_nested_getitem 30.7770μs 10.1661μs 98.3658 KOps/s 98.2135 KOps/s $\color{#35bf28}+0.16\%$
test_stacked_getitemleaf 0.7777ms 0.6786ms 1.4736 KOps/s 1.4844 KOps/s $\color{#d91a1a}-0.73\%$
test_stacked_getitem 0.7510ms 0.6462ms 1.5476 KOps/s 1.5573 KOps/s $\color{#d91a1a}-0.62\%$
test_lock_nested 1.3225ms 0.4103ms 2.4371 KOps/s 2.3794 KOps/s $\color{#35bf28}+2.43\%$
test_lock_stack_nested 80.9049ms 6.5715ms 152.1732 Ops/s 147.9640 Ops/s $\color{#35bf28}+2.84\%$
test_unlock_nested 72.8834ms 0.4878ms 2.0501 KOps/s 2.3373 KOps/s $\textbf{\color{#d91a1a}-12.29\%}$
test_unlock_stack_nested 79.9451ms 6.2177ms 160.8304 Ops/s 156.4173 Ops/s $\color{#35bf28}+2.82\%$
test_flatten_speed 0.5855ms 0.3725ms 2.6843 KOps/s 2.6534 KOps/s $\color{#35bf28}+1.16\%$
test_unflatten_speed 0.7531ms 0.4570ms 2.1881 KOps/s 2.2105 KOps/s $\color{#d91a1a}-1.01\%$
test_common_ops 3.9628ms 0.7158ms 1.3970 KOps/s 1.4398 KOps/s $\color{#d91a1a}-2.97\%$
test_creation 63.8800μs 1.9918μs 502.0487 KOps/s 511.8177 KOps/s $\color{#d91a1a}-1.91\%$
test_creation_empty 28.2630μs 11.2278μs 89.0649 KOps/s 101.2332 KOps/s $\textbf{\color{#d91a1a}-12.02\%}$
test_creation_nested_1 62.4170μs 14.1345μs 70.7487 KOps/s 77.8962 KOps/s $\textbf{\color{#d91a1a}-9.18\%}$
test_creation_nested_2 41.3570μs 19.2233μs 52.0202 KOps/s 56.1498 KOps/s $\textbf{\color{#d91a1a}-7.35\%}$
test_clone 0.1275ms 12.3462μs 80.9966 KOps/s 80.9553 KOps/s $\color{#35bf28}+0.05\%$
test_getitem[int] 50.4940μs 11.8568μs 84.3401 KOps/s 81.1356 KOps/s $\color{#35bf28}+3.95\%$
test_getitem[slice_int] 75.2900μs 24.0787μs 41.5305 KOps/s 40.9193 KOps/s $\color{#35bf28}+1.49\%$
test_getitem[range] 89.0570μs 43.9132μs 22.7722 KOps/s 22.8602 KOps/s $\color{#d91a1a}-0.38\%$
test_getitem[tuple] 47.5990μs 19.4609μs 51.3851 KOps/s 51.5455 KOps/s $\color{#d91a1a}-0.31\%$
test_getitem[list] 3.1811ms 40.3655μs 24.7736 KOps/s 25.7829 KOps/s $\color{#d91a1a}-3.91\%$
test_setitem_dim[int] 47.5890μs 31.3764μs 31.8711 KOps/s 31.8009 KOps/s $\color{#35bf28}+0.22\%$
test_setitem_dim[slice_int] 99.0350μs 56.6865μs 17.6409 KOps/s 17.8836 KOps/s $\color{#d91a1a}-1.36\%$
test_setitem_dim[range] 0.1048ms 76.0981μs 13.1409 KOps/s 13.0556 KOps/s $\color{#35bf28}+0.65\%$
test_setitem_dim[tuple] 78.2760μs 45.7035μs 21.8802 KOps/s 22.6034 KOps/s $\color{#d91a1a}-3.20\%$
test_setitem 0.1948ms 19.2429μs 51.9673 KOps/s 53.6121 KOps/s $\color{#d91a1a}-3.07\%$
test_set 0.1514ms 18.7850μs 53.2339 KOps/s 55.9134 KOps/s $\color{#d91a1a}-4.79\%$
test_set_shared 5.4090ms 0.1383ms 7.2299 KOps/s 7.1359 KOps/s $\color{#35bf28}+1.32\%$
test_update 0.1959ms 22.2824μs 44.8785 KOps/s 48.5639 KOps/s $\textbf{\color{#d91a1a}-7.59\%}$
test_update_nested 0.1449ms 29.8057μs 33.5507 KOps/s 36.3889 KOps/s $\textbf{\color{#d91a1a}-7.80\%}$
test_set_nested 0.2479ms 20.2615μs 49.3546 KOps/s 51.6350 KOps/s $\color{#d91a1a}-4.42\%$
test_set_nested_new 0.1477ms 24.6948μs 40.4943 KOps/s 42.5619 KOps/s $\color{#d91a1a}-4.86\%$
test_select 0.1549ms 49.0922μs 20.3698 KOps/s 19.8094 KOps/s $\color{#35bf28}+2.83\%$
test_unbind_speed 0.4057ms 0.3351ms 2.9841 KOps/s 2.9077 KOps/s $\color{#35bf28}+2.63\%$
test_unbind_speed_stack0 71.7789ms 4.4438ms 225.0321 Ops/s 211.2191 Ops/s $\textbf{\color{#35bf28}+6.54\%}$
test_unbind_speed_stack1 2.2327μs 0.6218μs 1.6083 MOps/s 1.6017 MOps/s $\color{#35bf28}+0.41\%$
test_split 65.6251ms 1.6618ms 601.7471 Ops/s 643.8948 Ops/s $\textbf{\color{#d91a1a}-6.55\%}$
test_chunk 63.5444ms 1.6294ms 613.7412 Ops/s 600.9393 Ops/s $\color{#35bf28}+2.13\%$
test_creation[device0] 3.9204ms 0.2998ms 3.3352 KOps/s 3.3479 KOps/s $\color{#d91a1a}-0.38\%$
test_creation_from_tensor 4.4833ms 0.3326ms 3.0069 KOps/s 3.0028 KOps/s $\color{#35bf28}+0.14\%$
test_add_one[memmap_tensor0] 90.4080μs 25.2335μs 39.6299 KOps/s 38.2504 KOps/s $\color{#35bf28}+3.61\%$
test_contiguous[memmap_tensor0] 25.7980μs 5.7802μs 173.0035 KOps/s 164.9111 KOps/s $\color{#35bf28}+4.91\%$
test_stack[memmap_tensor0] 0.1022ms 19.8912μs 50.2736 KOps/s 48.9698 KOps/s $\color{#35bf28}+2.66\%$
test_memmaptd_index 0.3668ms 0.1985ms 5.0390 KOps/s 4.8883 KOps/s $\color{#35bf28}+3.08\%$
test_memmaptd_index_astensor 0.3478ms 0.2590ms 3.8613 KOps/s 3.7899 KOps/s $\color{#35bf28}+1.88\%$
test_memmaptd_index_op 1.3491ms 0.5580ms 1.7921 KOps/s 1.8083 KOps/s $\color{#d91a1a}-0.90\%$
test_serialize_model 0.1770s 0.1064s 9.3950 Ops/s 9.5702 Ops/s $\color{#d91a1a}-1.83\%$
test_serialize_model_filesystem 0.1639s 98.5865ms 10.1434 Ops/s 10.3916 Ops/s $\color{#d91a1a}-2.39\%$
test_serialize_model_pickle 0.4645s 0.3802s 2.6299 Ops/s 2.6199 Ops/s $\color{#35bf28}+0.38\%$
test_serialize_weights 0.1750s 0.1071s 9.3365 Ops/s 9.1771 Ops/s $\color{#35bf28}+1.74\%$
test_serialize_weights_filesystem 94.6905ms 90.5856ms 11.0393 Ops/s 10.1580 Ops/s $\textbf{\color{#35bf28}+8.68\%}$
test_serialize_weights_returnearly 0.1320s 0.1226s 8.1595 Ops/s 7.6823 Ops/s $\textbf{\color{#35bf28}+6.21\%}$
test_serialize_weights_pickle 0.8034s 0.5273s 1.8965 Ops/s 2.1323 Ops/s $\textbf{\color{#d91a1a}-11.06\%}$
test_reshape_pytree 66.3240μs 23.4425μs 42.6575 KOps/s 42.7886 KOps/s $\color{#d91a1a}-0.31\%$
test_reshape_td 74.3690μs 30.9143μs 32.3475 KOps/s 33.7300 KOps/s $\color{#d91a1a}-4.10\%$
test_view_pytree 78.4760μs 23.3176μs 42.8860 KOps/s 43.0742 KOps/s $\color{#d91a1a}-0.44\%$
test_view_td 22.5530μs 4.9532μs 201.8899 KOps/s 204.9304 KOps/s $\color{#d91a1a}-1.48\%$
test_unbind_pytree 67.8070μs 26.6593μs 37.5104 KOps/s 37.7182 KOps/s $\color{#d91a1a}-0.55\%$
test_unbind_td 0.1092ms 55.0187μs 18.1757 KOps/s 18.3713 KOps/s $\color{#d91a1a}-1.06\%$
test_split_pytree 73.6680μs 27.0290μs 36.9973 KOps/s 33.6194 KOps/s $\textbf{\color{#35bf28}+10.05\%}$
test_split_td 0.6276ms 43.1691μs 23.1647 KOps/s 22.4056 KOps/s $\color{#35bf28}+3.39\%$
test_add_pytree 96.6100μs 32.3953μs 30.8687 KOps/s 30.5058 KOps/s $\color{#35bf28}+1.19\%$
test_add_td 87.8940μs 49.7467μs 20.1018 KOps/s 20.6735 KOps/s $\color{#d91a1a}-2.77\%$
test_distributed 27.6820μs 6.1113μs 163.6317 KOps/s 167.5405 KOps/s $\color{#d91a1a}-2.33\%$
test_tdmodule 0.2925ms 23.0155μs 43.4490 KOps/s 43.9621 KOps/s $\color{#d91a1a}-1.17\%$
test_tdmodule_dispatch 0.2092ms 41.7716μs 23.9397 KOps/s 24.2784 KOps/s $\color{#d91a1a}-1.40\%$
test_tdseq 55.1130μs 26.3100μs 38.0083 KOps/s 39.2072 KOps/s $\color{#d91a1a}-3.06\%$
test_tdseq_dispatch 0.1397ms 46.9350μs 21.3060 KOps/s 21.3579 KOps/s $\color{#d91a1a}-0.24\%$
test_instantiation_functorch 1.9024ms 1.2903ms 775.0268 Ops/s 777.9702 Ops/s $\color{#d91a1a}-0.38\%$
test_instantiation_td 1.7175ms 0.9945ms 1.0056 KOps/s 923.6549 Ops/s $\textbf{\color{#35bf28}+8.87\%}$
test_exec_functorch 0.2403ms 0.1554ms 6.4350 KOps/s 6.3383 KOps/s $\color{#35bf28}+1.53\%$
test_exec_functional_call 0.2313ms 0.1423ms 7.0260 KOps/s 6.9157 KOps/s $\color{#35bf28}+1.59\%$
test_exec_td 0.2296ms 0.1418ms 7.0508 KOps/s 7.0018 KOps/s $\color{#35bf28}+0.70\%$
test_exec_td_decorator 87.7211ms 0.1972ms 5.0699 KOps/s 5.7511 KOps/s $\textbf{\color{#d91a1a}-11.85\%}$
test_vmap_mlp_speed[True-True] 2.4881ms 0.9410ms 1.0627 KOps/s 1.0687 KOps/s $\color{#d91a1a}-0.57\%$
test_vmap_mlp_speed[True-False] 0.5815ms 0.4643ms 2.1538 KOps/s 2.0752 KOps/s $\color{#35bf28}+3.79\%$
test_vmap_mlp_speed[False-True] 1.6262ms 0.8537ms 1.1713 KOps/s 1.2236 KOps/s $\color{#d91a1a}-4.27\%$
test_vmap_mlp_speed[False-False] 0.7837ms 0.4083ms 2.4491 KOps/s 2.5425 KOps/s $\color{#d91a1a}-3.67\%$
test_vmap_mlp_speed_decorator[True-True] 3.4075ms 1.8793ms 532.1001 Ops/s 530.1472 Ops/s $\color{#35bf28}+0.37\%$
test_vmap_mlp_speed_decorator[True-False] 0.8711ms 0.5097ms 1.9620 KOps/s 1.9016 KOps/s $\color{#35bf28}+3.17\%$
test_vmap_mlp_speed_decorator[False-True] 2.0815ms 1.5578ms 641.9119 Ops/s 637.7420 Ops/s $\color{#35bf28}+0.65\%$
test_vmap_mlp_speed_decorator[False-False] 0.9981ms 0.3930ms 2.5448 KOps/s 2.5005 KOps/s $\color{#35bf28}+1.77\%$

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants