Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BugFix] Fix opt deps #464

Merged
merged 2 commits into from
Jun 24, 2023
Merged

[BugFix] Fix opt deps #464

merged 2 commits into from
Jun 24, 2023

Conversation

vmoens
Copy link
Contributor

@vmoens vmoens commented Jun 23, 2023

No description provided.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jun 23, 2023
@github-actions
Copy link

github-actions bot commented Jun 23, 2023

$\color{#D29922}\textsf{\Large⚠\kern{0.2cm}\normalsize Warning}$ Result of CPU Benchmark Tests

Total Benchmarks: 100. Improved: $\large\color{#35bf28}7$. Worsened: $\large\color{#d91a1a}23$.

Expand to view detailed results
Name Max Mean Ops Ops on Repo HEAD Change
test_plain_set_nested 62.5010μs 26.4836μs 37.7592 KOps/s 43.9496 KOps/s $\textbf{\color{#d91a1a}-14.09\%}$
test_plain_set_stack_nested 0.3827ms 0.3180ms 3.1451 KOps/s 3.4667 KOps/s $\textbf{\color{#d91a1a}-9.28\%}$
test_plain_set_nested_inplace 64.4010μs 30.1909μs 33.1225 KOps/s 38.5931 KOps/s $\textbf{\color{#d91a1a}-14.18\%}$
test_plain_set_stack_nested_inplace 0.8850ms 0.5471ms 1.8277 KOps/s 1.9707 KOps/s $\textbf{\color{#d91a1a}-7.25\%}$
test_items 45.9010μs 3.8450μs 260.0779 KOps/s 265.9625 KOps/s $\color{#d91a1a}-2.21\%$
test_items_nested 0.4833ms 0.3769ms 2.6534 KOps/s 2.6465 KOps/s $\color{#35bf28}+0.26\%$
test_items_nested_locked 0.4754ms 0.3716ms 2.6914 KOps/s 2.6641 KOps/s $\color{#35bf28}+1.02\%$
test_items_nested_leaf 1.2792ms 0.2372ms 4.2153 KOps/s 4.2843 KOps/s $\color{#d91a1a}-1.61\%$
test_items_stack_nested 2.6269ms 2.4761ms 403.8684 Ops/s 400.0639 Ops/s $\color{#35bf28}+0.95\%$
test_items_stack_nested_leaf 2.4335ms 2.2521ms 444.0221 Ops/s 426.5666 Ops/s $\color{#35bf28}+4.09\%$
test_items_stack_nested_locked 1.3555ms 1.0940ms 914.0508 Ops/s 911.1391 Ops/s $\color{#35bf28}+0.32\%$
test_keys 35.0010μs 5.8306μs 171.5088 KOps/s 172.1857 KOps/s $\color{#d91a1a}-0.39\%$
test_keys_nested 0.8543ms 0.2008ms 4.9794 KOps/s 4.8725 KOps/s $\color{#35bf28}+2.19\%$
test_keys_nested_locked 0.2970ms 0.2052ms 4.8724 KOps/s 5.0525 KOps/s $\color{#d91a1a}-3.57\%$
test_keys_nested_leaf 0.3495ms 0.1916ms 5.2180 KOps/s 4.8842 KOps/s $\textbf{\color{#35bf28}+6.83\%}$
test_keys_stack_nested 2.4077ms 2.1007ms 476.0218 Ops/s 487.3594 Ops/s $\color{#d91a1a}-2.33\%$
test_keys_stack_nested_leaf 2.3281ms 2.1204ms 471.6012 Ops/s 504.6474 Ops/s $\textbf{\color{#d91a1a}-6.55\%}$
test_keys_stack_nested_locked 1.1323ms 0.9092ms 1.0998 KOps/s 1.1399 KOps/s $\color{#d91a1a}-3.52\%$
test_values 24.9010μs 1.7395μs 574.8858 KOps/s 547.7432 KOps/s $\color{#35bf28}+4.96\%$
test_values_nested 0.1323ms 68.8373μs 14.5270 KOps/s 14.7872 KOps/s $\color{#d91a1a}-1.76\%$
test_values_nested_locked 0.1098ms 68.2859μs 14.6443 KOps/s 14.8960 KOps/s $\color{#d91a1a}-1.69\%$
test_values_nested_leaf 0.1379ms 62.2299μs 16.0694 KOps/s 16.5481 KOps/s $\color{#d91a1a}-2.89\%$
test_values_stack_nested 2.2452ms 2.0287ms 492.9177 Ops/s 503.3091 Ops/s $\color{#d91a1a}-2.06\%$
test_values_stack_nested_leaf 2.1839ms 2.0607ms 485.2621 Ops/s 505.0919 Ops/s $\color{#d91a1a}-3.93\%$
test_values_stack_nested_locked 0.9424ms 0.7691ms 1.3002 KOps/s 1.4053 KOps/s $\textbf{\color{#d91a1a}-7.48\%}$
test_membership 32.8000μs 2.0098μs 497.5741 KOps/s 506.6576 KOps/s $\color{#d91a1a}-1.79\%$
test_membership_nested 26.1010μs 3.6045μs 277.4321 KOps/s 293.6563 KOps/s $\textbf{\color{#d91a1a}-5.52\%}$
test_membership_nested_leaf 28.8000μs 3.3419μs 299.2310 KOps/s 286.8601 KOps/s $\color{#35bf28}+4.31\%$
test_membership_stacked_nested 26.3000μs 2.1705μs 460.7317 KOps/s 487.8911 KOps/s $\textbf{\color{#d91a1a}-5.57\%}$
test_membership_stacked_nested_leaf 28.1000μs 2.1031μs 475.4921 KOps/s 500.4967 KOps/s $\color{#d91a1a}-5.00\%$
test_membership_nested_last 45.6010μs 9.5125μs 105.1245 KOps/s 120.3756 KOps/s $\textbf{\color{#d91a1a}-12.67\%}$
test_membership_nested_leaf_last 34.7010μs 9.4578μs 105.7331 KOps/s 116.1309 KOps/s $\textbf{\color{#d91a1a}-8.95\%}$
test_membership_stacked_nested_last 1.6700ms 1.5093ms 662.5523 Ops/s 716.2090 Ops/s $\textbf{\color{#d91a1a}-7.49\%}$
test_membership_stacked_nested_leaf_last 1.6543ms 1.4572ms 686.2483 Ops/s 706.1706 Ops/s $\color{#d91a1a}-2.82\%$
test_stacked_getleaf 1.6096ms 1.4388ms 695.0300 Ops/s 716.7745 Ops/s $\color{#d91a1a}-3.03\%$
test_stacked_get 2.0422ms 1.3792ms 725.0556 Ops/s 708.1290 Ops/s $\color{#35bf28}+2.39\%$
test_lock_nested 1.1920ms 1.0260ms 974.6287 Ops/s 935.9597 Ops/s $\color{#35bf28}+4.13\%$
test_lock_stack_nested 93.9498ms 14.5243ms 68.8500 Ops/s 69.4056 Ops/s $\color{#d91a1a}-0.80\%$
test_unlock_nested 1.3347ms 1.1034ms 906.2545 Ops/s 940.6358 Ops/s $\color{#d91a1a}-3.66\%$
test_unlock_stack_nested 91.9753ms 15.2457ms 65.5923 Ops/s 65.5268 Ops/s $\color{#35bf28}+0.10\%$
test_flatten_speed 1.1962ms 1.0430ms 958.8016 Ops/s 953.2753 Ops/s $\color{#35bf28}+0.58\%$
test_unflatten_speed 2.0534ms 1.9327ms 517.4221 Ops/s 503.9320 Ops/s $\color{#35bf28}+2.68\%$
test_common_ops 1.7771ms 1.2701ms 787.3249 Ops/s 799.4624 Ops/s $\color{#d91a1a}-1.52\%$
test_creation 35.3010μs 7.3220μs 136.5753 KOps/s 142.1548 KOps/s $\color{#d91a1a}-3.92\%$
test_creation_empty 38.7010μs 15.1163μs 66.1538 KOps/s 67.5503 KOps/s $\color{#d91a1a}-2.07\%$
test_creation_nested_1 56.9010μs 28.8017μs 34.7201 KOps/s 37.5620 KOps/s $\textbf{\color{#d91a1a}-7.57\%}$
test_creation_nested_2 77.4010μs 29.8671μs 33.4816 KOps/s 35.4718 KOps/s $\textbf{\color{#d91a1a}-5.61\%}$
test_clone 0.3515ms 28.7998μs 34.7224 KOps/s 39.2555 KOps/s $\textbf{\color{#d91a1a}-11.55\%}$
test_getitem[int] 75.5010μs 33.5798μs 29.7798 KOps/s 29.8580 KOps/s $\color{#d91a1a}-0.26\%$
test_getitem[slice_int] 0.1209ms 72.5566μs 13.7823 KOps/s 13.7240 KOps/s $\color{#35bf28}+0.43\%$
test_getitem[range] 0.1193ms 71.9605μs 13.8965 KOps/s 13.0370 KOps/s $\textbf{\color{#35bf28}+6.59\%}$
test_getitem[tuple] 0.1106ms 66.0856μs 15.1319 KOps/s 15.1658 KOps/s $\color{#d91a1a}-0.22\%$
test_getitem[list] 0.1419ms 64.1769μs 15.5819 KOps/s 15.8216 KOps/s $\color{#d91a1a}-1.51\%$
test_setitem_dim[int] 80.0010μs 50.4294μs 19.8297 KOps/s 20.8578 KOps/s $\color{#d91a1a}-4.93\%$
test_setitem_dim[slice_int] 0.1385ms 92.8709μs 10.7676 KOps/s 10.8883 KOps/s $\color{#d91a1a}-1.11\%$
test_setitem_dim[range] 0.1286ms 86.2642μs 11.5923 KOps/s 11.4782 KOps/s $\color{#35bf28}+0.99\%$
test_setitem_dim[tuple] 0.1228ms 85.9697μs 11.6320 KOps/s 11.8936 KOps/s $\color{#d91a1a}-2.20\%$
test_setitem 0.3554ms 36.1259μs 27.6810 KOps/s 29.7493 KOps/s $\textbf{\color{#d91a1a}-6.95\%}$
test_set 0.3038ms 34.7761μs 28.7554 KOps/s 29.2860 KOps/s $\color{#d91a1a}-1.81\%$
test_set_shared 0.4090ms 0.2013ms 4.9671 KOps/s 4.9121 KOps/s $\color{#35bf28}+1.12\%$
test_update 0.3528ms 37.0508μs 26.9900 KOps/s 26.6159 KOps/s $\color{#35bf28}+1.41\%$
test_update_nested 0.4132ms 56.6009μs 17.6676 KOps/s 18.5387 KOps/s $\color{#d91a1a}-4.70\%$
test_set_nested 0.3905ms 47.2737μs 21.1534 KOps/s 22.1851 KOps/s $\color{#d91a1a}-4.65\%$
test_set_nested_new 0.1140ms 69.4783μs 14.3930 KOps/s 15.2910 KOps/s $\textbf{\color{#d91a1a}-5.87\%}$
test_select 0.2755ms 0.1394ms 7.1761 KOps/s 9.7997 KOps/s $\textbf{\color{#d91a1a}-26.77\%}$
test_creation[device0] 0.6196ms 0.5269ms 1.8978 KOps/s 1.9834 KOps/s $\color{#d91a1a}-4.32\%$
test_creation_from_tensor 0.7111ms 0.5717ms 1.7491 KOps/s 1.7662 KOps/s $\color{#d91a1a}-0.97\%$
test_add_one[memmap_tensor0] 0.2372ms 35.1924μs 28.4152 KOps/s 31.0880 KOps/s $\textbf{\color{#d91a1a}-8.60\%}$
test_contiguous[memmap_tensor0] 35.0010μs 9.1561μs 109.2173 KOps/s 105.7918 KOps/s $\color{#35bf28}+3.24\%$
test_stack[memmap_tensor0] 0.1448ms 29.2864μs 34.1455 KOps/s 34.9151 KOps/s $\color{#d91a1a}-2.20\%$
test_memmaptd_index 0.3669ms 0.3043ms 3.2863 KOps/s 3.3909 KOps/s $\color{#d91a1a}-3.08\%$
test_memmaptd_index_astensor 1.2967ms 1.1485ms 870.7211 Ops/s 867.9113 Ops/s $\color{#35bf28}+0.32\%$
test_memmaptd_index_op 2.7153ms 2.5580ms 390.9271 Ops/s 436.6688 Ops/s $\textbf{\color{#d91a1a}-10.48\%}$
test_reshape_pytree 0.1132ms 42.4675μs 23.5474 KOps/s 26.7153 KOps/s $\textbf{\color{#d91a1a}-11.86\%}$
test_reshape_td 95.5020μs 52.5023μs 19.0468 KOps/s 20.7010 KOps/s $\textbf{\color{#d91a1a}-7.99\%}$
test_view_pytree 0.1135ms 40.6562μs 24.5965 KOps/s 26.0028 KOps/s $\textbf{\color{#d91a1a}-5.41\%}$
test_view_td 49.6010μs 10.6524μs 93.8754 KOps/s 103.8318 KOps/s $\textbf{\color{#d91a1a}-9.59\%}$
test_unbind_pytree 94.2010μs 42.5765μs 23.4871 KOps/s 23.4244 KOps/s $\color{#35bf28}+0.27\%$
test_unbind_td 0.2967ms 0.1424ms 7.0207 KOps/s 6.5078 KOps/s $\textbf{\color{#35bf28}+7.88\%}$
test_split_pytree 88.3010μs 46.6632μs 21.4302 KOps/s 21.0467 KOps/s $\color{#35bf28}+1.82\%$
test_split_td 0.7736ms 0.1165ms 8.5851 KOps/s 7.3724 KOps/s $\textbf{\color{#35bf28}+16.45\%}$
test_add_pytree 0.1563ms 46.7235μs 21.4025 KOps/s 18.5916 KOps/s $\textbf{\color{#35bf28}+15.12\%}$
test_add_td 0.1360ms 64.6510μs 15.4677 KOps/s 15.3947 KOps/s $\color{#35bf28}+0.47\%$
test_distributed 33.3010μs 10.0310μs 99.6907 KOps/s 102.2890 KOps/s $\color{#d91a1a}-2.54\%$
test_tdmodule 1.6421ms 29.1688μs 34.2832 KOps/s 35.1145 KOps/s $\color{#d91a1a}-2.37\%$
test_tdmodule_dispatch 0.3300ms 62.0507μs 16.1159 KOps/s 16.7442 KOps/s $\color{#d91a1a}-3.75\%$
test_tdseq 0.1797ms 34.3561μs 29.1069 KOps/s 27.1964 KOps/s $\textbf{\color{#35bf28}+7.02\%}$
test_tdseq_dispatch 0.2495ms 74.9614μs 13.3402 KOps/s 13.9476 KOps/s $\color{#d91a1a}-4.35\%$
test_instantiation_functorch 1.9822ms 1.6939ms 590.3690 Ops/s 565.2689 Ops/s $\color{#35bf28}+4.44\%$
test_instantiation_td 2.2263ms 1.3540ms 738.5426 Ops/s 691.0019 Ops/s $\textbf{\color{#35bf28}+6.88\%}$
test_exec_functorch 0.2924ms 0.2152ms 4.6463 KOps/s 4.6994 KOps/s $\color{#d91a1a}-1.13\%$
test_exec_td 0.2529ms 0.1960ms 5.1027 KOps/s 5.0761 KOps/s $\color{#35bf28}+0.52\%$
test_vmap_mlp_speed[True-True] 1.9898ms 1.6066ms 622.4168 Ops/s 616.9536 Ops/s $\color{#35bf28}+0.89\%$
test_vmap_mlp_speed[True-False] 1.9195ms 0.6832ms 1.4637 KOps/s 1.5343 KOps/s $\color{#d91a1a}-4.60\%$
test_vmap_mlp_speed[False-True] 2.5219ms 1.3022ms 767.9310 Ops/s 786.5041 Ops/s $\color{#d91a1a}-2.36\%$
test_vmap_mlp_speed[False-False] 0.8782ms 0.4699ms 2.1279 KOps/s 2.0772 KOps/s $\color{#35bf28}+2.44\%$
test_vmap_transformer_speed[True-True] 19.3275ms 17.8641ms 55.9780 Ops/s 56.6160 Ops/s $\color{#d91a1a}-1.13\%$
test_vmap_transformer_speed[True-False] 10.8677ms 9.1066ms 109.8106 Ops/s 106.1211 Ops/s $\color{#35bf28}+3.48\%$
test_vmap_transformer_speed[False-True] 19.9776ms 18.2976ms 54.6519 Ops/s 56.5888 Ops/s $\color{#d91a1a}-3.42\%$
test_vmap_transformer_speed[False-False] 12.1576ms 9.3543ms 106.9030 Ops/s 105.0289 Ops/s $\color{#35bf28}+1.78\%$

@vmoens vmoens merged commit b7af442 into main Jun 24, 2023
@vmoens vmoens deleted the fix_optdeps branch June 24, 2023 05:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants