Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BugFix] Fix max length #408

Merged
merged 2 commits into from
Jun 5, 2023
Merged

[BugFix] Fix max length #408

merged 2 commits into from
Jun 5, 2023

Conversation

vmoens
Copy link
Contributor

@vmoens vmoens commented Jun 5, 2023

No description provided.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jun 5, 2023
@vmoens vmoens added the bug Something isn't working label Jun 5, 2023
@vmoens vmoens merged commit 55e5be1 into main Jun 5, 2023
@vmoens vmoens deleted the conftest_bf branch June 5, 2023 13:15
@github-actions
Copy link

github-actions bot commented Jun 5, 2023

$\color{#D29922}\textsf{\Large⚠\kern{0.2cm}\normalsize Warning}$ Result of CPU Benchmark Tests

Total Benchmarks: 47. Improved: $\large\color{#35bf28}4$. Worsened: $\large\color{#d91a1a}1$.

Expand to view detailed results
Name Max Mean Ops Ops on Repo HEAD Change
test_common_ops 1.1795ms 1.1552ms 865.6313 Ops/s 875.4250 Ops/s $\color{#d91a1a}-1.12\%$
test_creation 4.7120μs 4.1587μs 240.4585 KOps/s 233.8794 KOps/s $\color{#35bf28}+2.81\%$
test_creation_empty 16.9221μs 16.0830μs 62.1773 KOps/s 62.3848 KOps/s $\color{#d91a1a}-0.33\%$
test_creation_nested_1 27.0501μs 25.9993μs 38.4626 KOps/s 27.3405 KOps/s $\textbf{\color{#35bf28}+40.68\%}$
test_creation_nested_2 28.7212μs 28.1570μs 35.5152 KOps/s 35.5146 KOps/s $+0.00\%$
test_clone 27.1891μs 26.1066μs 38.3045 KOps/s 38.2550 KOps/s $\color{#35bf28}+0.13\%$
test_getitem[int] 40.1359μs 31.6752μs 31.5705 KOps/s 31.5639 KOps/s $\color{#35bf28}+0.02\%$
test_getitem[slice_int] 87.1854μs 66.6442μs 15.0051 KOps/s 15.3546 KOps/s $\color{#d91a1a}-2.28\%$
test_getitem[range] 95.2256μs 64.3209μs 15.5470 KOps/s 15.7486 KOps/s $\color{#d91a1a}-1.28\%$
test_getitem[tuple] 71.8704μs 61.4626μs 16.2701 KOps/s 17.0256 KOps/s $\color{#d91a1a}-4.44\%$
test_getitem[list] 59.3521μs 55.2393μs 18.1030 KOps/s 18.1999 KOps/s $\color{#d91a1a}-0.53\%$
test_setitem_dim[int] 83.8000μs 44.9172μs 22.2632 KOps/s 22.5172 KOps/s $\color{#d91a1a}-1.13\%$
test_setitem_dim[slice_int] 0.1121ms 82.7830μs 12.0798 KOps/s 12.1726 KOps/s $\color{#d91a1a}-0.76\%$
test_setitem_dim[range] 0.1313ms 74.8561μs 13.3590 KOps/s 13.5140 KOps/s $\color{#d91a1a}-1.15\%$
test_setitem_dim[tuple] 0.1074ms 76.6468μs 13.0469 KOps/s 13.3705 KOps/s $\color{#d91a1a}-2.42\%$
test_setitem 36.3301μs 35.0738μs 28.5113 KOps/s 28.8162 KOps/s $\color{#d91a1a}-1.06\%$
test_set 35.7591μs 34.4940μs 28.9906 KOps/s 29.4207 KOps/s $\color{#d91a1a}-1.46\%$
test_set_shared 0.1541ms 0.1514ms 6.6033 KOps/s 6.5654 KOps/s $\color{#35bf28}+0.58\%$
test_update 45.1132μs 43.5697μs 22.9517 KOps/s 23.1931 KOps/s $\color{#d91a1a}-1.04\%$
test_update_nested 64.2883μs 63.7743μs 15.6803 KOps/s 15.8102 KOps/s $\color{#d91a1a}-0.82\%$
test_set_nested 50.1952μs 45.1871μs 22.1302 KOps/s 22.4307 KOps/s $\color{#d91a1a}-1.34\%$
test_set_nested_new 69.5543μs 63.4658μs 15.7565 KOps/s 10.8171 KOps/s $\textbf{\color{#35bf28}+45.66\%}$
test_select 0.1059ms 0.1038ms 9.6293 KOps/s 9.7002 KOps/s $\color{#d91a1a}-0.73\%$
test_creation[device0] 1.0578ms 0.4152ms 2.4086 KOps/s 2.1398 KOps/s $\textbf{\color{#35bf28}+12.56\%}$
test_creation_from_tensor 0.5407ms 0.3932ms 2.5434 KOps/s 2.5611 KOps/s $\color{#d91a1a}-0.69\%$
test_add_one[memmap_tensor0] 63.5322μs 29.9360μs 33.4046 KOps/s 34.3828 KOps/s $\color{#d91a1a}-2.85\%$
test_contiguous[memmap_tensor0] 11.8940μs 8.0862μs 123.6677 KOps/s 125.5064 KOps/s $\color{#d91a1a}-1.47\%$
test_stack[memmap_tensor0] 0.1596ms 39.6302μs 25.2333 KOps/s 24.9438 KOps/s $\color{#35bf28}+1.16\%$
test_reshape_pytree 41.1942μs 35.6640μs 28.0395 KOps/s 28.2158 KOps/s $\color{#d91a1a}-0.63\%$
test_reshape_td 50.5572μs 48.0897μs 20.7945 KOps/s 21.0327 KOps/s $\color{#d91a1a}-1.13\%$
test_view_pytree 33.8041μs 32.9020μs 30.3933 KOps/s 30.7721 KOps/s $\color{#d91a1a}-1.23\%$
test_view_td 9.6210μs 8.8831μs 112.5729 KOps/s 112.0326 KOps/s $\color{#35bf28}+0.48\%$
test_unbind_pytree 39.0411μs 37.5015μs 26.6656 KOps/s 27.1977 KOps/s $\color{#d91a1a}-1.96\%$
test_unbind_td 0.1784ms 0.1761ms 5.6772 KOps/s 5.8112 KOps/s $\color{#d91a1a}-2.30\%$
test_split_pytree 43.6302μs 41.9200μs 23.8550 KOps/s 24.4076 KOps/s $\color{#d91a1a}-2.26\%$
test_split_td 0.1272ms 0.1148ms 8.7138 KOps/s 8.8812 KOps/s $\color{#d91a1a}-1.89\%$
test_add_pytree 59.2862μs 44.8118μs 22.3155 KOps/s 22.5987 KOps/s $\color{#d91a1a}-1.25\%$
test_add_td 0.1097ms 71.2821μs 14.0288 KOps/s 14.3290 KOps/s $\color{#d91a1a}-2.10\%$
test_distributed 54.0000μs 54.0000μs 18.5185 KOps/s 14.9925 KOps/s $\textbf{\color{#35bf28}+23.52\%}$
test_tdmodule 53.3000μs 27.4803μs 36.3897 KOps/s 35.9274 KOps/s $\color{#35bf28}+1.29\%$
test_tdmodule_dispatch 38.3303ms 61.7139μs 16.2038 KOps/s 17.0577 KOps/s $\textbf{\color{#d91a1a}-5.01\%}$
test_tdseq 0.1693ms 33.7469μs 29.6323 KOps/s 29.2804 KOps/s $\color{#35bf28}+1.20\%$
test_tdseq_dispatch 0.1178ms 59.8056μs 16.7208 KOps/s 16.6641 KOps/s $\color{#35bf28}+0.34\%$
test_instantiation_functorch 1.5793ms 1.4890ms 671.5958 Ops/s 667.1270 Ops/s $\color{#35bf28}+0.67\%$
test_instantiation_td 6.1773ms 1.1883ms 841.5550 Ops/s 884.4880 Ops/s $\color{#d91a1a}-4.85\%$
test_exec_functorch 0.1785ms 0.1746ms 5.7261 KOps/s 5.8204 KOps/s $\color{#d91a1a}-1.62\%$
test_exec_td 0.3181ms 0.3145ms 3.1798 KOps/s 3.1980 KOps/s $\color{#d91a1a}-0.57\%$

@github-actions
Copy link

github-actions bot commented Jun 5, 2023

$\color{#35bf28}\textsf{\Large✔\kern{0.2cm}\normalsize OK}$ Result of GPU Benchmark Tests

Total Benchmarks: 47. Improved: $\large\color{#35bf28}1$. Worsened: $\large\color{#d91a1a}0$.

Expand to view detailed results
Name Max Mean Ops Ops on Repo HEAD Change
test_common_ops 1.1088ms 1.0619ms 941.7208 Ops/s 931.7136 Ops/s $\color{#35bf28}+1.07\%$
test_creation 3.5380μs 3.2324μs 309.3654 KOps/s 310.3474 KOps/s $\color{#d91a1a}-0.32\%$
test_creation_empty 14.0451μs 13.5194μs 73.9680 KOps/s 73.1533 KOps/s $\color{#35bf28}+1.11\%$
test_creation_nested_1 23.2482μs 21.7941μs 45.8840 KOps/s 45.2777 KOps/s $\color{#35bf28}+1.34\%$
test_creation_nested_2 24.7873μs 23.5161μs 42.5241 KOps/s 42.1811 KOps/s $\color{#35bf28}+0.81\%$
test_clone 27.7313μs 21.3891μs 46.7527 KOps/s 46.3071 KOps/s $\color{#35bf28}+0.96\%$
test_getitem[int] 26.5656μs 25.5741μs 39.1020 KOps/s 37.6361 KOps/s $\color{#35bf28}+3.90\%$
test_getitem[slice_int] 53.5302μs 52.9964μs 18.8692 KOps/s 18.1401 KOps/s $\color{#35bf28}+4.02\%$
test_getitem[range] 59.3359μs 57.3172μs 17.4468 KOps/s 17.0445 KOps/s $\color{#35bf28}+2.36\%$
test_getitem[tuple] 49.6742μs 49.2260μs 20.3145 KOps/s 19.7113 KOps/s $\color{#35bf28}+3.06\%$
test_getitem[list] 54.2534μs 50.4846μs 19.8080 KOps/s 18.8324 KOps/s $\textbf{\color{#35bf28}+5.18\%}$
test_setitem_dim[int] 66.1010μs 37.7363μs 26.4997 KOps/s 25.9617 KOps/s $\color{#35bf28}+2.07\%$
test_setitem_dim[slice_int] 0.1410ms 68.2061μs 14.6614 KOps/s 14.1415 KOps/s $\color{#35bf28}+3.68\%$
test_setitem_dim[range] 0.1541ms 66.4066μs 15.0587 KOps/s 14.5359 KOps/s $\color{#35bf28}+3.60\%$
test_setitem_dim[tuple] 91.6010μs 61.9961μs 16.1301 KOps/s 15.8723 KOps/s $\color{#35bf28}+1.62\%$
test_setitem 31.9013μs 29.9471μs 33.3922 KOps/s 33.1426 KOps/s $\color{#35bf28}+0.75\%$
test_set 30.7653μs 29.1662μs 34.2863 KOps/s 33.8315 KOps/s $\color{#35bf28}+1.34\%$
test_set_shared 0.1730ms 0.1663ms 6.0129 KOps/s 5.9441 KOps/s $\color{#35bf28}+1.16\%$
test_update 38.4953μs 37.1940μs 26.8860 KOps/s 26.4346 KOps/s $\color{#35bf28}+1.71\%$
test_update_nested 54.3855μs 53.2039μs 18.7956 KOps/s 18.3649 KOps/s $\color{#35bf28}+2.35\%$
test_set_nested 38.5543μs 36.9298μs 27.0784 KOps/s 26.6244 KOps/s $\color{#35bf28}+1.71\%$
test_set_nested_new 53.2205μs 51.2639μs 19.5069 KOps/s 19.0473 KOps/s $\color{#35bf28}+2.41\%$
test_select 83.5228μs 81.1101μs 12.3289 KOps/s 12.1800 KOps/s $\color{#35bf28}+1.22\%$
test_creation[device0] 1.2409ms 0.5035ms 1.9863 KOps/s 1.9982 KOps/s $\color{#d91a1a}-0.59\%$
test_creation_from_tensor 0.5909ms 0.4688ms 2.1332 KOps/s 2.1287 KOps/s $\color{#35bf28}+0.21\%$
test_add_one[memmap_tensor0] 32.4113μs 29.4433μs 33.9636 KOps/s 34.2922 KOps/s $\color{#d91a1a}-0.96\%$
test_contiguous[memmap_tensor0] 8.4091μs 7.9907μs 125.1450 KOps/s 124.2522 KOps/s $\color{#35bf28}+0.72\%$
test_stack[memmap_tensor0] 0.1936ms 43.8503μs 22.8049 KOps/s 21.7719 KOps/s $\color{#35bf28}+4.74\%$
test_reshape_pytree 33.9653μs 28.4258μs 35.1793 KOps/s 34.7643 KOps/s $\color{#35bf28}+1.19\%$
test_reshape_td 42.7904μs 38.7194μs 25.8268 KOps/s 25.1523 KOps/s $\color{#35bf28}+2.68\%$
test_view_pytree 27.5542μs 25.7702μs 38.8045 KOps/s 37.7268 KOps/s $\color{#35bf28}+2.86\%$
test_view_td 7.9811μs 7.0252μs 142.3446 KOps/s 143.2946 KOps/s $\color{#d91a1a}-0.66\%$
test_unbind_pytree 32.1783μs 30.6867μs 32.5874 KOps/s 32.7038 KOps/s $\color{#d91a1a}-0.36\%$
test_unbind_td 0.1479ms 0.1453ms 6.8833 KOps/s 6.7975 KOps/s $\color{#35bf28}+1.26\%$
test_split_pytree 36.5403μs 33.9598μs 29.4466 KOps/s 28.5206 KOps/s $\color{#35bf28}+3.25\%$
test_split_td 94.6519μs 92.2477μs 10.8404 KOps/s 10.8206 KOps/s $\color{#35bf28}+0.18\%$
test_add_pytree 39.9634μs 37.8752μs 26.4025 KOps/s 26.4889 KOps/s $\color{#d91a1a}-0.33\%$
test_add_td 64.6466μs 62.1753μs 16.0836 KOps/s 16.1793 KOps/s $\color{#d91a1a}-0.59\%$
test_distributed 85.5010μs 85.5010μs 11.6958 KOps/s 12.1209 KOps/s $\color{#d91a1a}-3.51\%$
test_tdmodule 0.1265ms 24.4025μs 40.9793 KOps/s 41.1249 KOps/s $\color{#d91a1a}-0.35\%$
test_tdmodule_dispatch 0.2169ms 53.5348μs 18.6794 KOps/s 18.6255 KOps/s $\color{#35bf28}+0.29\%$
test_tdseq 60.2010μs 32.4157μs 30.8492 KOps/s 30.7931 KOps/s $\color{#35bf28}+0.18\%$
test_tdseq_dispatch 0.1523ms 63.3320μs 15.7898 KOps/s 15.4942 KOps/s $\color{#35bf28}+1.91\%$
test_instantiation_functorch 1.3543ms 1.2766ms 783.3312 Ops/s 785.5863 Ops/s $\color{#d91a1a}-0.29\%$
test_instantiation_td 1.0474ms 0.9985ms 1.0015 KOps/s 1.0063 KOps/s $\color{#d91a1a}-0.47\%$
test_exec_functorch 0.1762ms 0.1571ms 6.3671 KOps/s 6.3076 KOps/s $\color{#35bf28}+0.94\%$
test_exec_td 0.2781ms 0.2740ms 3.6496 KOps/s 3.6322 KOps/s $\color{#35bf28}+0.48\%$

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants