Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BugFix] Fix imports #2605

Merged
merged 3 commits into from
Nov 25, 2024
Merged

[BugFix] Fix imports #2605

merged 3 commits into from
Nov 25, 2024

Conversation

vmoens
Copy link
Contributor

@vmoens vmoens commented Nov 24, 2024 •
edited
Loading

Stack from ghstack (oldest at bottom):

@vmoens
Update
1d96ae4 
[ghstack-poisoned]
@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Nov 24, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/rl/2605

Note: Links to docs will display an error until the docs builds have been completed.

❌ 10 New Failures

As of commit 3d18e51 with merge base a1e21f5 (image):

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

vmoens added a commit that referenced this pull request Nov 24, 2024
@vmoens
[BugFix] Fix imports
96a01be 
ghstack-source-id: 27c44bcfcc8bf010b72d85cf91c7a4917c2dc50a
Pull Request resolved: #2605
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Nov 24, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 24, 2024 •
edited
Loading

$\color{#D29922}\textsf{\Large⚠\kern{0.2cm}\normalsize Warning}$ Result of GPU Benchmark Tests

Total Benchmarks: 149. Improved: $\large\color{#35bf28}24$. Worsened: $\large\color{#d91a1a}11$.

Expand to view detailed results
Name Max Mean Ops Ops on Repo HEAD Change
test_simple 0.7434s 0.7427s 1.3465 Ops/s 1.3319 Ops/s $\color{#35bf28}+1.09\%$
test_transformed 0.9865s 0.9860s 1.0142 Ops/s 1.0004 Ops/s $\color{#35bf28}+1.38\%$
test_serial 2.1252s 2.1204s 0.4716 Ops/s 0.4691 Ops/s $\color{#35bf28}+0.52\%$
test_parallel 2.0251s 1.9532s 0.5120 Ops/s 0.5065 Ops/s $\color{#35bf28}+1.09\%$
test_step_mdp_speed[True-True-True-True-True] 0.5430ms 34.5428μs 28.9496 KOps/s 28.3937 KOps/s $\color{#35bf28}+1.96\%$
test_step_mdp_speed[True-True-True-True-False] 53.5120μs 20.1378μs 49.6579 KOps/s 48.8611 KOps/s $\color{#35bf28}+1.63\%$
test_step_mdp_speed[True-True-True-False-True] 49.6810μs 19.6494μs 50.8922 KOps/s 50.4987 KOps/s $\color{#35bf28}+0.78\%$
test_step_mdp_speed[True-True-True-False-False] 44.2000μs 11.4267μs 87.5144 KOps/s 86.5279 KOps/s $\color{#35bf28}+1.14\%$
test_step_mdp_speed[True-True-False-True-True] 77.2810μs 37.6216μs 26.5805 KOps/s 26.3215 KOps/s $\color{#35bf28}+0.98\%$
test_step_mdp_speed[True-True-False-True-False] 60.1010μs 21.9137μs 45.6336 KOps/s 44.7361 KOps/s $\color{#35bf28}+2.01\%$
test_step_mdp_speed[True-True-False-False-True] 56.1810μs 21.7885μs 45.8959 KOps/s 46.3324 KOps/s $\color{#d91a1a}-0.94\%$
test_step_mdp_speed[True-True-False-False-False] 54.7610μs 13.5884μs 73.5920 KOps/s 75.0093 KOps/s $\color{#d91a1a}-1.89\%$
test_step_mdp_speed[True-False-True-True-True] 78.3320μs 39.7203μs 25.1761 KOps/s 25.4453 KOps/s $\color{#d91a1a}-1.06\%$
test_step_mdp_speed[True-False-True-True-False] 66.8410μs 24.2975μs 41.1566 KOps/s 42.5151 KOps/s $\color{#d91a1a}-3.20\%$
test_step_mdp_speed[True-False-True-False-True] 53.4010μs 21.9372μs 45.5847 KOps/s 44.8001 KOps/s $\color{#35bf28}+1.75\%$
test_step_mdp_speed[True-False-True-False-False] 42.3110μs 13.6358μs 73.3365 KOps/s 73.8621 KOps/s $\color{#d91a1a}-0.71\%$
test_step_mdp_speed[True-False-False-True-True] 83.6820μs 41.9156μs 23.8575 KOps/s 24.2236 KOps/s $\color{#d91a1a}-1.51\%$
test_step_mdp_speed[True-False-False-True-False] 57.5510μs 26.4260μs 37.8415 KOps/s 38.6643 KOps/s $\color{#d91a1a}-2.13\%$
test_step_mdp_speed[True-False-False-False-True] 62.8810μs 23.9012μs 41.8389 KOps/s 41.6858 KOps/s $\color{#35bf28}+0.37\%$
test_step_mdp_speed[True-False-False-False-False] 46.0010μs 15.5280μs 64.3999 KOps/s 65.3248 KOps/s $\color{#d91a1a}-1.42\%$
test_step_mdp_speed[False-True-True-True-True] 74.7020μs 39.5308μs 25.2967 KOps/s 24.9448 KOps/s $\color{#35bf28}+1.41\%$
test_step_mdp_speed[False-True-True-True-False] 57.6120μs 24.2454μs 41.2450 KOps/s 41.4186 KOps/s $\color{#d91a1a}-0.42\%$
test_step_mdp_speed[False-True-True-False-True] 60.2310μs 25.2378μs 39.6230 KOps/s 39.7639 KOps/s $\color{#d91a1a}-0.35\%$
test_step_mdp_speed[False-True-True-False-False] 45.7110μs 14.9876μs 66.7220 KOps/s 66.7490 KOps/s $\color{#d91a1a}-0.04\%$
test_step_mdp_speed[False-True-False-True-True] 81.2820μs 41.7043μs 23.9784 KOps/s 23.9950 KOps/s $\color{#d91a1a}-0.07\%$
test_step_mdp_speed[False-True-False-True-False] 61.2510μs 25.9353μs 38.5574 KOps/s 38.0937 KOps/s $\color{#35bf28}+1.22\%$
test_step_mdp_speed[False-True-False-False-True] 3.6878ms 27.4622μs 36.4137 KOps/s 36.2754 KOps/s $\color{#35bf28}+0.38\%$
test_step_mdp_speed[False-True-False-False-False] 50.4410μs 16.9703μs 58.9263 KOps/s 58.6212 KOps/s $\color{#35bf28}+0.52\%$
test_step_mdp_speed[False-False-True-True-True] 79.9120μs 43.7140μs 22.8760 KOps/s 22.6660 KOps/s $\color{#35bf28}+0.93\%$
test_step_mdp_speed[False-False-True-True-False] 64.0110μs 28.0210μs 35.6876 KOps/s 35.1015 KOps/s $\color{#35bf28}+1.67\%$
test_step_mdp_speed[False-False-True-False-True] 65.2920μs 27.0920μs 36.9112 KOps/s 37.2280 KOps/s $\color{#d91a1a}-0.85\%$
test_step_mdp_speed[False-False-True-False-False] 53.1410μs 16.8807μs 59.2392 KOps/s 58.9355 KOps/s $\color{#35bf28}+0.52\%$
test_step_mdp_speed[False-False-False-True-True] 89.5120μs 45.7503μs 21.8578 KOps/s 22.0543 KOps/s $\color{#d91a1a}-0.89\%$
test_step_mdp_speed[False-False-False-True-False] 69.5410μs 29.7410μs 33.6236 KOps/s 33.2496 KOps/s $\color{#35bf28}+1.12\%$
test_step_mdp_speed[False-False-False-False-True] 63.9020μs 28.3176μs 35.3137 KOps/s 35.1058 KOps/s $\color{#35bf28}+0.59\%$
test_step_mdp_speed[False-False-False-False-False] 48.6510μs 18.6480μs 53.6250 KOps/s 53.5501 KOps/s $\color{#35bf28}+0.14\%$
test_values[generalized_advantage_estimate-True-True] 25.7447ms 25.2581ms 39.5913 Ops/s 38.9249 Ops/s $\color{#35bf28}+1.71\%$
test_values[vec_generalized_advantage_estimate-True-True] 0.1025s 2.9525ms 338.6919 Ops/s 338.1282 Ops/s $\color{#35bf28}+0.17\%$
test_values[td0_return_estimate-False-False] 0.1035ms 80.5882μs 12.4088 KOps/s 12.2816 KOps/s $\color{#35bf28}+1.04\%$
test_values[td1_return_estimate-False-False] 57.2269ms 56.4230ms 17.7233 Ops/s 17.4201 Ops/s $\color{#35bf28}+1.74\%$
test_values[vec_td1_return_estimate-False-False] 1.3301ms 1.0902ms 917.2698 Ops/s 912.1328 Ops/s $\color{#35bf28}+0.56\%$
test_values[td_lambda_return_estimate-True-False] 92.2493ms 89.1711ms 11.2144 Ops/s 10.9917 Ops/s $\color{#35bf28}+2.03\%$
test_values[vec_td_lambda_return_estimate-True-False] 1.3251ms 1.0893ms 918.0039 Ops/s 914.6375 Ops/s $\color{#35bf28}+0.37\%$
test_gae_speed[generalized_advantage_estimate-False-1-512] 25.5620ms 25.1732ms 39.7248 Ops/s 39.4312 Ops/s $\color{#35bf28}+0.74\%$
test_gae_speed[vec_generalized_advantage_estimate-True-1-512] 1.0470ms 0.7529ms 1.3282 KOps/s 1.3133 KOps/s $\color{#35bf28}+1.14\%$
test_gae_speed[vec_generalized_advantage_estimate-False-1-512] 0.8009ms 0.6738ms 1.4841 KOps/s 1.4714 KOps/s $\color{#35bf28}+0.87\%$
test_gae_speed[vec_generalized_advantage_estimate-True-32-512] 1.5237ms 1.4796ms 675.8566 Ops/s 672.5691 Ops/s $\color{#35bf28}+0.49\%$
test_gae_speed[vec_generalized_advantage_estimate-False-32-512] 0.7312ms 0.6895ms 1.4503 KOps/s 1.4392 KOps/s $\color{#35bf28}+0.77\%$
test_dqn_speed[False-None] 7.5039ms 1.4405ms 694.2232 Ops/s 678.8794 Ops/s $\color{#35bf28}+2.26\%$
test_dqn_speed[False-backward] 2.0831ms 2.0334ms 491.7856 Ops/s 473.6450 Ops/s $\color{#35bf28}+3.83\%$
test_dqn_speed[True-None] 0.6851ms 0.5549ms 1.8022 KOps/s 1.8272 KOps/s $\color{#d91a1a}-1.37\%$
test_dqn_speed[True-backward] 1.2911ms 1.2268ms 815.1251 Ops/s 822.2890 Ops/s $\color{#d91a1a}-0.87\%$
test_dqn_speed[reduce-overhead-None] 0.5867ms 0.5487ms 1.8226 KOps/s 1.8265 KOps/s $\color{#d91a1a}-0.21\%$
test_dqn_speed[reduce-overhead-backward] 1.2039ms 1.0684ms 935.9926 Ops/s 937.6043 Ops/s $\color{#d91a1a}-0.17\%$
test_ddpg_speed[False-None] 3.0614ms 2.6996ms 370.4213 Ops/s 358.1637 Ops/s $\color{#35bf28}+3.42\%$
test_ddpg_speed[False-backward] 4.4520ms 4.0529ms 246.7371 Ops/s 239.1320 Ops/s $\color{#35bf28}+3.18\%$
test_ddpg_speed[True-None] 1.2024ms 1.1089ms 901.7796 Ops/s 917.1525 Ops/s $\color{#d91a1a}-1.68\%$
test_ddpg_speed[True-backward] 2.3591ms 2.3148ms 431.9987 Ops/s 427.8401 Ops/s $\color{#35bf28}+0.97\%$
test_ddpg_speed[reduce-overhead-None] 1.2342ms 1.1244ms 889.3709 Ops/s 913.8004 Ops/s $\color{#d91a1a}-2.67\%$
test_ddpg_speed[reduce-overhead-backward] 1.8095ms 1.7723ms 564.2491 Ops/s 610.1809 Ops/s $\textbf{\color{#d91a1a}-7.53\%}$
test_sac_speed[False-None] 8.3153ms 7.7501ms 129.0312 Ops/s 125.0317 Ops/s $\color{#35bf28}+3.20\%$
test_sac_speed[False-backward] 11.2625ms 10.9018ms 91.7278 Ops/s 91.1723 Ops/s $\color{#35bf28}+0.61\%$
test_sac_speed[True-None] 1.6192ms 1.5332ms 652.2437 Ops/s 651.7889 Ops/s $\color{#35bf28}+0.07\%$
test_sac_speed[True-backward] 3.4810ms 3.3886ms 295.1035 Ops/s 311.1355 Ops/s $\textbf{\color{#d91a1a}-5.15\%}$
test_sac_speed[reduce-overhead-None] 22.5303ms 12.5083ms 79.9470 Ops/s 79.7595 Ops/s $\color{#35bf28}+0.24\%$
test_sac_speed[reduce-overhead-backward] 1.5376ms 1.4833ms 674.1609 Ops/s 750.4586 Ops/s $\textbf{\color{#d91a1a}-10.17\%}$
test_redq_speed[False-None] 8.0964ms 7.2872ms 137.2266 Ops/s 131.4123 Ops/s $\color{#35bf28}+4.42\%$
test_redq_speed[False-backward] 12.5714ms 11.4311ms 87.4805 Ops/s 87.9357 Ops/s $\color{#d91a1a}-0.52\%$
test_redq_speed[True-None] 2.0633ms 1.9964ms 500.9006 Ops/s 499.9080 Ops/s $\color{#35bf28}+0.20\%$
test_redq_speed[True-backward] 3.7748ms 3.6310ms 275.4042 Ops/s 259.0064 Ops/s $\textbf{\color{#35bf28}+6.33\%}$
test_redq_speed[reduce-overhead-None] 2.1354ms 1.9965ms 500.8798 Ops/s 498.7781 Ops/s $\color{#35bf28}+0.42\%$
test_redq_speed[reduce-overhead-backward] 3.9923ms 3.6785ms 271.8526 Ops/s 255.0777 Ops/s $\textbf{\color{#35bf28}+6.58\%}$
test_redq_deprec_speed[False-None] 9.3722ms 8.7087ms 114.8277 Ops/s 111.1297 Ops/s $\color{#35bf28}+3.33\%$
test_redq_deprec_speed[False-backward] 12.0265ms 11.6329ms 85.9630 Ops/s 81.7998 Ops/s $\textbf{\color{#35bf28}+5.09\%}$
test_redq_deprec_speed[True-None] 2.5189ms 2.3411ms 427.1476 Ops/s 430.7855 Ops/s $\color{#d91a1a}-0.84\%$
test_redq_deprec_speed[True-backward] 4.4272ms 3.9987ms 250.0803 Ops/s 240.7834 Ops/s $\color{#35bf28}+3.86\%$
test_redq_deprec_speed[reduce-overhead-None] 2.4772ms 2.3242ms 430.2497 Ops/s 431.8171 Ops/s $\color{#d91a1a}-0.36\%$
test_redq_deprec_speed[reduce-overhead-backward] 4.1500ms 3.9680ms 252.0185 Ops/s 241.4194 Ops/s $\color{#35bf28}+4.39\%$
test_td3_speed[False-None] 7.8259ms 7.5747ms 132.0176 Ops/s 128.4298 Ops/s $\color{#35bf28}+2.79\%$
test_td3_speed[False-backward] 10.3345ms 9.8306ms 101.7235 Ops/s 96.6397 Ops/s $\textbf{\color{#35bf28}+5.26\%}$
test_td3_speed[True-None] 1.6392ms 1.5745ms 635.1132 Ops/s 645.3062 Ops/s $\color{#d91a1a}-1.58\%$
test_td3_speed[True-backward] 3.1825ms 3.0799ms 324.6897 Ops/s 308.7608 Ops/s $\textbf{\color{#35bf28}+5.16\%}$
test_td3_speed[reduce-overhead-None] 80.9658ms 25.5824ms 39.0893 Ops/s 37.9015 Ops/s $\color{#35bf28}+3.13\%$
test_td3_speed[reduce-overhead-backward] 1.3524ms 1.2976ms 770.6482 Ops/s 704.8371 Ops/s $\textbf{\color{#35bf28}+9.34\%}$
test_cql_speed[False-None] 15.9407ms 15.5859ms 64.1605 Ops/s 62.2616 Ops/s $\color{#35bf28}+3.05\%$
test_cql_speed[False-backward] 21.2964ms 20.6891ms 48.3347 Ops/s 46.1714 Ops/s $\color{#35bf28}+4.69\%$
test_cql_speed[True-None] 2.9707ms 2.9048ms 344.2637 Ops/s 342.5655 Ops/s $\color{#35bf28}+0.50\%$
test_cql_speed[True-backward] 5.4977ms 5.0622ms 197.5430 Ops/s 197.5986 Ops/s $\color{#d91a1a}-0.03\%$
test_cql_speed[reduce-overhead-None] 21.6721ms 13.0131ms 76.8455 Ops/s 76.3403 Ops/s $\color{#35bf28}+0.66\%$
test_cql_speed[reduce-overhead-backward] 1.5358ms 1.4716ms 679.5473 Ops/s 609.5663 Ops/s $\textbf{\color{#35bf28}+11.48\%}$
test_a2c_speed[False-None] 3.1612ms 3.0975ms 322.8434 Ops/s 308.5590 Ops/s $\color{#35bf28}+4.63\%$
test_a2c_speed[False-backward] 6.5823ms 5.9482ms 168.1190 Ops/s 155.5340 Ops/s $\textbf{\color{#35bf28}+8.09\%}$
test_a2c_speed[True-None] 1.0626ms 0.9916ms 1.0085 KOps/s 938.1150 Ops/s $\textbf{\color{#35bf28}+7.50\%}$
test_a2c_speed[True-backward] 2.7408ms 2.6206ms 381.5986 Ops/s 354.1777 Ops/s $\textbf{\color{#35bf28}+7.74\%}$
test_a2c_speed[reduce-overhead-None] 0.3781s 12.3331ms 81.0826 Ops/s 90.6842 Ops/s $\textbf{\color{#d91a1a}-10.59\%}$
test_a2c_speed[reduce-overhead-backward] 1.0468ms 0.9916ms 1.0085 KOps/s 890.3716 Ops/s $\textbf{\color{#35bf28}+13.27\%}$
test_ppo_speed[False-None] 3.6639ms 3.5590ms 280.9751 Ops/s 270.1625 Ops/s $\color{#35bf28}+4.00\%$
test_ppo_speed[False-backward] 7.0787ms 6.6716ms 149.8882 Ops/s 140.6094 Ops/s $\textbf{\color{#35bf28}+6.60\%}$
test_ppo_speed[True-None] 1.0154ms 0.9415ms 1.0621 KOps/s 1.0480 KOps/s $\color{#35bf28}+1.35\%$
test_ppo_speed[True-backward] 2.6377ms 2.5738ms 388.5348 Ops/s 367.2762 Ops/s $\textbf{\color{#35bf28}+5.79\%}$
test_ppo_speed[reduce-overhead-None] 0.5559ms 0.4982ms 2.0071 KOps/s 1.8892 KOps/s $\textbf{\color{#35bf28}+6.24\%}$
test_ppo_speed[reduce-overhead-backward] 1.0167ms 0.9710ms 1.0299 KOps/s 887.3982 Ops/s $\textbf{\color{#35bf28}+16.05\%}$
test_reinforce_speed[False-None] 2.5059ms 2.1449ms 466.2177 Ops/s 449.5696 Ops/s $\color{#35bf28}+3.70\%$
test_reinforce_speed[False-backward] 3.5845ms 3.1308ms 319.4028 Ops/s 301.3104 Ops/s $\textbf{\color{#35bf28}+6.00\%}$
test_reinforce_speed[True-None] 0.8771ms 0.8304ms 1.2043 KOps/s 1.2067 KOps/s $\color{#d91a1a}-0.20\%$
test_reinforce_speed[True-backward] 2.4872ms 2.4188ms 413.4295 Ops/s 387.8387 Ops/s $\textbf{\color{#35bf28}+6.60\%}$
test_reinforce_speed[reduce-overhead-None] 22.5477ms 11.6799ms 85.6172 Ops/s 87.0814 Ops/s $\color{#d91a1a}-1.68\%$
test_reinforce_speed[reduce-overhead-backward] 1.0950ms 1.0562ms 946.7935 Ops/s 846.4540 Ops/s $\textbf{\color{#35bf28}+11.85\%}$
test_iql_speed[False-None] 9.3818ms 8.8516ms 112.9737 Ops/s 109.6916 Ops/s $\color{#35bf28}+2.99\%$
test_iql_speed[False-backward] 13.0629ms 12.4945ms 80.0355 Ops/s 76.3727 Ops/s $\color{#35bf28}+4.80\%$
test_iql_speed[True-None] 1.8475ms 1.7537ms 570.2196 Ops/s 580.4104 Ops/s $\color{#d91a1a}-1.76\%$
test_iql_speed[True-backward] 4.5172ms 4.2104ms 237.5069 Ops/s 234.7159 Ops/s $\color{#35bf28}+1.19\%$
test_iql_speed[reduce-overhead-None] 20.2014ms 11.5033ms 86.9318 Ops/s 87.8830 Ops/s $\color{#d91a1a}-1.08\%$
test_iql_speed[reduce-overhead-backward] 1.4643ms 1.4262ms 701.1723 Ops/s 638.6733 Ops/s $\textbf{\color{#35bf28}+9.79\%}$
test_rb_sample[TensorDictReplayBuffer-ListStorage-RandomSampler-4000] 7.8466ms 6.3452ms 157.6005 Ops/s 153.5551 Ops/s $\color{#35bf28}+2.63\%$
test_rb_sample[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-10000] 0.7243ms 0.3309ms 3.0218 KOps/s 2.8277 KOps/s $\textbf{\color{#35bf28}+6.87\%}$
test_rb_sample[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-10000] 0.4909ms 0.3050ms 3.2784 KOps/s 3.1391 KOps/s $\color{#35bf28}+4.44\%$
test_rb_sample[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-4000] 6.3206ms 6.1105ms 163.6533 Ops/s 160.7621 Ops/s $\color{#35bf28}+1.80\%$
test_rb_sample[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-10000] 1.7733ms 0.3000ms 3.3336 KOps/s 3.4880 KOps/s $\color{#d91a1a}-4.43\%$
test_rb_sample[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-10000] 0.6843ms 0.3198ms 3.1267 KOps/s 3.7002 KOps/s $\textbf{\color{#d91a1a}-15.50\%}$
test_rb_sample[TensorDictReplayBuffer-LazyMemmapStorage-sampler6-10000] 1.4900ms 1.2759ms 783.7619 Ops/s 788.4729 Ops/s $\color{#d91a1a}-0.60\%$
test_rb_sample[TensorDictReplayBuffer-LazyTensorStorage-sampler7-10000] 1.4577ms 1.2139ms 823.7999 Ops/s 819.9235 Ops/s $\color{#35bf28}+0.47\%$
test_rb_sample[TensorDictPrioritizedReplayBuffer-ListStorage-None-4000] 6.3784ms 6.2757ms 159.3456 Ops/s 156.9095 Ops/s $\color{#35bf28}+1.55\%$
test_rb_sample[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-10000] 2.1029ms 0.4720ms 2.1189 KOps/s 2.3883 KOps/s $\textbf{\color{#d91a1a}-11.28\%}$
test_rb_sample[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-10000] 0.6817ms 0.4311ms 2.3194 KOps/s 2.3062 KOps/s $\color{#35bf28}+0.57\%$
test_rb_iterate[TensorDictReplayBuffer-ListStorage-RandomSampler-4000] 6.2061ms 6.1347ms 163.0069 Ops/s 160.5075 Ops/s $\color{#35bf28}+1.56\%$
test_rb_iterate[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-10000] 1.7247ms 0.3176ms 3.1485 KOps/s 3.5624 KOps/s $\textbf{\color{#d91a1a}-11.62\%}$
test_rb_iterate[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-10000] 0.5289ms 0.3059ms 3.2691 KOps/s 3.2623 KOps/s $\color{#35bf28}+0.21\%$
test_rb_iterate[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-4000] 6.2871ms 6.0732ms 164.6569 Ops/s 163.2943 Ops/s $\color{#35bf28}+0.83\%$
test_rb_iterate[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-10000] 1.4764ms 0.3271ms 3.0573 KOps/s 3.0160 KOps/s $\color{#35bf28}+1.37\%$
test_rb_iterate[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-10000] 0.6133ms 0.2762ms 3.6205 KOps/s 4.0524 KOps/s $\textbf{\color{#d91a1a}-10.66\%}$
test_rb_iterate[TensorDictPrioritizedReplayBuffer-ListStorage-None-4000] 6.4244ms 6.2709ms 159.4664 Ops/s 156.1956 Ops/s $\color{#35bf28}+2.09\%$
test_rb_iterate[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-10000] 0.9614ms 0.4634ms 2.1582 KOps/s 2.1821 KOps/s $\color{#d91a1a}-1.10\%$
test_rb_iterate[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-10000] 0.6051ms 0.4008ms 2.4950 KOps/s 2.3206 KOps/s $\textbf{\color{#35bf28}+7.52\%}$
test_rb_populate[TensorDictReplayBuffer-ListStorage-RandomSampler-400] 6.8578ms 5.2756ms 189.5503 Ops/s 189.8020 Ops/s $\color{#d91a1a}-0.13\%$
test_rb_populate[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-400] 3.8291ms 1.8707ms 534.5708 Ops/s 441.6596 Ops/s $\textbf{\color{#35bf28}+21.04\%}$
test_rb_populate[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-400] 8.7270ms 1.2682ms 788.5381 Ops/s 798.2738 Ops/s $\color{#d91a1a}-1.22\%$
test_rb_populate[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-400] 0.4799s 14.8672ms 67.2622 Ops/s 191.3123 Ops/s $\textbf{\color{#d91a1a}-64.84\%}$
test_rb_populate[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-400] 8.4557ms 2.0506ms 487.6665 Ops/s 442.3109 Ops/s $\textbf{\color{#35bf28}+10.25\%}$
test_rb_populate[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-400] 7.0856ms 1.2614ms 792.7628 Ops/s 853.3933 Ops/s $\textbf{\color{#d91a1a}-7.10\%}$
test_rb_populate[TensorDictPrioritizedReplayBuffer-ListStorage-None-400] 7.2207ms 5.5778ms 179.2817 Ops/s 33.0670 Ops/s $\textbf{\color{#35bf28}+442.18\%}$
test_rb_populate[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-400] 11.0908ms 2.1934ms 455.9153 Ops/s 473.6861 Ops/s $\color{#d91a1a}-3.75\%$
test_rb_populate[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-400] 6.8966ms 1.3626ms 733.9160 Ops/s 733.3870 Ops/s $\color{#35bf28}+0.07\%$
test_rb_extend_sample[ReplayBuffer-LazyTensorStorage-RandomSampler-10000-10000-100-True] 13.8229ms 13.0810ms 76.4465 Ops/s 77.8330 Ops/s $\color{#d91a1a}-1.78\%$
test_rb_extend_sample[ReplayBuffer-LazyTensorStorage-RandomSampler-10000-10000-100-False] 22.3964ms 17.3172ms 57.7462 Ops/s 60.8135 Ops/s $\textbf{\color{#d91a1a}-5.04\%}$
test_rb_extend_sample[ReplayBuffer-LazyTensorStorage-RandomSampler-100000-10000-100-True] 18.2308ms 17.5276ms 57.0528 Ops/s 56.5752 Ops/s $\color{#35bf28}+0.84\%$
test_rb_extend_sample[ReplayBuffer-LazyTensorStorage-RandomSampler-100000-10000-100-False] 18.8464ms 17.1765ms 58.2190 Ops/s 60.0282 Ops/s $\color{#d91a1a}-3.01\%$
test_rb_extend_sample[ReplayBuffer-LazyTensorStorage-RandomSampler-1000000-10000-100-True] 17.7782ms 17.3316ms 57.6981 Ops/s 56.2257 Ops/s $\color{#35bf28}+2.62\%$
test_rb_extend_sample[ReplayBuffer-LazyTensorStorage-RandomSampler-1000000-10000-100-False] 18.4675ms 18.0360ms 55.4445 Ops/s 55.6277 Ops/s $\color{#d91a1a}-0.33\%$

@vmoens
Update
e10b734 
[ghstack-poisoned]
vmoens added a commit that referenced this pull request Nov 25, 2024
@vmoens
[BugFix] Fix imports
4a84844 
ghstack-source-id: faaecdd55abd5f7d93e59f30451e44690e4c64b9
Pull Request resolved: #2605
@vmoens
Update
3d18e51 
[ghstack-poisoned]
vmoens added a commit that referenced this pull request Nov 25, 2024
@vmoens
[BugFix] Fix imports
8094d97 
ghstack-source-id: db85f2611c1c0b22e9179b4fdd6c2dcea78ac8dd
Pull Request resolved: #2605
@vmoens vmoens added the bug Something isn't working label Nov 25, 2024
@vmoens vmoens merged commit 3d18e51 into gh/vmoens/49/base Nov 25, 2024
48 of 58 checks passed
@vmoens vmoens deleted the gh/vmoens/49/head branch November 25, 2024 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Something isn't working CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vmoens @facebook-github-bot