-
Notifications
You must be signed in to change notification settings - Fork 319
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BugFix] Fixes to RenameTransform #2442
Conversation
Hi @thomasbbrunner! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at [email protected]. Thanks! |
The tests are currently failing. Before I dive into them, could you take a look at the changes @vmoens and let me know if my assumptions are correct? |
Sure having a look now |
Thanks!
Currently clarifying this with my employer. Should not be a blocker, but could take a couple of days. |
Yes, it does! And thanks for the diagram. Really useful to understand.
IMO there's some room for improvement in the docstrings:
Can I suggest something along the lines of (unformatted):
This way it is clear:
Hope that this was helpful! |
Yeah sure feel free to add this to the PR |
Done! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM thanks
Description
Addresses some of the issues documented in #2441. These are:
in_keys
. Keys specified inin_keys_inv
don't lead to a change in the specs._inv
keys is different to the documented behavior.This MR does not target the remaining bug (Only the
full_action_spec
is modified in the transform, but not theaction_spec
.), as I'm not sure if this is a bug or intended behavior.Motivation and Context
close #2441
Types of changes
Checklist
Go over all the following points, and put an
x
in all the boxes that apply.If you are unsure about any of these, don't hesitate to ask. We are here to help!