Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] Remove and check for prints in codebase using flake8-print #1758

Merged
merged 4 commits into from
Jan 9, 2024
Merged

[Feature] Remove and check for prints in codebase using flake8-print #1758

merged 4 commits into from
Jan 9, 2024

Conversation

vmoens
Copy link
Contributor

@vmoens vmoens commented Dec 21, 2023

No description provided.

@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Dec 21, 2023 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/rl/1758

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (5 Unrelated Failures)

As of commit fb5d002 with merge base 6c68f7e (image):

FLAKY - The following jobs failed but were likely due to flakiness present on trunk:

BROKEN TRUNK - The following job failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Dec 21, 2023
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 21, 2023 •
edited
Loading

$\color{#D29922}\textsf{\Large⚠\kern{0.2cm}\normalsize Warning}$ Result of CPU Benchmark Tests

Total Benchmarks: 89. Improved: $\large\color{#35bf28}5$. Worsened: $\large\color{#d91a1a}3$.

Expand to view detailed results
Name Max Mean Ops Ops on Repo HEAD Change
test_single 66.1849ms 65.8556ms 15.1847 Ops/s 15.6013 Ops/s $\color{#d91a1a}-2.67\%$
test_sync 41.3124ms 34.5416ms 28.9506 Ops/s 25.5852 Ops/s $\textbf{\color{#35bf28}+13.15\%}$
test_async 0.1120s 33.8253ms 29.5637 Ops/s 29.2166 Ops/s $\color{#35bf28}+1.19\%$
test_simple 0.5024s 0.4522s 2.2115 Ops/s 2.2450 Ops/s $\color{#d91a1a}-1.49\%$
test_transformed 0.6728s 0.6231s 1.6049 Ops/s 1.6304 Ops/s $\color{#d91a1a}-1.56\%$
test_serial 1.4145s 1.4128s 0.7078 Ops/s 0.7170 Ops/s $\color{#d91a1a}-1.29\%$
test_parallel 1.4056s 1.3553s 0.7378 Ops/s 0.7353 Ops/s $\color{#35bf28}+0.34\%$
test_step_mdp_speed[True-True-True-True-True] 0.1399ms 21.5164μs 46.4763 KOps/s 45.4733 KOps/s $\color{#35bf28}+2.21\%$
test_step_mdp_speed[True-True-True-True-False] 37.4100μs 13.2007μs 75.7538 KOps/s 75.2657 KOps/s $\color{#35bf28}+0.65\%$
test_step_mdp_speed[True-True-True-False-True] 52.2680μs 12.6858μs 78.8286 KOps/s 77.8466 KOps/s $\color{#35bf28}+1.26\%$
test_step_mdp_speed[True-True-True-False-False] 28.2430μs 7.7360μs 129.2658 KOps/s 125.9378 KOps/s $\color{#35bf28}+2.64\%$
test_step_mdp_speed[True-True-False-True-True] 69.8980μs 22.8305μs 43.8011 KOps/s 43.4083 KOps/s $\color{#35bf28}+0.90\%$
test_step_mdp_speed[True-True-False-True-False] 38.8230μs 14.4022μs 69.4338 KOps/s 67.4550 KOps/s $\color{#35bf28}+2.93\%$
test_step_mdp_speed[True-True-False-False-True] 53.7400μs 14.0658μs 71.0946 KOps/s 70.6361 KOps/s $\color{#35bf28}+0.65\%$
test_step_mdp_speed[True-True-False-False-False] 50.0640μs 9.1144μs 109.7164 KOps/s 109.5003 KOps/s $\color{#35bf28}+0.20\%$
test_step_mdp_speed[True-False-True-True-True] 72.9260μs 24.5336μs 40.7604 KOps/s 40.3114 KOps/s $\color{#35bf28}+1.11\%$
test_step_mdp_speed[True-False-True-True-False] 40.4160μs 15.8883μs 62.9396 KOps/s 62.0550 KOps/s $\color{#35bf28}+1.43\%$
test_step_mdp_speed[True-False-True-False-True] 64.8700μs 14.0344μs 71.2533 KOps/s 70.3806 KOps/s $\color{#35bf28}+1.24\%$
test_step_mdp_speed[True-False-True-False-False] 53.5780μs 9.0826μs 110.1011 KOps/s 110.9523 KOps/s $\color{#d91a1a}-0.77\%$
test_step_mdp_speed[True-False-False-True-True] 67.0970μs 26.4957μs 37.7419 KOps/s 38.5065 KOps/s $\color{#d91a1a}-1.99\%$
test_step_mdp_speed[True-False-False-True-False] 56.0260μs 17.2532μs 57.9604 KOps/s 58.2698 KOps/s $\color{#d91a1a}-0.53\%$
test_step_mdp_speed[True-False-False-False-True] 51.1650μs 15.2157μs 65.7216 KOps/s 65.8411 KOps/s $\color{#d91a1a}-0.18\%$
test_step_mdp_speed[True-False-False-False-False] 51.5970μs 10.2089μs 97.9539 KOps/s 97.4868 KOps/s $\color{#35bf28}+0.48\%$
test_step_mdp_speed[False-True-True-True-True] 62.5870μs 24.3157μs 41.1257 KOps/s 40.9667 KOps/s $\color{#35bf28}+0.39\%$
test_step_mdp_speed[False-True-True-True-False] 56.5360μs 15.9539μs 62.6808 KOps/s 62.6217 KOps/s $\color{#35bf28}+0.09\%$
test_step_mdp_speed[False-True-True-False-True] 65.4910μs 16.2134μs 61.6773 KOps/s 60.8235 KOps/s $\color{#35bf28}+1.40\%$
test_step_mdp_speed[False-True-True-False-False] 28.4230μs 10.3423μs 96.6908 KOps/s 96.7154 KOps/s $\color{#d91a1a}-0.03\%$
test_step_mdp_speed[False-True-False-True-True] 75.6410μs 25.8545μs 38.6780 KOps/s 39.0337 KOps/s $\color{#d91a1a}-0.91\%$
test_step_mdp_speed[False-True-False-True-False] 39.9050μs 17.3711μs 57.5668 KOps/s 57.9293 KOps/s $\color{#d91a1a}-0.63\%$
test_step_mdp_speed[False-True-False-False-True] 66.5240μs 17.4359μs 57.3528 KOps/s 56.9474 KOps/s $\color{#35bf28}+0.71\%$
test_step_mdp_speed[False-True-False-False-False] 30.0960μs 11.5540μs 86.5499 KOps/s 86.0263 KOps/s $\color{#35bf28}+0.61\%$
test_step_mdp_speed[False-False-True-True-True] 70.4710μs 26.9397μs 37.1200 KOps/s 36.7839 KOps/s $\color{#35bf28}+0.91\%$
test_step_mdp_speed[False-False-True-True-False] 67.3540μs 18.5293μs 53.9687 KOps/s 53.3383 KOps/s $\color{#35bf28}+1.18\%$
test_step_mdp_speed[False-False-True-False-True] 42.4280μs 17.5046μs 57.1278 KOps/s 56.5991 KOps/s $\color{#35bf28}+0.93\%$
test_step_mdp_speed[False-False-True-False-False] 35.1360μs 11.5091μs 86.8881 KOps/s 86.0579 KOps/s $\color{#35bf28}+0.96\%$
test_step_mdp_speed[False-False-False-True-True] 71.4530μs 27.7394μs 36.0498 KOps/s 35.5481 KOps/s $\color{#35bf28}+1.41\%$
test_step_mdp_speed[False-False-False-True-False] 66.2240μs 19.4685μs 51.3650 KOps/s 50.7046 KOps/s $\color{#35bf28}+1.30\%$
test_step_mdp_speed[False-False-False-False-True] 41.6680μs 18.5997μs 53.7644 KOps/s 53.5527 KOps/s $\color{#35bf28}+0.40\%$
test_step_mdp_speed[False-False-False-False-False] 58.7990μs 12.5778μs 79.5051 KOps/s 78.4612 KOps/s $\color{#35bf28}+1.33\%$
test_values[generalized_advantage_estimate-True-True] 16.9422ms 12.1447ms 82.3403 Ops/s 82.6720 Ops/s $\color{#d91a1a}-0.40\%$
test_values[vec_generalized_advantage_estimate-True-True] 38.6034ms 27.7505ms 36.0354 Ops/s 35.3215 Ops/s $\color{#35bf28}+2.02\%$
test_values[td0_return_estimate-False-False] 0.2404ms 0.1773ms 5.6394 KOps/s 5.2750 KOps/s $\textbf{\color{#35bf28}+6.91\%}$
test_values[td1_return_estimate-False-False] 36.9084ms 25.6931ms 38.9210 Ops/s 38.2254 Ops/s $\color{#35bf28}+1.82\%$
test_values[vec_td1_return_estimate-False-False] 38.8037ms 28.0992ms 35.5882 Ops/s 33.1045 Ops/s $\textbf{\color{#35bf28}+7.50\%}$
test_values[td_lambda_return_estimate-True-False] 36.0340ms 35.4966ms 28.1717 Ops/s 27.5983 Ops/s $\color{#35bf28}+2.08\%$
test_values[vec_td_lambda_return_estimate-True-False] 36.0265ms 27.7553ms 36.0292 Ops/s 35.0911 Ops/s $\color{#35bf28}+2.67\%$
test_gae_speed[generalized_advantage_estimate-False-1-512] 8.7772ms 8.0495ms 124.2310 Ops/s 123.0947 Ops/s $\color{#35bf28}+0.92\%$
test_gae_speed[vec_generalized_advantage_estimate-True-1-512] 13.3185ms 1.9864ms 503.4180 Ops/s 563.0917 Ops/s $\textbf{\color{#d91a1a}-10.60\%}$
test_gae_speed[vec_generalized_advantage_estimate-False-1-512] 0.7318ms 0.4259ms 2.3479 KOps/s 2.3082 KOps/s $\color{#35bf28}+1.72\%$
test_gae_speed[vec_generalized_advantage_estimate-True-32-512] 49.8337ms 40.4772ms 24.7053 Ops/s 24.5866 Ops/s $\color{#35bf28}+0.48\%$
test_gae_speed[vec_generalized_advantage_estimate-False-32-512] 12.3260ms 2.6311ms 380.0684 Ops/s 377.4418 Ops/s $\color{#35bf28}+0.70\%$
test_dqn_speed 14.7241ms 7.8907ms 126.7310 Ops/s 117.8734 Ops/s $\textbf{\color{#35bf28}+7.51\%}$
test_ddpg_speed 25.8701ms 14.9732ms 66.7859 Ops/s 67.6446 Ops/s $\color{#d91a1a}-1.27\%$
test_sac_speed 38.2148ms 30.1243ms 33.1958 Ops/s 33.8461 Ops/s $\color{#d91a1a}-1.92\%$
test_redq_speed 0.1114s 38.9895ms 25.6479 Ops/s 27.9268 Ops/s $\textbf{\color{#d91a1a}-8.16\%}$
test_redq_deprec_speed 35.8666ms 25.9921ms 38.4733 Ops/s 39.0156 Ops/s $\color{#d91a1a}-1.39\%$
test_td3_speed 29.7815ms 20.7218ms 48.2585 Ops/s 49.1176 Ops/s $\color{#d91a1a}-1.75\%$
test_cql_speed 97.3470ms 89.8152ms 11.1340 Ops/s 11.1368 Ops/s $\color{#d91a1a}-0.03\%$
test_a2c_speed 38.3709ms 27.4606ms 36.4158 Ops/s 37.1409 Ops/s $\color{#d91a1a}-1.95\%$
test_ppo_speed 37.4418ms 27.7404ms 36.0486 Ops/s 36.8223 Ops/s $\color{#d91a1a}-2.10\%$
test_reinforce_speed 38.0421ms 26.5262ms 37.6986 Ops/s 38.1676 Ops/s $\color{#d91a1a}-1.23\%$
test_iql_speed 71.9743ms 64.3116ms 15.5493 Ops/s 15.6748 Ops/s $\color{#d91a1a}-0.80\%$
test_rb_sample[TensorDictReplayBuffer-ListStorage-RandomSampler-4000] 2.0733ms 1.4393ms 694.7984 Ops/s 680.7442 Ops/s $\color{#35bf28}+2.06\%$
test_rb_sample[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-10000] 8.8554ms 0.5329ms 1.8767 KOps/s 1.9295 KOps/s $\color{#d91a1a}-2.74\%$
test_rb_sample[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-10000] 9.0417ms 0.5152ms 1.9411 KOps/s 1.9622 KOps/s $\color{#d91a1a}-1.07\%$
test_rb_sample[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-4000] 2.4229ms 1.4659ms 682.1658 Ops/s 696.4862 Ops/s $\color{#d91a1a}-2.06\%$
test_rb_sample[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-10000] 12.0709ms 0.5246ms 1.9063 KOps/s 1.9136 KOps/s $\color{#d91a1a}-0.38\%$
test_rb_sample[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-10000] 0.7219ms 0.4998ms 2.0009 KOps/s 1.9752 KOps/s $\color{#35bf28}+1.30\%$
test_rb_sample[TensorDictPrioritizedReplayBuffer-ListStorage-None-4000] 3.2244ms 1.6191ms 617.6193 Ops/s 594.2656 Ops/s $\color{#35bf28}+3.93\%$
test_rb_sample[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-10000] 12.2441ms 0.6655ms 1.5027 KOps/s 1.5384 KOps/s $\color{#d91a1a}-2.32\%$
test_rb_sample[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-10000] 8.9342ms 0.6471ms 1.5454 KOps/s 1.5423 KOps/s $\color{#35bf28}+0.20\%$
test_rb_iterate[TensorDictReplayBuffer-ListStorage-RandomSampler-4000] 1.8328ms 1.4250ms 701.7466 Ops/s 677.8348 Ops/s $\color{#35bf28}+3.53\%$
test_rb_iterate[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-10000] 0.1273s 0.6640ms 1.5059 KOps/s 1.4385 KOps/s $\color{#35bf28}+4.69\%$
test_rb_iterate[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-10000] 12.2471ms 0.5156ms 1.9395 KOps/s 2.0013 KOps/s $\color{#d91a1a}-3.09\%$
test_rb_iterate[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-4000] 2.2793ms 1.4116ms 708.4305 Ops/s 695.4617 Ops/s $\color{#35bf28}+1.86\%$
test_rb_iterate[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-10000] 0.6233ms 0.5107ms 1.9583 KOps/s 1.9437 KOps/s $\color{#35bf28}+0.75\%$
test_rb_iterate[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-10000] 6.2571ms 0.5072ms 1.9715 KOps/s 1.9540 KOps/s $\color{#35bf28}+0.90\%$
test_rb_iterate[TensorDictPrioritizedReplayBuffer-ListStorage-None-4000] 2.1876ms 1.6116ms 620.4895 Ops/s 602.2105 Ops/s $\color{#35bf28}+3.04\%$
test_rb_iterate[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-10000] 12.1378ms 0.6714ms 1.4895 KOps/s 1.5309 KOps/s $\color{#d91a1a}-2.70\%$
test_rb_iterate[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-10000] 0.8475ms 0.6382ms 1.5670 KOps/s 1.5383 KOps/s $\color{#35bf28}+1.87\%$
test_rb_populate[TensorDictReplayBuffer-ListStorage-RandomSampler-400] 0.1208s 16.6432ms 60.0846 Ops/s 58.6317 Ops/s $\color{#35bf28}+2.48\%$
test_rb_populate[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-400] 15.5764ms 12.2289ms 81.7733 Ops/s 81.6811 Ops/s $\color{#35bf28}+0.11\%$
test_rb_populate[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-400] 4.9760ms 1.5436ms 647.8426 Ops/s 581.4120 Ops/s $\textbf{\color{#35bf28}+11.43\%}$
test_rb_populate[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-400] 0.1083s 16.2757ms 61.4413 Ops/s 60.0275 Ops/s $\color{#35bf28}+2.36\%$
test_rb_populate[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-400] 14.6007ms 12.2090ms 81.9070 Ops/s 80.0852 Ops/s $\color{#35bf28}+2.27\%$
test_rb_populate[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-400] 13.0717ms 1.7401ms 574.6799 Ops/s 646.1852 Ops/s $\textbf{\color{#d91a1a}-11.07\%}$
test_rb_populate[TensorDictPrioritizedReplayBuffer-ListStorage-None-400] 0.1103s 16.4506ms 60.7880 Ops/s 59.4219 Ops/s $\color{#35bf28}+2.30\%$
test_rb_populate[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-400] 21.0438ms 12.5762ms 79.5152 Ops/s 79.8196 Ops/s $\color{#d91a1a}-0.38\%$
test_rb_populate[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-400] 2.3094ms 1.6790ms 595.5752 Ops/s 570.1027 Ops/s $\color{#35bf28}+4.47\%$

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 21, 2023 •
edited
Loading

$\color{#D29922}\textsf{\Large⚠\kern{0.2cm}\normalsize Warning}$ Result of GPU Benchmark Tests

Total Benchmarks: 92. Improved: $\large\color{#35bf28}3$. Worsened: $\large\color{#d91a1a}2$.

Expand to view detailed results
Name Max Mean Ops Ops on Repo HEAD Change
test_single 0.1286s 0.1245s 8.0341 Ops/s 7.9996 Ops/s $\color{#35bf28}+0.43\%$
test_sync 0.1795s 0.1102s 9.0778 Ops/s 9.0390 Ops/s $\color{#35bf28}+0.43\%$
test_async 0.2796s 0.1013s 9.8717 Ops/s 9.9105 Ops/s $\color{#d91a1a}-0.39\%$
test_single_pixels 0.1474s 0.1466s 6.8191 Ops/s 6.7484 Ops/s $\color{#35bf28}+1.05\%$
test_sync_pixels 96.2503ms 94.9972ms 10.5266 Ops/s 10.4168 Ops/s $\color{#35bf28}+1.05\%$
test_async_pixels 0.2476s 91.0950ms 10.9775 Ops/s 11.0153 Ops/s $\color{#d91a1a}-0.34\%$
test_simple 0.9783s 0.9257s 1.0803 Ops/s 1.0863 Ops/s $\color{#d91a1a}-0.55\%$
test_transformed 1.2355s 1.1813s 0.8465 Ops/s 0.8559 Ops/s $\color{#d91a1a}-1.09\%$
test_serial 2.6069s 2.5747s 0.3884 Ops/s 0.3824 Ops/s $\color{#35bf28}+1.56\%$
test_parallel 2.5692s 2.4968s 0.4005 Ops/s 0.3981 Ops/s $\color{#35bf28}+0.60\%$
test_step_mdp_speed[True-True-True-True-True] 87.5210μs 33.0735μs 30.2357 KOps/s 29.6862 KOps/s $\color{#35bf28}+1.85\%$
test_step_mdp_speed[True-True-True-True-False] 39.7310μs 19.6547μs 50.8785 KOps/s 50.7058 KOps/s $\color{#35bf28}+0.34\%$
test_step_mdp_speed[True-True-True-False-True] 39.0710μs 19.0938μs 52.3730 KOps/s 51.9205 KOps/s $\color{#35bf28}+0.87\%$
test_step_mdp_speed[True-True-True-False-False] 32.3100μs 11.2601μs 88.8090 KOps/s 87.9952 KOps/s $\color{#35bf28}+0.92\%$
test_step_mdp_speed[True-True-False-True-True] 69.9710μs 35.1878μs 28.4190 KOps/s 28.1580 KOps/s $\color{#35bf28}+0.93\%$
test_step_mdp_speed[True-True-False-True-False] 41.7910μs 21.5309μs 46.4448 KOps/s 45.4167 KOps/s $\color{#35bf28}+2.26\%$
test_step_mdp_speed[True-True-False-False-True] 52.9510μs 21.1198μs 47.3489 KOps/s 47.6598 KOps/s $\color{#d91a1a}-0.65\%$
test_step_mdp_speed[True-True-False-False-False] 33.1800μs 13.1580μs 75.9992 KOps/s 75.3630 KOps/s $\color{#35bf28}+0.84\%$
test_step_mdp_speed[True-False-True-True-True] 94.0110μs 37.2686μs 26.8323 KOps/s 27.1008 KOps/s $\color{#d91a1a}-0.99\%$
test_step_mdp_speed[True-False-True-True-False] 66.4210μs 23.8702μs 41.8932 KOps/s 42.3082 KOps/s $\color{#d91a1a}-0.98\%$
test_step_mdp_speed[True-False-True-False-True] 46.2310μs 20.9690μs 47.6895 KOps/s 47.2562 KOps/s $\color{#35bf28}+0.92\%$
test_step_mdp_speed[True-False-True-False-False] 27.4000μs 13.1498μs 76.0465 KOps/s 74.7829 KOps/s $\color{#35bf28}+1.69\%$
test_step_mdp_speed[True-False-False-True-True] 64.1210μs 38.2845μs 26.1202 KOps/s 25.8326 KOps/s $\color{#35bf28}+1.11\%$
test_step_mdp_speed[True-False-False-True-False] 52.2410μs 25.1360μs 39.7836 KOps/s 39.4565 KOps/s $\color{#35bf28}+0.83\%$
test_step_mdp_speed[True-False-False-False-True] 42.4400μs 22.5709μs 44.3048 KOps/s 43.0162 KOps/s $\color{#35bf28}+3.00\%$
test_step_mdp_speed[True-False-False-False-False] 50.1110μs 14.9533μs 66.8748 KOps/s 66.0390 KOps/s $\color{#35bf28}+1.27\%$
test_step_mdp_speed[False-True-True-True-True] 65.7110μs 37.3484μs 26.7749 KOps/s 27.0781 KOps/s $\color{#d91a1a}-1.12\%$
test_step_mdp_speed[False-True-True-True-False] 74.2110μs 23.5204μs 42.5162 KOps/s 42.0868 KOps/s $\color{#35bf28}+1.02\%$
test_step_mdp_speed[False-True-True-False-True] 48.0400μs 25.3040μs 39.5195 KOps/s 40.0712 KOps/s $\color{#d91a1a}-1.38\%$
test_step_mdp_speed[False-True-True-False-False] 32.6200μs 14.9704μs 66.7985 KOps/s 67.0363 KOps/s $\color{#d91a1a}-0.35\%$
test_step_mdp_speed[False-True-False-True-True] 80.8110μs 38.9583μs 25.6685 KOps/s 25.7040 KOps/s $\color{#d91a1a}-0.14\%$
test_step_mdp_speed[False-True-False-True-False] 51.7710μs 25.3819μs 39.3981 KOps/s 38.9213 KOps/s $\color{#35bf28}+1.23\%$
test_step_mdp_speed[False-True-False-False-True] 62.3610μs 27.0310μs 36.9946 KOps/s 37.5786 KOps/s $\color{#d91a1a}-1.55\%$
test_step_mdp_speed[False-True-False-False-False] 36.0110μs 16.7775μs 59.6035 KOps/s 59.6316 KOps/s $\color{#d91a1a}-0.05\%$
test_step_mdp_speed[False-False-True-True-True] 69.0610μs 41.0156μs 24.3810 KOps/s 24.7018 KOps/s $\color{#d91a1a}-1.30\%$
test_step_mdp_speed[False-False-True-True-False] 42.8700μs 27.2888μs 36.6451 KOps/s 36.8374 KOps/s $\color{#d91a1a}-0.52\%$
test_step_mdp_speed[False-False-True-False-True] 78.2110μs 26.6586μs 37.5114 KOps/s 38.0028 KOps/s $\color{#d91a1a}-1.29\%$
test_step_mdp_speed[False-False-True-False-False] 32.9000μs 16.7060μs 59.8587 KOps/s 59.1913 KOps/s $\color{#35bf28}+1.13\%$
test_step_mdp_speed[False-False-False-True-True] 0.2461ms 42.2625μs 23.6616 KOps/s 23.8581 KOps/s $\color{#d91a1a}-0.82\%$
test_step_mdp_speed[False-False-False-True-False] 53.3100μs 29.1638μs 34.2891 KOps/s 34.4057 KOps/s $\color{#d91a1a}-0.34\%$
test_step_mdp_speed[False-False-False-False-True] 47.9700μs 28.0537μs 35.6460 KOps/s 35.5884 KOps/s $\color{#35bf28}+0.16\%$
test_step_mdp_speed[False-False-False-False-False] 47.2810μs 18.7677μs 53.2831 KOps/s 53.8605 KOps/s $\color{#d91a1a}-1.07\%$
test_values[generalized_advantage_estimate-True-True] 25.3561ms 25.0319ms 39.9490 Ops/s 39.2293 Ops/s $\color{#35bf28}+1.83\%$
test_values[vec_generalized_advantage_estimate-True-True] 84.6009ms 3.2585ms 306.8916 Ops/s 307.6095 Ops/s $\color{#d91a1a}-0.23\%$
test_values[td0_return_estimate-False-False] 96.2810μs 63.1441μs 15.8368 KOps/s 15.5154 KOps/s $\color{#35bf28}+2.07\%$
test_values[td1_return_estimate-False-False] 53.9916ms 53.7177ms 18.6158 Ops/s 18.2335 Ops/s $\color{#35bf28}+2.10\%$
test_values[vec_td1_return_estimate-False-False] 2.0048ms 1.7662ms 566.1941 Ops/s 563.6287 Ops/s $\color{#35bf28}+0.46\%$
test_values[td_lambda_return_estimate-True-False] 86.9984ms 85.0556ms 11.7570 Ops/s 11.2797 Ops/s $\color{#35bf28}+4.23\%$
test_values[vec_td_lambda_return_estimate-True-False] 2.0941ms 1.7639ms 566.9293 Ops/s 563.4309 Ops/s $\color{#35bf28}+0.62\%$
test_gae_speed[generalized_advantage_estimate-False-1-512] 23.8631ms 23.6885ms 42.2146 Ops/s 41.4297 Ops/s $\color{#35bf28}+1.89\%$
test_gae_speed[vec_generalized_advantage_estimate-True-1-512] 0.8364ms 0.7057ms 1.4170 KOps/s 1.3997 KOps/s $\color{#35bf28}+1.24\%$
test_gae_speed[vec_generalized_advantage_estimate-False-1-512] 0.7123ms 0.6566ms 1.5230 KOps/s 1.4952 KOps/s $\color{#35bf28}+1.86\%$
test_gae_speed[vec_generalized_advantage_estimate-True-32-512] 1.5025ms 1.4598ms 685.0035 Ops/s 678.8498 Ops/s $\color{#35bf28}+0.91\%$
test_gae_speed[vec_generalized_advantage_estimate-False-32-512] 0.9230ms 0.6773ms 1.4765 KOps/s 1.4543 KOps/s $\color{#35bf28}+1.52\%$
test_dqn_speed 13.8650ms 7.3871ms 135.3712 Ops/s 134.0804 Ops/s $\color{#35bf28}+0.96\%$
test_ddpg_speed 15.0967ms 14.2123ms 70.3617 Ops/s 67.3481 Ops/s $\color{#35bf28}+4.47\%$
test_sac_speed 30.1043ms 29.1829ms 34.2667 Ops/s 33.4965 Ops/s $\color{#35bf28}+2.30\%$
test_redq_speed 35.9968ms 34.9486ms 28.6134 Ops/s 26.0377 Ops/s $\textbf{\color{#35bf28}+9.89\%}$
test_redq_deprec_speed 25.1456ms 24.0918ms 41.5079 Ops/s 40.9537 Ops/s $\color{#35bf28}+1.35\%$
test_td3_speed 28.7760ms 19.8942ms 50.2659 Ops/s 49.7300 Ops/s $\color{#35bf28}+1.08\%$
test_cql_speed 84.7198ms 83.2880ms 12.0065 Ops/s 11.8797 Ops/s $\color{#35bf28}+1.07\%$
test_a2c_speed 0.1254s 29.1231ms 34.3370 Ops/s 33.7553 Ops/s $\color{#35bf28}+1.72\%$
test_ppo_speed 27.7343ms 26.8539ms 37.2386 Ops/s 36.8081 Ops/s $\color{#35bf28}+1.17\%$
test_reinforce_speed 26.6949ms 25.7817ms 38.7873 Ops/s 38.3416 Ops/s $\color{#35bf28}+1.16\%$
test_iql_speed 58.2959ms 57.3996ms 17.4217 Ops/s 17.2224 Ops/s $\color{#35bf28}+1.16\%$
test_rb_sample[TensorDictReplayBuffer-ListStorage-RandomSampler-4000] 2.5846ms 1.9496ms 512.9331 Ops/s 457.7108 Ops/s $\textbf{\color{#35bf28}+12.06\%}$
test_rb_sample[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-10000] 2.1311ms 0.8391ms 1.1917 KOps/s 1.1863 KOps/s $\color{#35bf28}+0.46\%$
test_rb_sample[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-10000] 1.0469ms 0.8255ms 1.2114 KOps/s 1.2030 KOps/s $\color{#35bf28}+0.70\%$
test_rb_sample[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-4000] 2.4342ms 1.9166ms 521.7647 Ops/s 514.4680 Ops/s $\color{#35bf28}+1.42\%$
test_rb_sample[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-10000] 1.1161ms 0.8277ms 1.2081 KOps/s 1.2058 KOps/s $\color{#35bf28}+0.19\%$
test_rb_sample[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-10000] 4.9518ms 0.8205ms 1.2188 KOps/s 1.2139 KOps/s $\color{#35bf28}+0.40\%$
test_rb_sample[TensorDictPrioritizedReplayBuffer-ListStorage-None-4000] 2.8840ms 2.2065ms 453.1991 Ops/s 451.1456 Ops/s $\color{#35bf28}+0.46\%$
test_rb_sample[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-10000] 3.4297ms 0.9569ms 1.0450 KOps/s 1.0384 KOps/s $\color{#35bf28}+0.64\%$
test_rb_sample[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-10000] 1.1146ms 0.9459ms 1.0572 KOps/s 1.0443 KOps/s $\color{#35bf28}+1.23\%$
test_rb_iterate[TensorDictReplayBuffer-ListStorage-RandomSampler-4000] 2.6374ms 1.9330ms 517.3242 Ops/s 508.5711 Ops/s $\color{#35bf28}+1.72\%$
test_rb_iterate[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-10000] 0.9543ms 0.8382ms 1.1930 KOps/s 1.1892 KOps/s $\color{#35bf28}+0.32\%$
test_rb_iterate[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-10000] 5.0134ms 0.8316ms 1.2025 KOps/s 1.2012 KOps/s $\color{#35bf28}+0.11\%$
test_rb_iterate[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-4000] 2.0455ms 1.9224ms 520.1739 Ops/s 514.0743 Ops/s $\color{#35bf28}+1.19\%$
test_rb_iterate[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-10000] 2.1040ms 0.8293ms 1.2058 KOps/s 1.2005 KOps/s $\color{#35bf28}+0.44\%$
test_rb_iterate[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-10000] 0.9517ms 0.8170ms 1.2240 KOps/s 1.2162 KOps/s $\color{#35bf28}+0.65\%$
test_rb_iterate[TensorDictPrioritizedReplayBuffer-ListStorage-None-4000] 0.1342s 2.4990ms 400.1535 Ops/s 446.6745 Ops/s $\textbf{\color{#d91a1a}-10.41\%}$
test_rb_iterate[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-10000] 3.4656ms 0.9573ms 1.0446 KOps/s 861.4700 Ops/s $\textbf{\color{#35bf28}+21.25\%}$
test_rb_iterate[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-10000] 1.1156ms 0.9466ms 1.0564 KOps/s 1.0483 KOps/s $\color{#35bf28}+0.77\%$
test_rb_populate[TensorDictReplayBuffer-ListStorage-RandomSampler-400] 0.1691s 16.1760ms 61.8198 Ops/s 65.5554 Ops/s $\textbf{\color{#d91a1a}-5.70\%}$
test_rb_populate[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-400] 0.1244s 14.7283ms 67.8966 Ops/s 66.2112 Ops/s $\color{#35bf28}+2.55\%$
test_rb_populate[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-400] 5.5934ms 1.9371ms 516.2272 Ops/s 516.1463 Ops/s $\color{#35bf28}+0.02\%$
test_rb_populate[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-400] 0.1229s 15.2516ms 65.5667 Ops/s 65.6426 Ops/s $\color{#d91a1a}-0.12\%$
test_rb_populate[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-400] 15.5801ms 12.4589ms 80.2638 Ops/s 77.9461 Ops/s $\color{#35bf28}+2.97\%$
test_rb_populate[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-400] 5.8395ms 1.9215ms 520.4282 Ops/s 519.8274 Ops/s $\color{#35bf28}+0.12\%$
test_rb_populate[TensorDictPrioritizedReplayBuffer-ListStorage-None-400] 0.1232s 17.6274ms 56.7300 Ops/s 56.6306 Ops/s $\color{#35bf28}+0.18\%$
test_rb_populate[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-400] 15.8811ms 12.6172ms 79.2566 Ops/s 77.2157 Ops/s $\color{#35bf28}+2.64\%$
test_rb_populate[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-400] 5.9559ms 2.0640ms 484.4879 Ops/s 498.3188 Ops/s $\color{#d91a1a}-2.78\%$

@vmoens vmoens added the enhancement New feature or request label Jan 9, 2024
vmoens added 2 commits January 9, 2024 20:23
@vmoens
Merge branch 'main' into fix-prints
c100909 
# Conflicts:
#	torchrl/data/datasets/minari_data.py
@vmoens
amend
fb5d002
@vmoens vmoens marked this pull request as ready for review January 9, 2024 21:31
@vmoens vmoens merged commit 5b3dd98 into main Jan 9, 2024
58 of 63 checks passed
@vmoens vmoens deleted the fix-prints branch February 27, 2024 00:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vmoens @facebook-github-bot