Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Added pred-continue and collector-mask for dreamer #1704

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

FrankTianTT
Copy link
Contributor

@FrankTianTT FrankTianTT commented Nov 19, 2023

Description

Added optional pred-continue function like https://github.com/danijar/dreamer/blob/master/dreamer.py#L187C32-L187C32, and using collector-mask to remove empty data.

Motivation and Context

To make sure dreamer can work on early-stop env.

  • I have raised an issue to propose this change (required for new features and bug fixes)

Types of changes

What types of changes does your code introduce? Remove all that do not apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds core functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (update in the documentation)
  • Example (update in the folder of examples)

Checklist

Go over all the following points, and put an x in all the boxes that apply.
If you are unsure about any of these, don't hesitate to ask. We are here to help!

  • I have read the CONTRIBUTION guide (required)
  • My change requires a change to the documentation.
  • I have updated the tests accordingly (required for a bug fix or a new feature).
  • I have updated the documentation accordingly.

Copy link

pytorch-bot bot commented Nov 19, 2023

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/rl/1704

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (17 Unrelated Failures)

As of commit b5a4a88 with merge base 44bd026 (image):

FLAKY - The following jobs failed but were likely due to flakiness present on trunk:

BROKEN TRUNK - The following job failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Nov 19, 2023
@FrankTianTT FrankTianTT changed the title add pred-continue and collector-mask add pred-continue and collector-mask Nov 19, 2023
@FrankTianTT FrankTianTT marked this pull request as draft November 19, 2023 04:08
@FrankTianTT FrankTianTT changed the title add pred-continue and collector-mask [WIP] Added pred-continue and collector-mask Nov 19, 2023
@FrankTianTT FrankTianTT changed the title [WIP] Added pred-continue and collector-mask [WIP] Added pred-continue and collector-mask for dreamer Nov 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants