Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BugFix] make cursor a torch.long tensor #1639

Merged
merged 9 commits into from
Oct 23, 2023
Merged

[BugFix] make cursor a torch.long tensor #1639

Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
9164818
Added TQC implementation (initial commit)
maxweissenbacher Oct 17, 2023
a46ccd2
Use .get method to access tensordict elements
maxweissenbacher Oct 19, 2023
007a0c8
Changed actor_loss comp to make compatible with arbitrary batch sizes
maxweissenbacher Oct 19, 2023
6539618
Removed unnecessary copying on tensordict; since it is being modified…
maxweissenbacher Oct 19, 2023
8d80600
Made quantile huber loss compatible with arbitrary batch sizes
maxweissenbacher Oct 20, 2023
b8f147e
Forgot one tensordict.get ...
maxweissenbacher Oct 20, 2023
d5272b4
Restructed TQCLoss; different losses are computed in separate methods
maxweissenbacher Oct 20, 2023
204baff
init
vmoens Oct 23, 2023
faade6f
amend
vmoens Oct 23, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion torchrl/data/replay_buffers/storages.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -340,7 +340,9 @@ def set( # noqa: F811
self._init(data)
if not isinstance(cursor, (*INT_CLASSES, slice)):
if not isinstance(cursor, torch.Tensor):
cursor = torch.tensor(cursor)
cursor = torch.tensor(cursor, dtype=torch.long)
elif cursor.dtype != torch.long:
cursor = cursor.to(dtype=torch.long)
if len(cursor) > len(self._storage):
warnings.warn(
"A cursor of length superior to the storage capacity was provided. "
Expand Down
Loading