Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Algorithm] IMPALA and VTrace module #1506

Merged
merged 118 commits into from
Nov 23, 2023
Merged

[Algorithm] IMPALA and VTrace module #1506

merged 118 commits into from
Nov 23, 2023

Conversation

albertbou92
Copy link
Contributor

Description

This PR adds a VTrace module to be able to run IMPALA (https://arxiv.org/abs/1802.01561)

Motivation and Context

Why is this change required? What problem does it solve?
If it fixes an open issue, please link to the issue here.
You can use the syntax close #15213 if this solves the issue #15213

  • I have raised an issue to propose this change (required for new features and bug fixes)

Types of changes

What types of changes does your code introduce? Remove all that do not apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds core functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (update in the documentation)
  • Example (update in the folder of examples)

Checklist

Go over all the following points, and put an x in all the boxes that apply.
If you are unsure about any of these, don't hesitate to ask. We are here to help!

  • I have read the CONTRIBUTION guide (required)
  • My change requires a change to the documentation.
  • I have updated the tests accordingly (required for a bug fix or a new feature).
  • I have updated the documentation accordingly.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 7, 2023
torchrl/objectives/value/vtrace.py Outdated Show resolved Hide resolved
torchrl/objectives/value/vtrace.py Outdated Show resolved Hide resolved
torchrl/objectives/value/vtrace.py Outdated Show resolved Hide resolved
torchrl/objectives/value/vtrace.py Outdated Show resolved Hide resolved
torchrl/objectives/value/vtrace.py Outdated Show resolved Hide resolved
torchrl/objectives/value/vtrace.py Outdated Show resolved Hide resolved
torchrl/objectives/value/vtrace.py Outdated Show resolved Hide resolved
torchrl/objectives/value/vtrace.py Outdated Show resolved Hide resolved
examples/impala/impala.py Outdated Show resolved Hide resolved
examples/impala/config.yaml Outdated Show resolved Hide resolved
@vmoens vmoens added the new algo New algorithm request or PR label Sep 7, 2023
@albertbou92 albertbou92 requested a review from vmoens November 23, 2023 11:47
Copy link
Contributor

@vmoens vmoens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, can you edit the unused args?

def forward(
self,
tensordict: TensorDictBase,
*unused_args,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see them appearing after that, so I would suggest to do

    def forward(
        self,
        tensordict: TensorDictBase,
        *, ...

for this and for GAE.

@albertbou92 albertbou92 requested a review from vmoens November 23, 2023 20:31
@vmoens vmoens merged commit b38d4b7 into pytorch:main Nov 23, 2023
52 of 60 checks passed
@vmoens vmoens deleted the vtrace branch November 23, 2023 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. new algo New algorithm request or PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants