Skip to content
Continuous Benchmark

[Performance] Faster PrioritizedSliceSampler._padded_indices (#2433) #6694

Sign in to view logs

[Performance] Faster PrioritizedSliceSampler._padded_indices (#2433)

[Performance] Faster PrioritizedSliceSampler._padded_indices (#2433) #6694

Triggered via push September 12, 2024 07:58
@vmoensvmoens
pushed 361b763
main
Status Failure
Total duration 9m 18s
Artifacts –

benchmarks.yml

on: push
CPU Pytest benchmark
6m 33s
CPU Pytest benchmark
GPU Pytest benchmark
9m 4s
GPU Pytest benchmark
Fit to window
Zoom out
Zoom in

Annotations

3 errors and 3 warnings
GPU Pytest benchmark
WARNING: Running pip as the 'root' user can result in broken permissions and conflicting behaviour with the system package manager. It is recommended to use a virtual environment instead: https://pip.pypa.io/warnings/venv
GPU Pytest benchmark
WARNING: The directory '/github/home/.cache/pip' or its parent directory is not owned or is not writable by the current user. The cache has been disabled. Check the permissions and owner of that directory. If executing pip with sudo, you should use sudo's -H flag.
GPU Pytest benchmark
# :warning: **Performance Alert** :warning: Possible performance regression was detected for benchmark **'GPU Benchmark Results'**. Benchmark result of this commit is worse than the previous benchmark result exceeding threshold `2`. | Benchmark suite | Current: 361b763e54d9d647add5ac3a5b95a83939ce69ac | Previous: fb9cc2c7b88882ac2f82b5f43031ec459fb9f6b7 | Ratio | |-|-|-|-| | `benchmarks/test_replaybuffer_benchmark.py::test_rb_iterate[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-10000]` | `2094.0166244139073` iter/sec (`stddev: 0.00456845021246647`) | `4283.956237897829` iter/sec (`stddev: 0.000022894003609446883`) | `2.05` | This comment was automatically generated by [workflow](https://github.com/pytorch/rl/actions?query=workflow%3AContinuous%20Benchmark) using [github-action-benchmark](https://github.com/marketplace/actions/continuous-benchmark). CC: @vmoens Comment was generated at https://github.com/pytorch/rl/commit/361b763e54d9d647add5ac3a5b95a83939ce69ac#commitcomment-146603887
CPU Pytest benchmark
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v3, actions/setup-python@v4. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
GPU Pytest benchmark
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, actions/setup-python@v4. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
GPU Pytest benchmark
Performance alert! Previous value was 4283.956237897829 and current value is 2094.0166244139073. It is 2.045808131583894x worse than previous exceeding a ratio threshold 2