-
Notifications
You must be signed in to change notification settings - Fork 23.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DataPipe] adding serialization test for all core IterDataPipes #71456
Conversation
[ghstack-poisoned]
CI Flow Status⚛️ CI FlowRuleset - Version:
You can add a comment to the PR and tag @pytorchbot with the following commands: # ciflow rerun, "ciflow/default" will always be added automatically
@pytorchbot ciflow rerun
# ciflow rerun with additional labels "-l <ciflow/label_name>", which is equivalent to adding these labels manually and trigger the rerun
@pytorchbot ciflow rerun -l ciflow/scheduled -l ciflow/slow For more information, please take a look at the CI Flow Wiki. |
🔗 Helpful links
💊 CI failures summary and remediationsAs of commit 7d28578 (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Please report bugs/suggestions to the (internal) Dr. CI Users group. |
…Pipes" cc @VitalyFedyunin ejguan @NivekT [ghstack-poisoned]
@NivekT has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. Could you add another test to validate during/after one iteration, the Datapipe is still picklable?
Yea, let me add that in a separate PR later. I'm going to take a closer look at |
Summary: Pull Request resolved: #71456 Related to pytorch/data#172 cc VitalyFedyunin ejguan NivekT Test Plan: Imported from OSS Reviewed By: zou3519 Differential Revision: D33668748 Pulled By: NivekT fbshipit-source-id: ea2085d5ed47533ca49258cc52471373c6ae1847
Summary: Pull Request resolved: pytorch/pytorch#71456 Related to pytorch/data#172 cc VitalyFedyunin ejguan NivekT Test Plan: Imported from OSS Reviewed By: zou3519 Differential Revision: D33668748 Pulled By: NivekT fbshipit-source-id: ea2085d5ed47533ca49258cc52471373c6ae1847 (cherry picked from commit d5f6fde)
Summary: Pull Request resolved: pytorch/pytorch#71456 Related to pytorch/data#172 cc VitalyFedyunin ejguan NivekT Test Plan: Imported from OSS Reviewed By: zou3519 Differential Revision: D33668748 Pulled By: NivekT fbshipit-source-id: ea2085d5ed47533ca49258cc52471373c6ae1847 (cherry picked from commit d5f6fde)
Summary: Pull Request resolved: pytorch/pytorch#71456 Related to pytorch/data#172 cc VitalyFedyunin ejguan NivekT Test Plan: Imported from OSS Reviewed By: zou3519 Differential Revision: D33668748 Pulled By: NivekT fbshipit-source-id: ea2085d5ed47533ca49258cc52471373c6ae1847 (cherry picked from commit d5f6fde)
Summary: Pull Request resolved: pytorch/pytorch#71456 Related to pytorch/data#172 cc VitalyFedyunin ejguan NivekT Test Plan: Imported from OSS Reviewed By: zou3519 Differential Revision: D33668748 Pulled By: NivekT fbshipit-source-id: ea2085d5ed47533ca49258cc52471373c6ae1847 (cherry picked from commit d5f6fde)
Stack from ghstack:
Related to pytorch/data#172
cc @VitalyFedyunin @ejguan @NivekT
Differential Revision: D33668748