[pt2] add SymInt support for bilinear
#103396
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/103396
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 9f6a7d3: This comment was automatically generated by Dr. CI and updates every 15 minutes. |
nkaretnikov
added a commit
that referenced
this pull request
Jun 11, 2023
ghstack-source-id: c3e9708e6fe8b41d4de3b5b5ace3ef0129d0f8f8 Pull Request resolved: #103396
nkaretnikov
added
ciflow/trunk
nkaretnikov
commented
Jun 11, 2023
| if (sumdim[i] && (i != unroll_dim)) | ||
| sum_dims_23.push_back(i); | ||
| } | ||
| output_size.push_back(sumdim[i] ? 1 : s); | ||
| if (i == unroll_dim) | ||
| unroll_size = s; | ||
| unroll_size = s.guard_int(__FILE__, __LINE__); |
There was a problem hiding this comment.
used later with irange
nkaretnikov
commented
Jun 11, 2023
| @@ -626,45 +626,45 @@ Tensor _trilinear(const Tensor& i1_, const Tensor& i2_, const Tensor& i3_, | |||
| Tensor i1 = i1_; | |||
There was a problem hiding this comment.
called from bilinear
ezyang
approved these changes
Jun 12, 2023
Skylion007
reviewed
Jun 13, 2023
| @@ -626,45 +626,45 @@ Tensor _trilinear(const Tensor& i1_, const Tensor& i2_, const Tensor& i3_, | |||
| Tensor i1 = i1_; | |||
| Tensor i2 = i2_; | |||
| Tensor i3 = i3_; | |||
| std::vector<int64_t> output_size; | |||
| std::vector<c10::SymInt> output_size; | |||
There was a problem hiding this comment.
nit: can't you reserve the size of this vector as total_dim?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
SymIntsupport forcosine_similarity#103400SymIntsupport forbilinear#103396avg_pool3dandavg_pool3d_backward#103392