-
Notifications
You must be signed in to change notification settings - Fork 22.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
General policy for supported Python version #74203
Comments
we should do whatever numpy does |
It's convenient if the build of PyTorch on Google Colab is one of the official ones. Historically, Colab has been much faster at taking new PyTorch versions than new Python versions. I'm not sure if that's a good thing, but if PyTorch copied numpy that could force a slowdown. For example, Colab is still on Python 3.7, and it's not clear how long that will stay true. Under NEP 29, Colab wouldn't have a build of PyTorch 1.11 now to upgrade to. |
Thanks for pointing this out @bottler |
by the way, the github.com/pytorch/pytorch front page (so the README?) still mentions supported versions of Python 3.6; we should update that, right? |
Summary: Closes #74203 Signed-off-by: Eli Uriegas <[email protected]> Pull Request resolved: #77304 Approved by: https://github.com/b0noI Test Plan: contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/e8f53ad1f11301aa0f96d331a1126cf9d718b195 Reviewed By: atalman Differential Revision: D36353749 fbshipit-source-id: 1d9649aa02ebd3bdea314084c638247265d8d674
Now that NEP 29 is adopted by PyTorch and PyTorch 1.12 is released, it seems like a good moment to drop Python 3.7. I opened an issue about this here: #80513 |
Context
Following yet another discussion on which Python version we support (#74087) we would like to open a broader discussion on this.
For historical context on how we dealt with 3.6.X versions, we dropped <3.6.2 early on to be able to use features from it #47314. We then moved to 3.7.0 as minimum version when 3.6 reached EOL #71494.
The naming for versions below will be "major.minor.patch".
Related policies are:
Based on this here are two proposals to move forward:
In both cases we will have
pip install torch
still works just fine. For older versions of Python you will only get the most recent PyTorch version that is available. The difference between the options below is how recent will the version of PyTorch be.1) Adopt NEP 29
Deprecation dates under this proposal
2) Use NEP 29 for patch versions and EOL for minor versions
Deprecation dates under this proposal
WDYT ?
The text was updated successfully, but these errors were encountered: