You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Summary:
Due to a logic bug, tracing is broken for custom ops. Unfortunately, there also weren't any tests for tracing custom ops.
The fix is a single line change of moving `pop(stack, std::get<Is>(arguments)...);` before `node = getTracedNode<Is...>(schema, arguments);`. Other changes are added tests and improved commenting/formatting.
Fixespytorch#13564
CC The controller you requested could not be found. fmassa
zdevito
Pull Request resolved: pytorch#13654
Differential Revision: D12952887
Pulled By: goldsborough
fbshipit-source-id: 87d256576f787c58e8d8f5c13a0fecd0ec62a602
🐛 Bug
Custom ops can be used in JIT script, but not in tracing.
To Reproduce
Expected behavior
Everything to work perfectly!
Environment
Today's master
Context
I noticed this with a formidable JIT challenge (@fmassa ):
facebookresearch/maskrcnn-benchmark#27 (comment)
@goldsborough : This is as mentioned on the slack.
The text was updated successfully, but these errors were encountered: