Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pytorch Windows MKL cmake file don't support static link mkl. #124869

Closed
xuhancn opened this issue Apr 24, 2024 · 0 comments
Closed

pytorch Windows MKL cmake file don't support static link mkl. #124869

xuhancn opened this issue Apr 24, 2024 · 0 comments
Assignees
@xuhancn
Labels
intel This tag is for PR from Intel module: mkl Related to our MKL support module: windows Windows support for PyTorch triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module

Comments

@xuhancn
Copy link
Collaborator

xuhancn commented Apr 24, 2024 •
edited
Loading

🐛 Describe the bug

pytorch Windows MKL cmake file don't support static link mkl.

https://github.com/pytorch/pytorch/actions/runs/8821164940/job/24217617660
image

I will fix it later and open this issue for tracing.

Versions

NA

cc @peterjc123 @mszhanyi @skyline75489 @nbcsm @vladimir-aubrecht @iremyux @Blackhex @cristianPanaite @jgong5 @mingfeima @XiaobingSuper @sanchitintel @ashokei @jingxu10
@xuhancn xuhancn self-assigned this Apr 24, 2024
@xuhancn xuhancn added module: windows Windows support for PyTorch intel This tag is for PR from Intel labels Apr 24, 2024
@xuhancn xuhancn mentioned this issue Apr 24, 2024
Merged
@malfet malfet added triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module module: mkl Related to our MKL support labels Apr 24, 2024
@xuhancn xuhancn mentioned this issue Apr 25, 2024
Closed
@jatkinson1000 jatkinson1000 mentioned this issue May 1, 2024
Open
pytorch-bot bot pushed a commit that referenced this issue May 3, 2024
@xuhancn @petrex
Fix mkl cmake not support static mkl on Windows. (#124925)
bab0f28 
Fixes #124869

Fix mkl not support static library on Windows.
# Local test:
## MKL static:
![image](https://github.com/pytorch/pytorch/assets/8433590/9c6ee5f8-9844-4383-acbd-6b22aff06daa)
MKL backend check:
<img width="724" alt="Image" src="https://github.com/pytorch/pytorch/assets/8433590/e45e12a5-2dfc-47a1-ad94-32a667bd4799">

## MKL shared, original path:
![image](https://github.com/pytorch/pytorch/assets/8433590/27a822c7-c4ab-4e5f-bbdb-8c4b085140e5)

Pull Request resolved: #124925
Approved by: https://github.com/jgong5, https://github.com/ezyang
@jatkinson1000 jatkinson1000 mentioned this issue May 9, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@xuhancn xuhancn

Labels
intel This tag is for PR from Intel module: mkl Related to our MKL support module: windows Windows support for PyTorch triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix mkl cmake not support static mkl on Windows. xuhancn/pytorch
2 participants
@malfet @xuhancn