Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for linalg.lu_factor* as _lu_with_info will be deprecated #386

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions functorch/csrc/BatchRulesLinearAlgebra.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -185,6 +185,8 @@ TORCH_LIBRARY_IMPL(aten, FT_BATCHED_KEY, m) {

VARIADIC_BDIMS_BOXED(_det_lu_based_helper);
VARIADIC_BDIMS_BOXED(_lu_with_info);
VARIADIC_BDIMS_BOXED(linalg_lu_factor_ex);
VARIADIC_BDIMS_BOXED(linalg_lu_factor);
vfdev-5 marked this conversation as resolved.
Show resolved Hide resolved
}
}}

2 changes: 2 additions & 0 deletions test/functorch_lagging_op_db.py
Original file line number Diff line number Diff line change
Expand Up @@ -242,6 +242,8 @@
('linalg.inv_ex', ''),
('linalg.lstsq', ''),
('linalg.lstsq', 'grad_oriented'),
('linalg.lu_factor', ''),
('linalg.lu_factor_ex', ''),
('linalg.matrix_norm', ''),
('linalg.matrix_power', ''),
('linalg.matrix_rank', ''),
Expand Down