Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed nn.functional.pad constant mode #249

Merged
merged 3 commits into from
Nov 10, 2021
Merged

Fixed nn.functional.pad constant mode #249

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8394dab
Fixed nn.functional.pad constant mode
vfdev-5 Nov 8, 2021
4c3d2bd
Fixed issues with unexpected failures for fft tests
vfdev-5 Nov 8, 2021
6c363f6
Update BatchRulesModules.cpp
vfdev-5 Nov 8, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion functorch/csrc/BatchRulesModules.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -401,7 +401,7 @@ TORCH_LIBRARY_IMPL(aten, FT_BATCHED_KEY, m) {
VMAP_SUPPORT("cudnn_grid_sampler", GRID_SAMPLE_BATCH_RULE(cudnn_grid_sampler));
VMAP_SUPPORT("cross", cross_batch_rule);

UNARY_POINTWISE(constant_pad_nd);
VARIADIC_BDIMS(constant_pad_nd);
EXISTING_BDIM(reflection_pad1d);
EXISTING_BDIM(reflection_pad2d);
EXISTING_BDIM(reflection_pad3d);
Expand Down
14 changes: 0 additions & 14 deletions test/test_ops.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -310,17 +310,12 @@ def vjp_of_vjp(*args_and_cotangents):
xfail('diag_embed'),
xfail('eig'),
xfail('nn.functional.conv_transpose2d'),
xfail('nn.functional.pad', 'constant'),
xfail('view_as_complex'),
xfail('fft.fft'),
xfail('fft.ifft'),
xfail('fft.ihfft'),
xfail('fft.ihfft'),
xfail('fft.rfft'),
xfail('fft.rfft'),
xfail('fft.fftn'),
xfail('fft.rfftn'),
xfail('fft.ifftn'),
xfail('cdist'),
xfail('fmax'),
xfail('fmin'),
Expand Down Expand Up @@ -358,8 +353,6 @@ def vjp_of_vjp(*args_and_cotangents):
xfail('nanmean'),
xfail('block_diag'),
xfail('nn.functional.dropout'),
xfail('fft.fft2'),
xfail('fft.ifft2'),
xfail('fft.ihfft2'),
xfail('fft.ihfftn'),
xfail('fft.rfft2'),
Expand Down Expand Up @@ -389,7 +382,6 @@ def test_vmapvjp(self, device, dtype, op):

@ops(functorch_lagging_op_db + additional_op_db, allowed_dtypes=(torch.float,))
@skipOps('TestOperators', 'test_vmapvjp_has_batch_rule', vmapvjp_fail.union({
xfail('nn.functional.pad', 'constant'),
xfail('view_as_complex'),
xfail('__getitem__'),
xfail('__rpow__'),
Expand All @@ -407,10 +399,6 @@ def test_vmapvjp(self, device, dtype, op):
xfail('diag'),
xfail('diag_embed'),
xfail('eig'),
xfail('fft.fft'),
xfail('fft.fftn'),
xfail('fft.ifft'),
xfail('fft.ifftn'),
xfail('fft.ihfft'),
xfail('fft.rfft'),
xfail('fft.rfftn'),
Expand Down Expand Up @@ -500,8 +488,6 @@ def test_vmapvjp(self, device, dtype, op):
xfail('_masked.sum'),
xfail('_masked.prod'),
xfail('cholesky_solve'),
xfail('fft.fft2'),
xfail('fft.ifft2'),
xfail('fft.ihfft2'),
xfail('fft.ihfftn'),
xfail('fft.rfft2'),
Expand Down
6 changes: 0 additions & 6 deletions test/test_vmap.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3013,14 +3013,8 @@ class TestVmapOperatorsOpInfo(TestCase):
xfail('linalg.svd', device_type='cuda'),
xfail('index_put'),
xfail('matrix_exp'),
xfail('fft.fft'),
xfail('fft.ifft'),
xfail('fft.ihfft'),
xfail('fft.rfft'),
xfail('fft.rfftn'),
xfail('nn.functional.batch_norm'),
xfail('lu_unpack'),
xfail('nn.functional.pad', 'constant'),
xfail('empty_like'),
xfail('histogramdd'),
xfail('nn.functional.embedding'),
Expand Down