Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added batch rule for (adaptive_)avg_poolNd #248

Merged
merged 2 commits into from
Nov 12, 2021
Merged

Added batch rule for (adaptive_)avg_poolNd #248

merged 2 commits into from
Nov 12, 2021

Conversation

vfdev-5
Copy link
Contributor

@vfdev-5 vfdev-5 commented Nov 8, 2021 •
edited
Loading

Description:

  • Added batch rule for adaptive_avg_pool{1d,2d,3d} and avg_pool{1d,2d,3d}
  • Enabled tests for adaptive_avg_pool{1d, 2d, 3d}, avg_pool{1d,2d,3d} and nn.functional.interpolate (mode="area")

Adresses #240

@vfdev-5
Added batch rule for (adaptive_)avg_poolNd
50853a8 
Description:
- Added batch rule for adaptive_avg_pool{1d,2d,3d} and avg_pool{1d,2d,3d}
- Updated tests
@vfdev-5
Copy link
Contributor Author

vfdev-5 commented Nov 10, 2021

Please review @zou3519

Chillee
Chillee approved these changes Nov 10, 2021
View reviewed changes
Copy link
Contributor

@Chillee Chillee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

I assume it's not possible to write this another way?

@vfdev-5
Copy link
Contributor Author

vfdev-5 commented Nov 11, 2021

@Chillee do you mean if we could use some other macros? I can take a look.

@Chillee Chillee merged commit 5423fdd into pytorch:main Nov 12, 2021
@Chillee
Copy link
Contributor

Chillee commented Nov 12, 2021

@vfdev-5 I was just curious whether we had to do this "expand" strategy, but I think this is fine.

@vfdev-5 vfdev-5 deleted the added-avg-poolNd-br branch November 12, 2021 18:43
zou3519 pushed a commit to zou3519/pytorch that referenced this pull request Jul 20, 2022
@vfdev-5 @zou3519
[functorch] Added batch rule for (adaptive_)avg_poolNd (pytorch/funct…
6d0ffb4 
…orch#248)

* Added batch rule for (adaptive_)avg_poolNd
Description:
- Added batch rule for adaptive_avg_pool{1d,2d,3d} and avg_pool{1d,2d,3d}
- Updated tests

* Enabled nn.functional.interpolate mode=area
bigfootjon pushed a commit to pytorch/pytorch that referenced this pull request Jul 21, 2022
@vfdev-5 @bigfootjon
[functorch] Added batch rule for (adaptive_)avg_poolNd (pytorch/funct…
bef4603 
…orch#248)

* Added batch rule for (adaptive_)avg_poolNd
Description:
- Added batch rule for adaptive_avg_pool{1d,2d,3d} and avg_pool{1d,2d,3d}
- Updated tests

* Enabled nn.functional.interpolate mode=area
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Chillee Chillee Chillee approved these changes

@zou3519 zou3519 zou3519 approved these changes

Assignees
No one assigned
Labels
cla signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vfdev-5 @Chillee @zou3519 @facebook-github-bot