-
Notifications
You must be signed in to change notification settings - Fork 151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix S3FileLoader local file clobbering #895
Fix S3FileLoader local file clobbering #895
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Based on the test failures, it seems like an extra file was added to the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you. LGTM. I am fixing the tests in #896. Will let you know when the fix has been landed and please rebase afterwards.
Yea. And, I personally think the test failures are unrelated to your PR. To guarantee the changes in this PR, let's wait until my PR is landed and rebase this PR to main branch afterwards. Thank you |
@ringohoffman Do you mind rebasing your commits onto main branch? #896 has been landed. |
@ejguan has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thank you
Fixes pytorch#735; remove unnecessary call to storeFile, a remnant from the aws-doc-sdk-examples transferOnStream.cpp example, where this function is used to verify the buffer contents: https://github.com/awsdocs/aws-doc-sdk-examples/blob/main/cpp/example_code/transfer-manager/transferOnStream.cpp#L131
2177fac
to
ec9c8d9
Compare
@ejguan has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Fixes #735; remove unnecessary call to
storeFile()
, a remnant from theaws-doc-sdk-examples
transferOnStream.cpp
example, where this function is used to verify the buffer's contents: https://github.com/awsdocs/aws-doc-sdk-examples/blob/main/cpp/example_code/transfer-manager/transferOnStream.cpp#L131Changes
storeFile()
Testing
Verified files are no longer clobbered through local testing