Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PrototypeRS] Adding 'pause' and 'resume' operations to halt DataPipes #879

Closed
wants to merge 45 commits into from

Commits on Nov 3, 2022

  1. [PrototypeRS] Adding 'full stop' to halt DataPipes

    [ghstack-poisoned]
    NivekT committed Nov 3, 2022
    Configuration menu
    Copy the full SHA
    d22790b View commit details
    Browse the repository at this point in the history

Commits on Nov 7, 2022

  1. Update on "[PrototypeRS] Adding 'full stop' to halt DataPipes"

    The goal of this PR is fully stop DataPipe activities in preparation of snapshotting (which requires a halted state), so buffers will not be changing while we record the snapshot.
    
    
    [ghstack-poisoned]
    NivekT committed Nov 7, 2022
    Configuration menu
    Copy the full SHA
    9efb6b3 View commit details
    Browse the repository at this point in the history

Commits on Nov 10, 2022

  1. Update on "[PrototypeRS] Adding 'full stop' to halt DataPipes"

    The goal of this PR is fully stop DataPipe activities in preparation of snapshotting (which requires a halted state), so buffers will not be changing while we record the snapshot.
    
    
    [ghstack-poisoned]
    NivekT committed Nov 10, 2022
    Configuration menu
    Copy the full SHA
    50bea6c View commit details
    Browse the repository at this point in the history

Commits on Nov 11, 2022

  1. Update on "[PrototypeRS] Adding 'full stop' to halt DataPipes"

    The goal of this PR is fully stop DataPipe activities in preparation of snapshotting (which requires a halted state), so buffers will not be changing while we record the snapshot.
    
    
    [ghstack-poisoned]
    NivekT committed Nov 11, 2022
    Configuration menu
    Copy the full SHA
    a853244 View commit details
    Browse the repository at this point in the history

Commits on Nov 14, 2022

  1. Update on "[PrototypeRS] Adding 'pause' and 'resume' operations to ha…

    …lt DataPipes"
    
    
    The goal of this PR is fully stop DataPipe activities in preparation of snapshotting (which requires a halted state), so buffers will not be changing while we record the snapshot.
    
    
    [ghstack-poisoned]
    NivekT committed Nov 14, 2022
    Configuration menu
    Copy the full SHA
    c88fce0 View commit details
    Browse the repository at this point in the history

Commits on Nov 16, 2022

  1. Update on "[PrototypeRS] Adding 'pause' and 'resume' operations to ha…

    …lt DataPipes"
    
    
    The goal of this PR is fully stop DataPipe activities in preparation of snapshotting (which requires a halted state), so buffers will not be changing while we record the snapshot.
    
    
    [ghstack-poisoned]
    NivekT committed Nov 16, 2022
    Configuration menu
    Copy the full SHA
    856e8e7 View commit details
    Browse the repository at this point in the history
  2. Update on "[PrototypeRS] Adding 'pause' and 'resume' operations to ha…

    …lt DataPipes"
    
    
    The goal of this PR is fully stop DataPipe activities in preparation of snapshotting (which requires a halted state), so buffers will not be changing while we record the snapshot.
    
    
    [ghstack-poisoned]
    NivekT committed Nov 16, 2022
    Configuration menu
    Copy the full SHA
    261fb9d View commit details
    Browse the repository at this point in the history
  3. Update on "[PrototypeRS] Adding 'pause' and 'resume' operations to ha…

    …lt DataPipes"
    
    
    The goal of this PR is fully stop DataPipe activities in preparation of snapshotting (which requires a halted state), so buffers will not be changing while we record the snapshot.
    
    
    [ghstack-poisoned]
    NivekT committed Nov 16, 2022
    Configuration menu
    Copy the full SHA
    a78d5d6 View commit details
    Browse the repository at this point in the history

Commits on Nov 17, 2022

  1. Update on "[PrototypeRS] Adding 'pause' and 'resume' operations to ha…

    …lt DataPipes"
    
    
    The goal of this PR is fully stop DataPipe activities in preparation of snapshotting (which requires a halted state), so buffers will not be changing while we record the snapshot.
    
    
    [ghstack-poisoned]
    NivekT committed Nov 17, 2022
    Configuration menu
    Copy the full SHA
    26c3055 View commit details
    Browse the repository at this point in the history

Commits on Dec 3, 2022

  1. Update on "[PrototypeRS] Adding 'pause' and 'resume' operations to ha…

    …lt DataPipes"
    
    
    The goal of this PR is fully stop DataPipe activities in preparation of snapshotting (which requires a halted state), so buffers will not be changing while we record the snapshot.
    
    
    [ghstack-poisoned]
    NivekT committed Dec 3, 2022
    Configuration menu
    Copy the full SHA
    e44c4a9 View commit details
    Browse the repository at this point in the history
  2. Update on "[PrototypeRS] Adding 'pause' and 'resume' operations to ha…

    …lt DataPipes"
    
    
    The goal of this PR is fully stop DataPipe activities in preparation of snapshotting (which requires a halted state), so buffers will not be changing while we record the snapshot.
    
    
    [ghstack-poisoned]
    NivekT committed Dec 3, 2022
    Configuration menu
    Copy the full SHA
    b7eab9d View commit details
    Browse the repository at this point in the history

Commits on Dec 5, 2022

  1. Update on "[PrototypeRS] Adding 'pause' and 'resume' operations to ha…

    …lt DataPipes"
    
    
    The goal of this PR is fully stop DataPipe activities in preparation of snapshotting (which requires a halted state), so buffers will not be changing while we record the snapshot.
    
    
    [ghstack-poisoned]
    NivekT committed Dec 5, 2022
    Configuration menu
    Copy the full SHA
    2aae34f View commit details
    Browse the repository at this point in the history
  2. Update on "[PrototypeRS] Adding 'pause' and 'resume' operations to ha…

    …lt DataPipes"
    
    
    The goal of this PR is fully stop DataPipe activities in preparation of snapshotting (which requires a halted state), so buffers will not be changing while we record the snapshot.
    
    
    [ghstack-poisoned]
    NivekT committed Dec 5, 2022
    Configuration menu
    Copy the full SHA
    9faa78d View commit details
    Browse the repository at this point in the history
  3. Update on "[PrototypeRS] Adding 'pause' and 'resume' operations to ha…

    …lt DataPipes"
    
    
    The goal of this PR is fully stop DataPipe activities in preparation of snapshotting (which requires a halted state), so buffers will not be changing while we record the snapshot.
    
    
    [ghstack-poisoned]
    NivekT committed Dec 5, 2022
    Configuration menu
    Copy the full SHA
    bd7dc6e View commit details
    Browse the repository at this point in the history
  4. Update on "[PrototypeRS] Adding 'pause' and 'resume' operations to ha…

    …lt DataPipes"
    
    
    The goal of this PR is fully stop DataPipe activities in preparation of snapshotting (which requires a halted state), so buffers will not be changing while we record the snapshot.
    
    
    [ghstack-poisoned]
    NivekT committed Dec 5, 2022
    Configuration menu
    Copy the full SHA
    250dec3 View commit details
    Browse the repository at this point in the history
  5. Update on "[PrototypeRS] Adding 'pause' and 'resume' operations to ha…

    …lt DataPipes"
    
    
    The goal of this PR is fully stop DataPipe activities in preparation of snapshotting (which requires a halted state), so buffers will not be changing while we record the snapshot.
    
    
    [ghstack-poisoned]
    NivekT committed Dec 5, 2022
    Configuration menu
    Copy the full SHA
    ba66c1c View commit details
    Browse the repository at this point in the history
  6. Update on "[PrototypeRS] Adding 'pause' and 'resume' operations to ha…

    …lt DataPipes"
    
    
    The goal of this PR is fully stop DataPipe activities in preparation of snapshotting (which requires a halted state), so buffers will not be changing while we record the snapshot.
    
    Differential Revision: [D41744759](https://our.internmc.facebook.com/intern/diff/D41744759)
    
    [ghstack-poisoned]
    NivekT committed Dec 5, 2022
    Configuration menu
    Copy the full SHA
    d5a6fa9 View commit details
    Browse the repository at this point in the history
  7. Update on "[PrototypeRS] Adding 'pause' and 'resume' operations to ha…

    …lt DataPipes"
    
    
    The goal of this PR is fully stop DataPipe activities in preparation of snapshotting (which requires a halted state), so buffers will not be changing while we record the snapshot.
    
    Differential Revision: [D41744759](https://our.internmc.facebook.com/intern/diff/D41744759)
    
    [ghstack-poisoned]
    NivekT committed Dec 5, 2022
    Configuration menu
    Copy the full SHA
    3471a34 View commit details
    Browse the repository at this point in the history
  8. Update on "[PrototypeRS] Adding 'pause' and 'resume' operations to ha…

    …lt DataPipes"
    
    
    The goal of this PR is fully stop DataPipe activities in preparation of snapshotting (which requires a halted state), so buffers will not be changing while we record the snapshot.
    
    Differential Revision: [D41744759](https://our.internmc.facebook.com/intern/diff/D41744759)
    
    [ghstack-poisoned]
    NivekT committed Dec 5, 2022
    Configuration menu
    Copy the full SHA
    865ee90 View commit details
    Browse the repository at this point in the history
  9. Update on "[PrototypeRS] Adding 'pause' and 'resume' operations to ha…

    …lt DataPipes"
    
    
    The goal of this PR is fully stop DataPipe activities in preparation of snapshotting (which requires a halted state), so buffers will not be changing while we record the snapshot.
    
    Differential Revision: [D41744759](https://our.internmc.facebook.com/intern/diff/D41744759)
    
    [ghstack-poisoned]
    NivekT committed Dec 5, 2022
    Configuration menu
    Copy the full SHA
    ab24eb9 View commit details
    Browse the repository at this point in the history
  10. Update on "[PrototypeRS] Adding 'pause' and 'resume' operations to ha…

    …lt DataPipes"
    
    
    The goal of this PR is fully stop DataPipe activities in preparation of snapshotting (which requires a halted state), so buffers will not be changing while we record the snapshot.
    
    Differential Revision: [D41744759](https://our.internmc.facebook.com/intern/diff/D41744759)
    
    [ghstack-poisoned]
    NivekT committed Dec 5, 2022
    Configuration menu
    Copy the full SHA
    c0c7dec View commit details
    Browse the repository at this point in the history
  11. Update on "[PrototypeRS] Adding 'pause' and 'resume' operations to ha…

    …lt DataPipes"
    
    
    The goal of this PR is fully stop DataPipe activities in preparation of snapshotting (which requires a halted state), so buffers will not be changing while we record the snapshot.
    
    Differential Revision: [D41744759](https://our.internmc.facebook.com/intern/diff/D41744759)
    
    [ghstack-poisoned]
    NivekT committed Dec 5, 2022
    Configuration menu
    Copy the full SHA
    c483e96 View commit details
    Browse the repository at this point in the history

Commits on Dec 7, 2022

  1. Update on "[PrototypeRS] Adding 'pause' and 'resume' operations to ha…

    …lt DataPipes"
    
    
    The goal of this PR is fully stop DataPipe activities in preparation of snapshotting (which requires a halted state), so buffers will not be changing while we record the snapshot.
    
    Differential Revision: [D41744759](https://our.internmc.facebook.com/intern/diff/D41744759)
    
    [ghstack-poisoned]
    NivekT committed Dec 7, 2022
    Configuration menu
    Copy the full SHA
    031af83 View commit details
    Browse the repository at this point in the history
  2. Update on "[PrototypeRS] Adding 'pause' and 'resume' operations to ha…

    …lt DataPipes"
    
    
    The goal of this PR is fully stop DataPipe activities in preparation of snapshotting (which requires a halted state), so buffers will not be changing while we record the snapshot.
    
    Differential Revision: [D41744759](https://our.internmc.facebook.com/intern/diff/D41744759)
    
    [ghstack-poisoned]
    NivekT committed Dec 7, 2022
    Configuration menu
    Copy the full SHA
    ac017f2 View commit details
    Browse the repository at this point in the history
  3. Update on "[PrototypeRS] Adding 'pause' and 'resume' operations to ha…

    …lt DataPipes"
    
    
    The goal of this PR is fully stop DataPipe activities in preparation of snapshotting (which requires a halted state), so buffers will not be changing while we record the snapshot.
    
    Differential Revision: [D41744759](https://our.internmc.facebook.com/intern/diff/D41744759)
    
    [ghstack-poisoned]
    NivekT committed Dec 7, 2022
    Configuration menu
    Copy the full SHA
    eb6f3fb View commit details
    Browse the repository at this point in the history

Commits on Dec 14, 2022

  1. Update on "[PrototypeRS] Adding 'pause' and 'resume' operations to ha…

    …lt DataPipes"
    
    
    The goal of this PR is fully stop DataPipe activities in preparation of snapshotting (which requires a halted state), so buffers will not be changing while we record the snapshot.
    
    Differential Revision: [D41744759](https://our.internmc.facebook.com/intern/diff/D41744759)
    
    [ghstack-poisoned]
    NivekT committed Dec 14, 2022
    Configuration menu
    Copy the full SHA
    80c65e0 View commit details
    Browse the repository at this point in the history

Commits on Dec 15, 2022

  1. Update on "[PrototypeRS] Adding 'pause' and 'resume' operations to ha…

    …lt DataPipes"
    
    
    The goal of this PR is fully stop DataPipe activities in preparation of snapshotting (which requires a halted state), so buffers will not be changing while we record the snapshot.
    
    Differential Revision: [D41744759](https://our.internmc.facebook.com/intern/diff/D41744759)
    
    [ghstack-poisoned]
    NivekT committed Dec 15, 2022
    Configuration menu
    Copy the full SHA
    ea7952f View commit details
    Browse the repository at this point in the history

Commits on Dec 17, 2022

  1. Update on "[PrototypeRS] Adding 'pause' and 'resume' operations to ha…

    …lt DataPipes"
    
    
    The goal of this PR is fully stop DataPipe activities in preparation of snapshotting (which requires a halted state), so buffers will not be changing while we record the snapshot.
    
    Differential Revision: [D41744759](https://our.internmc.facebook.com/intern/diff/D41744759)
    
    [ghstack-poisoned]
    NivekT committed Dec 17, 2022
    Configuration menu
    Copy the full SHA
    b960db3 View commit details
    Browse the repository at this point in the history

Commits on Dec 18, 2022

  1. Update on "[PrototypeRS] Adding 'pause' and 'resume' operations to ha…

    …lt DataPipes"
    
    
    The goal of this PR is fully stop DataPipe activities in preparation of snapshotting (which requires a halted state), so buffers will not be changing while we record the snapshot.
    
    Differential Revision: [D41744759](https://our.internmc.facebook.com/intern/diff/D41744759)
    
    [ghstack-poisoned]
    NivekT committed Dec 18, 2022
    Configuration menu
    Copy the full SHA
    08db7ea View commit details
    Browse the repository at this point in the history

Commits on Jan 3, 2023

  1. Update on "[PrototypeRS] Adding 'pause' and 'resume' operations to ha…

    …lt DataPipes"
    
    
    The goal of this PR is fully stop DataPipe activities in preparation of snapshotting (which requires a halted state), so buffers will not be changing while we record the snapshot.
    
    Differential Revision: [D41744759](https://our.internmc.facebook.com/intern/diff/D41744759)
    
    [ghstack-poisoned]
    NivekT committed Jan 3, 2023
    Configuration menu
    Copy the full SHA
    cb6f017 View commit details
    Browse the repository at this point in the history

Commits on Jan 13, 2023

  1. Update on "[PrototypeRS] Adding 'pause' and 'resume' operations to ha…

    …lt DataPipes"
    
    
    The goal of this PR is fully stop DataPipe activities in preparation of snapshotting (which requires a halted state), so buffers will not be changing while we record the snapshot.
    
    Differential Revision: [D41744759](https://our.internmc.facebook.com/intern/diff/D41744759)
    
    [ghstack-poisoned]
    NivekT committed Jan 13, 2023
    Configuration menu
    Copy the full SHA
    b70b3a7 View commit details
    Browse the repository at this point in the history

Commits on Jan 18, 2023

  1. Update on "[PrototypeRS] Adding 'pause' and 'resume' operations to ha…

    …lt DataPipes"
    
    
    The goal of this PR is fully stop DataPipe activities in preparation of snapshotting (which requires a halted state), so buffers will not be changing while we record the snapshot.
    
    Differential Revision: [D41744759](https://our.internmc.facebook.com/intern/diff/D41744759)
    
    [ghstack-poisoned]
    NivekT committed Jan 18, 2023
    Configuration menu
    Copy the full SHA
    c57c4c4 View commit details
    Browse the repository at this point in the history
  2. Update on "[PrototypeRS] Adding 'pause' and 'resume' operations to ha…

    …lt DataPipes"
    
    
    The goal of this PR is fully stop DataPipe activities in preparation of snapshotting (which requires a halted state), so buffers will not be changing while we record the snapshot.
    
    ---
    Implementation note (feel free to discuss):
    `_pause` exists for both `DataLoader2Iterator` and `DataLoader2` as private methods.
    `resume` exists for both `DataLoader2Iterator` and `DataLoader2` as public methods.
    
    `limit` and `clear_limit` exist only for `DataLoader2Iterator` as a public methods.
    - Limit persists through iterations (with the iterator) until it is manually cleared via `clear_limit`.
    - Creating a new iterator (`iter(dl2)`) will not retain the previous limit, because the limit is attached to the iterator.
    
    Differential Revision: [D41744759](https://our.internmc.facebook.com/intern/diff/D41744759)
    
    [ghstack-poisoned]
    NivekT committed Jan 18, 2023
    Configuration menu
    Copy the full SHA
    314cc4c View commit details
    Browse the repository at this point in the history
  3. Update on "[PrototypeRS] Adding 'pause' and 'resume' operations to ha…

    …lt DataPipes"
    
    
    The goal of this PR is fully stop DataPipe activities in preparation of snapshotting (which requires a halted state), so buffers will not be changing while we record the snapshot.
    
    ---
    Implementation note (feel free to discuss):
    `_pause` exists for both `DataLoader2Iterator` and `DataLoader2` as private methods.
    `resume` exists for both `DataLoader2Iterator` as public but it is private for `DataLoader2`.
    
    `limit` and `clear_limit` exist only for `DataLoader2Iterator` as a public methods.
    - Limit persists through iterations (with the iterator) until it is manually cleared via `clear_limit`.
    - Creating a new iterator (`iter(dl2)`) will not retain the previous limit, because the limit is attached to the iterator.
    
    Differential Revision: [D41744759](https://our.internmc.facebook.com/intern/diff/D41744759)
    
    [ghstack-poisoned]
    NivekT committed Jan 18, 2023
    Configuration menu
    Copy the full SHA
    d209b6a View commit details
    Browse the repository at this point in the history

Commits on Jan 24, 2023

  1. Update on "[PrototypeRS] Adding 'pause' and 'resume' operations to ha…

    …lt DataPipes"
    
    
    The goal of this PR is fully stop DataPipe activities in preparation of snapshotting (which requires a halted state), so buffers will not be changing while we record the snapshot.
    
    ---
    Implementation note (feel free to discuss):
    `_pause` exists for both `DataLoader2Iterator` and `DataLoader2` as private methods.
    `resume` exists for both `DataLoader2Iterator` as public but it is private for `DataLoader2`.
    
    `limit` and `clear_limit` exist only for `DataLoader2Iterator` as a public methods.
    - Limit persists through iterations (with the iterator) until it is manually cleared via `clear_limit`.
    - Creating a new iterator (`iter(dl2)`) will not retain the previous limit, because the limit is attached to the iterator.
    
    Differential Revision: [D41744759](https://our.internmc.facebook.com/intern/diff/D41744759)
    
    [ghstack-poisoned]
    NivekT committed Jan 24, 2023
    Configuration menu
    Copy the full SHA
    84d5346 View commit details
    Browse the repository at this point in the history

Commits on Feb 2, 2023

  1. Update on "[PrototypeRS] Adding 'pause' and 'resume' operations to ha…

    …lt DataPipes"
    
    
    The goal of this PR is fully stop DataPipe activities in preparation of snapshotting (which requires a halted state), so buffers will not be changing while we record the snapshot.
    
    ---
    Implementation note (feel free to discuss):
    `_pause` exists for both `DataLoader2Iterator` and `DataLoader2` as private methods.
    `resume` exists for both `DataLoader2Iterator` as public but it is private for `DataLoader2`.
    
    `limit` and `clear_limit` exist only for `DataLoader2Iterator` as a public methods.
    - Limit persists through iterations (with the iterator) until it is manually cleared via `clear_limit`.
    - Creating a new iterator (`iter(dl2)`) will not retain the previous limit, because the limit is attached to the iterator.
    
    Differential Revision: [D41744759](https://our.internmc.facebook.com/intern/diff/D41744759)
    
    [ghstack-poisoned]
    NivekT committed Feb 2, 2023
    Configuration menu
    Copy the full SHA
    29a4fd0 View commit details
    Browse the repository at this point in the history

Commits on Feb 6, 2023

  1. Update on "[PrototypeRS] Adding 'pause' and 'resume' operations to ha…

    …lt DataPipes"
    
    
    The goal of this PR is fully stop DataPipe activities in preparation of snapshotting (which requires a halted state), so buffers will not be changing while we record the snapshot.
    
    ---
    Implementation note (feel free to discuss):
    `_pause` exists for both `DataLoader2Iterator` and `DataLoader2` as private methods.
    `resume` exists for both `DataLoader2Iterator` as public but it is private for `DataLoader2`.
    
    `limit` and `clear_limit` exist only for `DataLoader2Iterator` as a public methods.
    - Limit persists through iterations (with the iterator) until it is manually cleared via `clear_limit`.
    - Creating a new iterator (`iter(dl2)`) will not retain the previous limit, because the limit is attached to the iterator.
    
    Differential Revision: [D41744759](https://our.internmc.facebook.com/intern/diff/D41744759)
    
    [ghstack-poisoned]
    NivekT committed Feb 6, 2023
    Configuration menu
    Copy the full SHA
    a1ecb98 View commit details
    Browse the repository at this point in the history

Commits on Feb 7, 2023

  1. Update on "[PrototypeRS] Adding 'pause' and 'resume' operations to ha…

    …lt DataPipes"
    
    
    The goal of this PR is fully stop DataPipe activities in preparation of snapshotting (which requires a halted state), so buffers will not be changing while we record the snapshot.
    
    This PR doesn't handle pausing or resuming with `sharding_round_robin_dispatch`. This will be fixed in an upcoming PR and is tracked by #991.
    
    ---
    Implementation note (feel free to discuss):
    `_pause` exists for both `DataLoader2Iterator` and `DataLoader2` as private methods.
    `resume` exists for both `DataLoader2Iterator` as public but it is private for `DataLoader2`.
    
    `limit` and `clear_limit` exist only for `DataLoader2Iterator` as a public methods.
    - Limit persists through iterations (with the iterator) until it is manually cleared via `clear_limit`.
    - Creating a new iterator (`iter(dl2)`) will not retain the previous limit, because the limit is attached to the iterator.
    
    Differential Revision: [D41744759](https://our.internmc.facebook.com/intern/diff/D41744759)
    
    [ghstack-poisoned]
    NivekT committed Feb 7, 2023
    Configuration menu
    Copy the full SHA
    dc72f20 View commit details
    Browse the repository at this point in the history

Commits on Feb 8, 2023

  1. Update on "[PrototypeRS] Adding 'pause' and 'resume' operations to ha…

    …lt DataPipes"
    
    
    The goal of this PR is fully stop DataPipe activities in preparation of snapshotting (which requires a halted state), so buffers will not be changing while we record the snapshot.
    
    This PR doesn't handle pausing or resuming with `sharding_round_robin_dispatch`. This will be fixed in an upcoming PR and is tracked by #991.
    
    ---
    Implementation note (feel free to discuss):
    `_pause` exists for both `DataLoader2Iterator` and `DataLoader2` as private methods.
    `resume` exists for both `DataLoader2Iterator` as public but it is private for `DataLoader2`.
    
    `limit` and `clear_limit` exist only for `DataLoader2Iterator` as a public methods.
    - Limit persists through iterations (with the iterator) until it is manually cleared via `clear_limit`.
    - Creating a new iterator (`iter(dl2)`) will not retain the previous limit, because the limit is attached to the iterator.
    
    Differential Revision: [D41744759](https://our.internmc.facebook.com/intern/diff/D41744759)
    
    [ghstack-poisoned]
    NivekT committed Feb 8, 2023
    Configuration menu
    Copy the full SHA
    76219c7 View commit details
    Browse the repository at this point in the history
  2. Update on "[PrototypeRS] Adding 'pause' and 'resume' operations to ha…

    …lt DataPipes"
    
    
    The goal of this PR is fully stop DataPipe activities in preparation of snapshotting (which requires a halted state), so buffers will not be changing while we record the snapshot.
    
    This PR doesn't handle pausing or resuming with `sharding_round_robin_dispatch`. This will be fixed in an upcoming PR and is tracked by #991.
    
    ---
    Implementation note (feel free to discuss):
    `_pause` exists for both `DataLoader2Iterator` and `DataLoader2` as private methods.
    `resume` exists for both `DataLoader2Iterator` as public but it is private for `DataLoader2`.
    
    `limit` and `clear_limit` exist only for `DataLoader2Iterator` as a public methods.
    - Limit persists through iterations (with the iterator) until it is manually cleared via `clear_limit`.
    - Creating a new iterator (`iter(dl2)`) will not retain the previous limit, because the limit is attached to the iterator.
    
    Differential Revision: [D41744759](https://our.internmc.facebook.com/intern/diff/D41744759)
    
    [ghstack-poisoned]
    NivekT committed Feb 8, 2023
    Configuration menu
    Copy the full SHA
    e5b2544 View commit details
    Browse the repository at this point in the history
  3. Update on "[PrototypeRS] Adding 'pause' and 'resume' operations to ha…

    …lt DataPipes"
    
    
    The goal of this PR is fully stop DataPipe activities in preparation of snapshotting (which requires a halted state), so buffers will not be changing while we record the snapshot.
    
    This PR doesn't handle pausing or resuming with `sharding_round_robin_dispatch`. This will be fixed in an upcoming PR and is tracked by #991.
    
    ---
    Implementation note (feel free to discuss):
    `_pause` exists for both `DataLoader2Iterator` and `DataLoader2` as private methods.
    `resume` exists for both `DataLoader2Iterator` as public but it is private for `DataLoader2`.
    
    `limit` and `clear_limit` exist only for `DataLoader2Iterator` as a public methods.
    - Limit persists through iterations (with the iterator) until it is manually cleared via `clear_limit`.
    - Creating a new iterator (`iter(dl2)`) will not retain the previous limit, because the limit is attached to the iterator.
    
    Differential Revision: [D41744759](https://our.internmc.facebook.com/intern/diff/D41744759)
    
    [ghstack-poisoned]
    NivekT committed Feb 8, 2023
    Configuration menu
    Copy the full SHA
    caeb103 View commit details
    Browse the repository at this point in the history
  4. Update on "[PrototypeRS] Adding 'pause' and 'resume' operations to ha…

    …lt DataPipes"
    
    
    The goal of this PR is fully stop DataPipe activities in preparation of snapshotting (which requires a halted state), so buffers will not be changing while we record the snapshot.
    
    This PR doesn't handle pausing or resuming with `sharding_round_robin_dispatch`. This will be fixed in an upcoming PR and is tracked by #991.
    
    ---
    Implementation note (feel free to discuss):
    `_pause` exists for both `DataLoader2Iterator` and `DataLoader2` as private methods.
    `resume` exists for both `DataLoader2Iterator` as public but it is private for `DataLoader2`.
    
    `limit` and `clear_limit` exist only for `DataLoader2Iterator` as a public methods.
    - Limit persists through iterations (with the iterator) until it is manually cleared via `clear_limit`.
    - Creating a new iterator (`iter(dl2)`) will not retain the previous limit, because the limit is attached to the iterator.
    
    Differential Revision: [D41744759](https://our.internmc.facebook.com/intern/diff/D41744759)
    
    [ghstack-poisoned]
    NivekT committed Feb 8, 2023
    Configuration menu
    Copy the full SHA
    491cb41 View commit details
    Browse the repository at this point in the history

Commits on Feb 9, 2023

  1. Update on "[PrototypeRS] Adding 'pause' and 'resume' operations to ha…

    …lt DataPipes"
    
    
    The goal of this PR is fully stop DataPipe activities in preparation of snapshotting (which requires a halted state), so buffers will not be changing while we record the snapshot.
    
    This PR doesn't handle pausing or resuming with `sharding_round_robin_dispatch`. This will be fixed in an upcoming PR and is tracked by #991.
    
    ---
    Implementation note (feel free to discuss):
    `_pause` exists for both `DataLoader2Iterator` and `DataLoader2` as private methods.
    `resume` exists for both `DataLoader2Iterator` as public but it is private for `DataLoader2`.
    
    `limit` and `clear_limit` exist only for `DataLoader2Iterator` as a public methods.
    - Limit persists through iterations (with the iterator) until it is manually cleared via `clear_limit`.
    - Creating a new iterator (`iter(dl2)`) will not retain the previous limit, because the limit is attached to the iterator.
    
    Differential Revision: [D41744759](https://our.internmc.facebook.com/intern/diff/D41744759)
    
    [ghstack-poisoned]
    NivekT committed Feb 9, 2023
    Configuration menu
    Copy the full SHA
    00cbd0e View commit details
    Browse the repository at this point in the history
  2. Update on "[PrototypeRS] Adding 'pause' and 'resume' operations to ha…

    …lt DataPipes"
    
    
    The goal of this PR is fully stop DataPipe activities in preparation of snapshotting (which requires a halted state), so buffers will not be changing while we record the snapshot.
    
    This PR doesn't handle pausing or resuming with `sharding_round_robin_dispatch`. This will be fixed in an upcoming PR and is tracked by #991.
    
    ---
    Implementation note (feel free to discuss):
    `_pause` exists for both `DataLoader2Iterator` and `DataLoader2` as private methods.
    `resume` exists for both `DataLoader2Iterator` as public but it is private for `DataLoader2`.
    
    `limit` and `clear_limit` exist only for `DataLoader2Iterator` as a public methods.
    - Limit persists through iterations (with the iterator) until it is manually cleared via `clear_limit`.
    - Creating a new iterator (`iter(dl2)`) will not retain the previous limit, because the limit is attached to the iterator.
    
    Differential Revision: [D41744759](https://our.internmc.facebook.com/intern/diff/D41744759)
    
    [ghstack-poisoned]
    NivekT committed Feb 9, 2023
    Configuration menu
    Copy the full SHA
    7506f01 View commit details
    Browse the repository at this point in the history

Commits on Feb 10, 2023

  1. Update on "[PrototypeRS] Adding 'pause' and 'resume' operations to ha…

    …lt DataPipes"
    
    
    The goal of this PR is fully stop DataPipe activities in preparation of snapshotting (which requires a halted state), so buffers will not be changing while we record the snapshot.
    
    This PR doesn't handle pausing or resuming with `sharding_round_robin_dispatch`. This will be fixed in an upcoming PR and is tracked by #991.
    
    ---
    Implementation note (feel free to discuss):
    `_pause` exists for both `DataLoader2Iterator` and `DataLoader2` as private methods.
    `resume` exists for both `DataLoader2Iterator` as public but it is private for `DataLoader2`.
    
    `limit` and `clear_limit` exist only for `DataLoader2Iterator` as a public methods.
    - Limit persists through iterations (with the iterator) until it is manually cleared via `clear_limit`.
    - Creating a new iterator (`iter(dl2)`) will not retain the previous limit, because the limit is attached to the iterator.
    
    Differential Revision: [D41744759](https://our.internmc.facebook.com/intern/diff/D41744759)
    
    [ghstack-poisoned]
    NivekT committed Feb 10, 2023
    Configuration menu
    Copy the full SHA
    01bb5c7 View commit details
    Browse the repository at this point in the history