-
Notifications
You must be signed in to change notification settings - Fork 153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PrototypeRS] Adding 'pause' and 'resume' operations to halt DataPipes #879
Commits on Nov 3, 2022
-
Configuration menu - View commit details
-
Copy full SHA for d22790b - Browse repository at this point
Copy the full SHA d22790bView commit details
Commits on Nov 7, 2022
-
Update on "[PrototypeRS] Adding 'full stop' to halt DataPipes"
The goal of this PR is fully stop DataPipe activities in preparation of snapshotting (which requires a halted state), so buffers will not be changing while we record the snapshot. [ghstack-poisoned]
Configuration menu - View commit details
-
Copy full SHA for 9efb6b3 - Browse repository at this point
Copy the full SHA 9efb6b3View commit details
Commits on Nov 10, 2022
-
Update on "[PrototypeRS] Adding 'full stop' to halt DataPipes"
The goal of this PR is fully stop DataPipe activities in preparation of snapshotting (which requires a halted state), so buffers will not be changing while we record the snapshot. [ghstack-poisoned]
Configuration menu - View commit details
-
Copy full SHA for 50bea6c - Browse repository at this point
Copy the full SHA 50bea6cView commit details
Commits on Nov 11, 2022
-
Update on "[PrototypeRS] Adding 'full stop' to halt DataPipes"
The goal of this PR is fully stop DataPipe activities in preparation of snapshotting (which requires a halted state), so buffers will not be changing while we record the snapshot. [ghstack-poisoned]
Configuration menu - View commit details
-
Copy full SHA for a853244 - Browse repository at this point
Copy the full SHA a853244View commit details
Commits on Nov 14, 2022
-
Update on "[PrototypeRS] Adding 'pause' and 'resume' operations to ha…
…lt DataPipes" The goal of this PR is fully stop DataPipe activities in preparation of snapshotting (which requires a halted state), so buffers will not be changing while we record the snapshot. [ghstack-poisoned]
Configuration menu - View commit details
-
Copy full SHA for c88fce0 - Browse repository at this point
Copy the full SHA c88fce0View commit details
Commits on Nov 16, 2022
-
Update on "[PrototypeRS] Adding 'pause' and 'resume' operations to ha…
…lt DataPipes" The goal of this PR is fully stop DataPipe activities in preparation of snapshotting (which requires a halted state), so buffers will not be changing while we record the snapshot. [ghstack-poisoned]
Configuration menu - View commit details
-
Copy full SHA for 856e8e7 - Browse repository at this point
Copy the full SHA 856e8e7View commit details -
Update on "[PrototypeRS] Adding 'pause' and 'resume' operations to ha…
…lt DataPipes" The goal of this PR is fully stop DataPipe activities in preparation of snapshotting (which requires a halted state), so buffers will not be changing while we record the snapshot. [ghstack-poisoned]
Configuration menu - View commit details
-
Copy full SHA for 261fb9d - Browse repository at this point
Copy the full SHA 261fb9dView commit details -
Update on "[PrototypeRS] Adding 'pause' and 'resume' operations to ha…
…lt DataPipes" The goal of this PR is fully stop DataPipe activities in preparation of snapshotting (which requires a halted state), so buffers will not be changing while we record the snapshot. [ghstack-poisoned]
Configuration menu - View commit details
-
Copy full SHA for a78d5d6 - Browse repository at this point
Copy the full SHA a78d5d6View commit details
Commits on Nov 17, 2022
-
Update on "[PrototypeRS] Adding 'pause' and 'resume' operations to ha…
…lt DataPipes" The goal of this PR is fully stop DataPipe activities in preparation of snapshotting (which requires a halted state), so buffers will not be changing while we record the snapshot. [ghstack-poisoned]
Configuration menu - View commit details
-
Copy full SHA for 26c3055 - Browse repository at this point
Copy the full SHA 26c3055View commit details
Commits on Dec 3, 2022
-
Update on "[PrototypeRS] Adding 'pause' and 'resume' operations to ha…
…lt DataPipes" The goal of this PR is fully stop DataPipe activities in preparation of snapshotting (which requires a halted state), so buffers will not be changing while we record the snapshot. [ghstack-poisoned]
Configuration menu - View commit details
-
Copy full SHA for e44c4a9 - Browse repository at this point
Copy the full SHA e44c4a9View commit details -
Update on "[PrototypeRS] Adding 'pause' and 'resume' operations to ha…
…lt DataPipes" The goal of this PR is fully stop DataPipe activities in preparation of snapshotting (which requires a halted state), so buffers will not be changing while we record the snapshot. [ghstack-poisoned]
Configuration menu - View commit details
-
Copy full SHA for b7eab9d - Browse repository at this point
Copy the full SHA b7eab9dView commit details
Commits on Dec 5, 2022
-
Update on "[PrototypeRS] Adding 'pause' and 'resume' operations to ha…
…lt DataPipes" The goal of this PR is fully stop DataPipe activities in preparation of snapshotting (which requires a halted state), so buffers will not be changing while we record the snapshot. [ghstack-poisoned]
Configuration menu - View commit details
-
Copy full SHA for 2aae34f - Browse repository at this point
Copy the full SHA 2aae34fView commit details -
Update on "[PrototypeRS] Adding 'pause' and 'resume' operations to ha…
…lt DataPipes" The goal of this PR is fully stop DataPipe activities in preparation of snapshotting (which requires a halted state), so buffers will not be changing while we record the snapshot. [ghstack-poisoned]
Configuration menu - View commit details
-
Copy full SHA for 9faa78d - Browse repository at this point
Copy the full SHA 9faa78dView commit details -
Update on "[PrototypeRS] Adding 'pause' and 'resume' operations to ha…
…lt DataPipes" The goal of this PR is fully stop DataPipe activities in preparation of snapshotting (which requires a halted state), so buffers will not be changing while we record the snapshot. [ghstack-poisoned]
Configuration menu - View commit details
-
Copy full SHA for bd7dc6e - Browse repository at this point
Copy the full SHA bd7dc6eView commit details -
Update on "[PrototypeRS] Adding 'pause' and 'resume' operations to ha…
…lt DataPipes" The goal of this PR is fully stop DataPipe activities in preparation of snapshotting (which requires a halted state), so buffers will not be changing while we record the snapshot. [ghstack-poisoned]
Configuration menu - View commit details
-
Copy full SHA for 250dec3 - Browse repository at this point
Copy the full SHA 250dec3View commit details -
Update on "[PrototypeRS] Adding 'pause' and 'resume' operations to ha…
…lt DataPipes" The goal of this PR is fully stop DataPipe activities in preparation of snapshotting (which requires a halted state), so buffers will not be changing while we record the snapshot. [ghstack-poisoned]
Configuration menu - View commit details
-
Copy full SHA for ba66c1c - Browse repository at this point
Copy the full SHA ba66c1cView commit details -
Update on "[PrototypeRS] Adding 'pause' and 'resume' operations to ha…
…lt DataPipes" The goal of this PR is fully stop DataPipe activities in preparation of snapshotting (which requires a halted state), so buffers will not be changing while we record the snapshot. Differential Revision: [D41744759](https://our.internmc.facebook.com/intern/diff/D41744759) [ghstack-poisoned]
Configuration menu - View commit details
-
Copy full SHA for d5a6fa9 - Browse repository at this point
Copy the full SHA d5a6fa9View commit details -
Update on "[PrototypeRS] Adding 'pause' and 'resume' operations to ha…
…lt DataPipes" The goal of this PR is fully stop DataPipe activities in preparation of snapshotting (which requires a halted state), so buffers will not be changing while we record the snapshot. Differential Revision: [D41744759](https://our.internmc.facebook.com/intern/diff/D41744759) [ghstack-poisoned]
Configuration menu - View commit details
-
Copy full SHA for 3471a34 - Browse repository at this point
Copy the full SHA 3471a34View commit details -
Update on "[PrototypeRS] Adding 'pause' and 'resume' operations to ha…
…lt DataPipes" The goal of this PR is fully stop DataPipe activities in preparation of snapshotting (which requires a halted state), so buffers will not be changing while we record the snapshot. Differential Revision: [D41744759](https://our.internmc.facebook.com/intern/diff/D41744759) [ghstack-poisoned]
Configuration menu - View commit details
-
Copy full SHA for 865ee90 - Browse repository at this point
Copy the full SHA 865ee90View commit details -
Update on "[PrototypeRS] Adding 'pause' and 'resume' operations to ha…
…lt DataPipes" The goal of this PR is fully stop DataPipe activities in preparation of snapshotting (which requires a halted state), so buffers will not be changing while we record the snapshot. Differential Revision: [D41744759](https://our.internmc.facebook.com/intern/diff/D41744759) [ghstack-poisoned]
Configuration menu - View commit details
-
Copy full SHA for ab24eb9 - Browse repository at this point
Copy the full SHA ab24eb9View commit details -
Update on "[PrototypeRS] Adding 'pause' and 'resume' operations to ha…
…lt DataPipes" The goal of this PR is fully stop DataPipe activities in preparation of snapshotting (which requires a halted state), so buffers will not be changing while we record the snapshot. Differential Revision: [D41744759](https://our.internmc.facebook.com/intern/diff/D41744759) [ghstack-poisoned]
Configuration menu - View commit details
-
Copy full SHA for c0c7dec - Browse repository at this point
Copy the full SHA c0c7decView commit details -
Update on "[PrototypeRS] Adding 'pause' and 'resume' operations to ha…
…lt DataPipes" The goal of this PR is fully stop DataPipe activities in preparation of snapshotting (which requires a halted state), so buffers will not be changing while we record the snapshot. Differential Revision: [D41744759](https://our.internmc.facebook.com/intern/diff/D41744759) [ghstack-poisoned]
Configuration menu - View commit details
-
Copy full SHA for c483e96 - Browse repository at this point
Copy the full SHA c483e96View commit details
Commits on Dec 7, 2022
-
Update on "[PrototypeRS] Adding 'pause' and 'resume' operations to ha…
…lt DataPipes" The goal of this PR is fully stop DataPipe activities in preparation of snapshotting (which requires a halted state), so buffers will not be changing while we record the snapshot. Differential Revision: [D41744759](https://our.internmc.facebook.com/intern/diff/D41744759) [ghstack-poisoned]
Configuration menu - View commit details
-
Copy full SHA for 031af83 - Browse repository at this point
Copy the full SHA 031af83View commit details -
Update on "[PrototypeRS] Adding 'pause' and 'resume' operations to ha…
…lt DataPipes" The goal of this PR is fully stop DataPipe activities in preparation of snapshotting (which requires a halted state), so buffers will not be changing while we record the snapshot. Differential Revision: [D41744759](https://our.internmc.facebook.com/intern/diff/D41744759) [ghstack-poisoned]
Configuration menu - View commit details
-
Copy full SHA for ac017f2 - Browse repository at this point
Copy the full SHA ac017f2View commit details -
Update on "[PrototypeRS] Adding 'pause' and 'resume' operations to ha…
…lt DataPipes" The goal of this PR is fully stop DataPipe activities in preparation of snapshotting (which requires a halted state), so buffers will not be changing while we record the snapshot. Differential Revision: [D41744759](https://our.internmc.facebook.com/intern/diff/D41744759) [ghstack-poisoned]
Configuration menu - View commit details
-
Copy full SHA for eb6f3fb - Browse repository at this point
Copy the full SHA eb6f3fbView commit details
Commits on Dec 14, 2022
-
Update on "[PrototypeRS] Adding 'pause' and 'resume' operations to ha…
…lt DataPipes" The goal of this PR is fully stop DataPipe activities in preparation of snapshotting (which requires a halted state), so buffers will not be changing while we record the snapshot. Differential Revision: [D41744759](https://our.internmc.facebook.com/intern/diff/D41744759) [ghstack-poisoned]
Configuration menu - View commit details
-
Copy full SHA for 80c65e0 - Browse repository at this point
Copy the full SHA 80c65e0View commit details
Commits on Dec 15, 2022
-
Update on "[PrototypeRS] Adding 'pause' and 'resume' operations to ha…
…lt DataPipes" The goal of this PR is fully stop DataPipe activities in preparation of snapshotting (which requires a halted state), so buffers will not be changing while we record the snapshot. Differential Revision: [D41744759](https://our.internmc.facebook.com/intern/diff/D41744759) [ghstack-poisoned]
Configuration menu - View commit details
-
Copy full SHA for ea7952f - Browse repository at this point
Copy the full SHA ea7952fView commit details
Commits on Dec 17, 2022
-
Update on "[PrototypeRS] Adding 'pause' and 'resume' operations to ha…
…lt DataPipes" The goal of this PR is fully stop DataPipe activities in preparation of snapshotting (which requires a halted state), so buffers will not be changing while we record the snapshot. Differential Revision: [D41744759](https://our.internmc.facebook.com/intern/diff/D41744759) [ghstack-poisoned]
Configuration menu - View commit details
-
Copy full SHA for b960db3 - Browse repository at this point
Copy the full SHA b960db3View commit details
Commits on Dec 18, 2022
-
Update on "[PrototypeRS] Adding 'pause' and 'resume' operations to ha…
…lt DataPipes" The goal of this PR is fully stop DataPipe activities in preparation of snapshotting (which requires a halted state), so buffers will not be changing while we record the snapshot. Differential Revision: [D41744759](https://our.internmc.facebook.com/intern/diff/D41744759) [ghstack-poisoned]
Configuration menu - View commit details
-
Copy full SHA for 08db7ea - Browse repository at this point
Copy the full SHA 08db7eaView commit details
Commits on Jan 3, 2023
-
Update on "[PrototypeRS] Adding 'pause' and 'resume' operations to ha…
…lt DataPipes" The goal of this PR is fully stop DataPipe activities in preparation of snapshotting (which requires a halted state), so buffers will not be changing while we record the snapshot. Differential Revision: [D41744759](https://our.internmc.facebook.com/intern/diff/D41744759) [ghstack-poisoned]
Configuration menu - View commit details
-
Copy full SHA for cb6f017 - Browse repository at this point
Copy the full SHA cb6f017View commit details
Commits on Jan 13, 2023
-
Update on "[PrototypeRS] Adding 'pause' and 'resume' operations to ha…
…lt DataPipes" The goal of this PR is fully stop DataPipe activities in preparation of snapshotting (which requires a halted state), so buffers will not be changing while we record the snapshot. Differential Revision: [D41744759](https://our.internmc.facebook.com/intern/diff/D41744759) [ghstack-poisoned]
Configuration menu - View commit details
-
Copy full SHA for b70b3a7 - Browse repository at this point
Copy the full SHA b70b3a7View commit details
Commits on Jan 18, 2023
-
Update on "[PrototypeRS] Adding 'pause' and 'resume' operations to ha…
…lt DataPipes" The goal of this PR is fully stop DataPipe activities in preparation of snapshotting (which requires a halted state), so buffers will not be changing while we record the snapshot. Differential Revision: [D41744759](https://our.internmc.facebook.com/intern/diff/D41744759) [ghstack-poisoned]
Configuration menu - View commit details
-
Copy full SHA for c57c4c4 - Browse repository at this point
Copy the full SHA c57c4c4View commit details -
Update on "[PrototypeRS] Adding 'pause' and 'resume' operations to ha…
…lt DataPipes" The goal of this PR is fully stop DataPipe activities in preparation of snapshotting (which requires a halted state), so buffers will not be changing while we record the snapshot. --- Implementation note (feel free to discuss): `_pause` exists for both `DataLoader2Iterator` and `DataLoader2` as private methods. `resume` exists for both `DataLoader2Iterator` and `DataLoader2` as public methods. `limit` and `clear_limit` exist only for `DataLoader2Iterator` as a public methods. - Limit persists through iterations (with the iterator) until it is manually cleared via `clear_limit`. - Creating a new iterator (`iter(dl2)`) will not retain the previous limit, because the limit is attached to the iterator. Differential Revision: [D41744759](https://our.internmc.facebook.com/intern/diff/D41744759) [ghstack-poisoned]
Configuration menu - View commit details
-
Copy full SHA for 314cc4c - Browse repository at this point
Copy the full SHA 314cc4cView commit details -
Update on "[PrototypeRS] Adding 'pause' and 'resume' operations to ha…
…lt DataPipes" The goal of this PR is fully stop DataPipe activities in preparation of snapshotting (which requires a halted state), so buffers will not be changing while we record the snapshot. --- Implementation note (feel free to discuss): `_pause` exists for both `DataLoader2Iterator` and `DataLoader2` as private methods. `resume` exists for both `DataLoader2Iterator` as public but it is private for `DataLoader2`. `limit` and `clear_limit` exist only for `DataLoader2Iterator` as a public methods. - Limit persists through iterations (with the iterator) until it is manually cleared via `clear_limit`. - Creating a new iterator (`iter(dl2)`) will not retain the previous limit, because the limit is attached to the iterator. Differential Revision: [D41744759](https://our.internmc.facebook.com/intern/diff/D41744759) [ghstack-poisoned]
Configuration menu - View commit details
-
Copy full SHA for d209b6a - Browse repository at this point
Copy the full SHA d209b6aView commit details
Commits on Jan 24, 2023
-
Update on "[PrototypeRS] Adding 'pause' and 'resume' operations to ha…
…lt DataPipes" The goal of this PR is fully stop DataPipe activities in preparation of snapshotting (which requires a halted state), so buffers will not be changing while we record the snapshot. --- Implementation note (feel free to discuss): `_pause` exists for both `DataLoader2Iterator` and `DataLoader2` as private methods. `resume` exists for both `DataLoader2Iterator` as public but it is private for `DataLoader2`. `limit` and `clear_limit` exist only for `DataLoader2Iterator` as a public methods. - Limit persists through iterations (with the iterator) until it is manually cleared via `clear_limit`. - Creating a new iterator (`iter(dl2)`) will not retain the previous limit, because the limit is attached to the iterator. Differential Revision: [D41744759](https://our.internmc.facebook.com/intern/diff/D41744759) [ghstack-poisoned]
Configuration menu - View commit details
-
Copy full SHA for 84d5346 - Browse repository at this point
Copy the full SHA 84d5346View commit details
Commits on Feb 2, 2023
-
Update on "[PrototypeRS] Adding 'pause' and 'resume' operations to ha…
…lt DataPipes" The goal of this PR is fully stop DataPipe activities in preparation of snapshotting (which requires a halted state), so buffers will not be changing while we record the snapshot. --- Implementation note (feel free to discuss): `_pause` exists for both `DataLoader2Iterator` and `DataLoader2` as private methods. `resume` exists for both `DataLoader2Iterator` as public but it is private for `DataLoader2`. `limit` and `clear_limit` exist only for `DataLoader2Iterator` as a public methods. - Limit persists through iterations (with the iterator) until it is manually cleared via `clear_limit`. - Creating a new iterator (`iter(dl2)`) will not retain the previous limit, because the limit is attached to the iterator. Differential Revision: [D41744759](https://our.internmc.facebook.com/intern/diff/D41744759) [ghstack-poisoned]
Configuration menu - View commit details
-
Copy full SHA for 29a4fd0 - Browse repository at this point
Copy the full SHA 29a4fd0View commit details
Commits on Feb 6, 2023
-
Update on "[PrototypeRS] Adding 'pause' and 'resume' operations to ha…
…lt DataPipes" The goal of this PR is fully stop DataPipe activities in preparation of snapshotting (which requires a halted state), so buffers will not be changing while we record the snapshot. --- Implementation note (feel free to discuss): `_pause` exists for both `DataLoader2Iterator` and `DataLoader2` as private methods. `resume` exists for both `DataLoader2Iterator` as public but it is private for `DataLoader2`. `limit` and `clear_limit` exist only for `DataLoader2Iterator` as a public methods. - Limit persists through iterations (with the iterator) until it is manually cleared via `clear_limit`. - Creating a new iterator (`iter(dl2)`) will not retain the previous limit, because the limit is attached to the iterator. Differential Revision: [D41744759](https://our.internmc.facebook.com/intern/diff/D41744759) [ghstack-poisoned]
Configuration menu - View commit details
-
Copy full SHA for a1ecb98 - Browse repository at this point
Copy the full SHA a1ecb98View commit details
Commits on Feb 7, 2023
-
Update on "[PrototypeRS] Adding 'pause' and 'resume' operations to ha…
…lt DataPipes" The goal of this PR is fully stop DataPipe activities in preparation of snapshotting (which requires a halted state), so buffers will not be changing while we record the snapshot. This PR doesn't handle pausing or resuming with `sharding_round_robin_dispatch`. This will be fixed in an upcoming PR and is tracked by #991. --- Implementation note (feel free to discuss): `_pause` exists for both `DataLoader2Iterator` and `DataLoader2` as private methods. `resume` exists for both `DataLoader2Iterator` as public but it is private for `DataLoader2`. `limit` and `clear_limit` exist only for `DataLoader2Iterator` as a public methods. - Limit persists through iterations (with the iterator) until it is manually cleared via `clear_limit`. - Creating a new iterator (`iter(dl2)`) will not retain the previous limit, because the limit is attached to the iterator. Differential Revision: [D41744759](https://our.internmc.facebook.com/intern/diff/D41744759) [ghstack-poisoned]
Configuration menu - View commit details
-
Copy full SHA for dc72f20 - Browse repository at this point
Copy the full SHA dc72f20View commit details
Commits on Feb 8, 2023
-
Update on "[PrototypeRS] Adding 'pause' and 'resume' operations to ha…
…lt DataPipes" The goal of this PR is fully stop DataPipe activities in preparation of snapshotting (which requires a halted state), so buffers will not be changing while we record the snapshot. This PR doesn't handle pausing or resuming with `sharding_round_robin_dispatch`. This will be fixed in an upcoming PR and is tracked by #991. --- Implementation note (feel free to discuss): `_pause` exists for both `DataLoader2Iterator` and `DataLoader2` as private methods. `resume` exists for both `DataLoader2Iterator` as public but it is private for `DataLoader2`. `limit` and `clear_limit` exist only for `DataLoader2Iterator` as a public methods. - Limit persists through iterations (with the iterator) until it is manually cleared via `clear_limit`. - Creating a new iterator (`iter(dl2)`) will not retain the previous limit, because the limit is attached to the iterator. Differential Revision: [D41744759](https://our.internmc.facebook.com/intern/diff/D41744759) [ghstack-poisoned]
Configuration menu - View commit details
-
Copy full SHA for 76219c7 - Browse repository at this point
Copy the full SHA 76219c7View commit details -
Update on "[PrototypeRS] Adding 'pause' and 'resume' operations to ha…
…lt DataPipes" The goal of this PR is fully stop DataPipe activities in preparation of snapshotting (which requires a halted state), so buffers will not be changing while we record the snapshot. This PR doesn't handle pausing or resuming with `sharding_round_robin_dispatch`. This will be fixed in an upcoming PR and is tracked by #991. --- Implementation note (feel free to discuss): `_pause` exists for both `DataLoader2Iterator` and `DataLoader2` as private methods. `resume` exists for both `DataLoader2Iterator` as public but it is private for `DataLoader2`. `limit` and `clear_limit` exist only for `DataLoader2Iterator` as a public methods. - Limit persists through iterations (with the iterator) until it is manually cleared via `clear_limit`. - Creating a new iterator (`iter(dl2)`) will not retain the previous limit, because the limit is attached to the iterator. Differential Revision: [D41744759](https://our.internmc.facebook.com/intern/diff/D41744759) [ghstack-poisoned]
Configuration menu - View commit details
-
Copy full SHA for e5b2544 - Browse repository at this point
Copy the full SHA e5b2544View commit details -
Update on "[PrototypeRS] Adding 'pause' and 'resume' operations to ha…
…lt DataPipes" The goal of this PR is fully stop DataPipe activities in preparation of snapshotting (which requires a halted state), so buffers will not be changing while we record the snapshot. This PR doesn't handle pausing or resuming with `sharding_round_robin_dispatch`. This will be fixed in an upcoming PR and is tracked by #991. --- Implementation note (feel free to discuss): `_pause` exists for both `DataLoader2Iterator` and `DataLoader2` as private methods. `resume` exists for both `DataLoader2Iterator` as public but it is private for `DataLoader2`. `limit` and `clear_limit` exist only for `DataLoader2Iterator` as a public methods. - Limit persists through iterations (with the iterator) until it is manually cleared via `clear_limit`. - Creating a new iterator (`iter(dl2)`) will not retain the previous limit, because the limit is attached to the iterator. Differential Revision: [D41744759](https://our.internmc.facebook.com/intern/diff/D41744759) [ghstack-poisoned]
Configuration menu - View commit details
-
Copy full SHA for caeb103 - Browse repository at this point
Copy the full SHA caeb103View commit details -
Update on "[PrototypeRS] Adding 'pause' and 'resume' operations to ha…
…lt DataPipes" The goal of this PR is fully stop DataPipe activities in preparation of snapshotting (which requires a halted state), so buffers will not be changing while we record the snapshot. This PR doesn't handle pausing or resuming with `sharding_round_robin_dispatch`. This will be fixed in an upcoming PR and is tracked by #991. --- Implementation note (feel free to discuss): `_pause` exists for both `DataLoader2Iterator` and `DataLoader2` as private methods. `resume` exists for both `DataLoader2Iterator` as public but it is private for `DataLoader2`. `limit` and `clear_limit` exist only for `DataLoader2Iterator` as a public methods. - Limit persists through iterations (with the iterator) until it is manually cleared via `clear_limit`. - Creating a new iterator (`iter(dl2)`) will not retain the previous limit, because the limit is attached to the iterator. Differential Revision: [D41744759](https://our.internmc.facebook.com/intern/diff/D41744759) [ghstack-poisoned]
Configuration menu - View commit details
-
Copy full SHA for 491cb41 - Browse repository at this point
Copy the full SHA 491cb41View commit details
Commits on Feb 9, 2023
-
Update on "[PrototypeRS] Adding 'pause' and 'resume' operations to ha…
…lt DataPipes" The goal of this PR is fully stop DataPipe activities in preparation of snapshotting (which requires a halted state), so buffers will not be changing while we record the snapshot. This PR doesn't handle pausing or resuming with `sharding_round_robin_dispatch`. This will be fixed in an upcoming PR and is tracked by #991. --- Implementation note (feel free to discuss): `_pause` exists for both `DataLoader2Iterator` and `DataLoader2` as private methods. `resume` exists for both `DataLoader2Iterator` as public but it is private for `DataLoader2`. `limit` and `clear_limit` exist only for `DataLoader2Iterator` as a public methods. - Limit persists through iterations (with the iterator) until it is manually cleared via `clear_limit`. - Creating a new iterator (`iter(dl2)`) will not retain the previous limit, because the limit is attached to the iterator. Differential Revision: [D41744759](https://our.internmc.facebook.com/intern/diff/D41744759) [ghstack-poisoned]
Configuration menu - View commit details
-
Copy full SHA for 00cbd0e - Browse repository at this point
Copy the full SHA 00cbd0eView commit details -
Update on "[PrototypeRS] Adding 'pause' and 'resume' operations to ha…
…lt DataPipes" The goal of this PR is fully stop DataPipe activities in preparation of snapshotting (which requires a halted state), so buffers will not be changing while we record the snapshot. This PR doesn't handle pausing or resuming with `sharding_round_robin_dispatch`. This will be fixed in an upcoming PR and is tracked by #991. --- Implementation note (feel free to discuss): `_pause` exists for both `DataLoader2Iterator` and `DataLoader2` as private methods. `resume` exists for both `DataLoader2Iterator` as public but it is private for `DataLoader2`. `limit` and `clear_limit` exist only for `DataLoader2Iterator` as a public methods. - Limit persists through iterations (with the iterator) until it is manually cleared via `clear_limit`. - Creating a new iterator (`iter(dl2)`) will not retain the previous limit, because the limit is attached to the iterator. Differential Revision: [D41744759](https://our.internmc.facebook.com/intern/diff/D41744759) [ghstack-poisoned]
Configuration menu - View commit details
-
Copy full SHA for 7506f01 - Browse repository at this point
Copy the full SHA 7506f01View commit details
Commits on Feb 10, 2023
-
Update on "[PrototypeRS] Adding 'pause' and 'resume' operations to ha…
…lt DataPipes" The goal of this PR is fully stop DataPipe activities in preparation of snapshotting (which requires a halted state), so buffers will not be changing while we record the snapshot. This PR doesn't handle pausing or resuming with `sharding_round_robin_dispatch`. This will be fixed in an upcoming PR and is tracked by #991. --- Implementation note (feel free to discuss): `_pause` exists for both `DataLoader2Iterator` and `DataLoader2` as private methods. `resume` exists for both `DataLoader2Iterator` as public but it is private for `DataLoader2`. `limit` and `clear_limit` exist only for `DataLoader2Iterator` as a public methods. - Limit persists through iterations (with the iterator) until it is manually cleared via `clear_limit`. - Creating a new iterator (`iter(dl2)`) will not retain the previous limit, because the limit is attached to the iterator. Differential Revision: [D41744759](https://our.internmc.facebook.com/intern/diff/D41744759) [ghstack-poisoned]
Configuration menu - View commit details
-
Copy full SHA for 01bb5c7 - Browse repository at this point
Copy the full SHA 01bb5c7View commit details