[DataPipe] Update Prefetcher buffer to use deque #842
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ghstack-poisoned]
NivekT
added a commit
that referenced
this pull request
Oct 19, 2022
ghstack-source-id: 1e57f367191689b18d4b65969c7031eaad10a0eb Pull Request resolved: #842
facebook-github-bot
added
the
CLA Signed
|
@NivekT has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
VitalyFedyunin
approved these changes
Oct 20, 2022
ejguan
pushed a commit
to ejguan/data
that referenced
this pull request
Oct 21, 2022
Summary: Pull Request resolved: pytorch#842 This was one of the TODOs in Prefetcher. It makes the implementation cleaner, marginally faster (but not enough to make a significant difference). Test Plan: Imported from OSS Reviewed By: VitalyFedyunin Differential Revision: D40517618 Pulled By: NivekT fbshipit-source-id: a199c06b060a83e087a3cac17ec57c87a7127c40
ejguan
pushed a commit
that referenced
this pull request
Oct 21, 2022
Summary: Pull Request resolved: #842 This was one of the TODOs in Prefetcher. It makes the implementation cleaner, marginally faster (but not enough to make a significant difference). Test Plan: Imported from OSS Reviewed By: VitalyFedyunin Differential Revision: D40517618 Pulled By: NivekT fbshipit-source-id: a199c06b060a83e087a3cac17ec57c87a7127c40
ejguan
pushed a commit
to ejguan/data
that referenced
this pull request
Oct 23, 2022
Summary: Pull Request resolved: pytorch#842 This was one of the TODOs in Prefetcher. It makes the implementation cleaner, marginally faster (but not enough to make a significant difference). Test Plan: Imported from OSS Reviewed By: VitalyFedyunin Differential Revision: D40517618 Pulled By: NivekT fbshipit-source-id: a199c06b060a83e087a3cac17ec57c87a7127c40
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
This was one of the TODOs in Prefetcher. It makes the implementation cleaner, marginally faster (but not enough to make a significant difference).
Differential Revision: D40517618