[DataLoader2] Fix PrototypeRS issue related to termination #837
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ghstack-poisoned]
NivekT
added a commit
that referenced
this pull request
Oct 18, 2022
ghstack-source-id: c595665efbd96dbf1863ecfb90002208f06fa565 Pull Request resolved: #837
facebook-github-bot
added
the
CLA Signed
|
@NivekT has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
VitalyFedyunin
approved these changes
Oct 18, 2022
ejguan
reviewed
Oct 18, 2022
ejguan
pushed a commit
to ejguan/data
that referenced
this pull request
Oct 21, 2022
Summary: Pull Request resolved: pytorch#837 With this PR, PrototypeRS's child processes will be daemon processes such that they terminate when the main one does. Due to the non-deterministic nature of destruction, additional exception handling is required. Fixes pytorch#806 Test Plan: Imported from OSS Reviewed By: VitalyFedyunin Differential Revision: D40485829 Pulled By: NivekT fbshipit-source-id: bd1fcf32956ac5a2abef560dd9a44f1f76e24f45
ejguan
pushed a commit
that referenced
this pull request
Oct 21, 2022
Summary: Pull Request resolved: #837 With this PR, PrototypeRS's child processes will be daemon processes such that they terminate when the main one does. Due to the non-deterministic nature of destruction, additional exception handling is required. Fixes #806 Test Plan: Imported from OSS Reviewed By: VitalyFedyunin Differential Revision: D40485829 Pulled By: NivekT fbshipit-source-id: bd1fcf32956ac5a2abef560dd9a44f1f76e24f45
ejguan
pushed a commit
to ejguan/data
that referenced
this pull request
Oct 23, 2022
Summary: Pull Request resolved: pytorch#837 With this PR, PrototypeRS's child processes will be daemon processes such that they terminate when the main one does. Due to the non-deterministic nature of destruction, additional exception handling is required. Fixes pytorch#806 Test Plan: Imported from OSS Reviewed By: VitalyFedyunin Differential Revision: D40485829 Pulled By: NivekT fbshipit-source-id: bd1fcf32956ac5a2abef560dd9a44f1f76e24f45
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
With this PR, PrototypeRS's child processes will be daemon processes such that they terminate when the main one does. Due to the non-deterministic nature of destruction, additional exception handling is required.
Fixes #806
Differential Revision: D40485829